diff --git a/packages/server/src/api/controllers/view/viewsV2.ts b/packages/server/src/api/controllers/view/viewsV2.ts index 8cb0a14150..1b6b7a5f31 100644 --- a/packages/server/src/api/controllers/view/viewsV2.ts +++ b/packages/server/src/api/controllers/view/viewsV2.ts @@ -4,7 +4,6 @@ import { Ctx, FetchViewResponse, ViewResponse, - ViewV2, } from "@budibase/types" export async function fetch(ctx: Ctx) { @@ -34,10 +33,11 @@ export async function find(ctx: Ctx) { } } -export async function save(ctx: Ctx) { +export async function create(ctx: Ctx) { const view = ctx.request.body - const result = await sdk.views.save(view) + const result = await sdk.views.create(view) + ctx.status = 201 ctx.body = { data: { ...view, diff --git a/packages/server/src/api/routes/tests/viewV2.spec.ts b/packages/server/src/api/routes/tests/viewV2.spec.ts index 52c4b3d55b..bc5c13297a 100644 --- a/packages/server/src/api/routes/tests/viewV2.spec.ts +++ b/packages/server/src/api/routes/tests/viewV2.spec.ts @@ -133,9 +133,7 @@ describe("/v2/views", () => { .send(newView) .set(config.defaultHeaders()) .expect("Content-Type", /json/) - .expect(200) - expect(res.status).toBe(200) - expect(res.body.data._id).toBeDefined() + .expect(201) expect(res.body).toEqual({ data: { diff --git a/packages/server/src/api/routes/view.ts b/packages/server/src/api/routes/view.ts index 5fa4fe17f0..155fce1aad 100644 --- a/packages/server/src/api/routes/view.ts +++ b/packages/server/src/api/routes/view.ts @@ -21,7 +21,7 @@ router .post( "/api/v2/views", authorized(permissions.BUILDER), - viewController.v2.save + viewController.v2.create ) .delete( `/api/v2/views/:viewId`, diff --git a/packages/server/src/sdk/app/views/index.ts b/packages/server/src/sdk/app/views/index.ts index 60f886c2e2..fbac7b757a 100644 --- a/packages/server/src/sdk/app/views/index.ts +++ b/packages/server/src/sdk/app/views/index.ts @@ -47,7 +47,7 @@ export async function get(viewId: string): Promise { } } -export async function save(view: ViewV2): Promise { +export async function create(view: ViewV2): Promise { const db = context.getAppDB() const response = await db.put( diff --git a/packages/server/src/tests/utilities/api/viewV2.ts b/packages/server/src/tests/utilities/api/viewV2.ts index 1927c1a8bc..5c838e50fb 100644 --- a/packages/server/src/tests/utilities/api/viewV2.ts +++ b/packages/server/src/tests/utilities/api/viewV2.ts @@ -23,7 +23,7 @@ export class ViewV2API extends TestAPI { .send(view) .set(this.config.defaultHeaders()) .expect("Content-Type", /json/) - .expect(200) + .expect(201) return result.body.data as ViewV2 } get = (viewId: string): supertest.Test => {