From 46d5c58d95ce6e4ba2daf9e5e189a706ea97fa41 Mon Sep 17 00:00:00 2001
From: Peter Clement <peter@budibase.com>
Date: Wed, 1 Feb 2023 14:43:31 +0000
Subject: [PATCH 1/3] disallow spaces in env var names

---
 .../builder/portal/settings/environment/index.svelte   | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/builder/src/pages/builder/portal/settings/environment/index.svelte b/packages/builder/src/pages/builder/portal/settings/environment/index.svelte
index 6ffe261e31..3c170235e9 100644
--- a/packages/builder/src/pages/builder/portal/settings/environment/index.svelte
+++ b/packages/builder/src/pages/builder/portal/settings/environment/index.svelte
@@ -25,8 +25,14 @@
   $: schema = buildSchema(noEncryptionKey)
 
   onMount(async () => {
-    await environment.checkStatus()
-    await environment.loadVariables()
+    try {
+      await environment.checkStatus()
+      await environment.loadVariables()
+    } catch (error) {
+      notifications.error(
+        `Error loading environment variables: ${error.message}`
+      )
+    }
   })
 
   const buildSchema = noEncryptionKey => {

From 12cc927b1645927a34d096b2e63e2dd6fdf307d8 Mon Sep 17 00:00:00 2001
From: Peter Clement <peter@budibase.com>
Date: Wed, 1 Feb 2023 14:44:53 +0000
Subject: [PATCH 2/3] add warning modals to app export buttons

---
 .../bbui/src/Form/Core/EnvDropdown.svelte     |  5 -----
 .../CreateEditVariableModal.svelte            | 10 ++++++++-
 .../components/start/ExportAppModal.svelte    |  9 +++-----
 .../pages/builder/portal/apps/index.svelte    | 21 +++++++++++++++++--
 4 files changed, 31 insertions(+), 14 deletions(-)

diff --git a/packages/bbui/src/Form/Core/EnvDropdown.svelte b/packages/bbui/src/Form/Core/EnvDropdown.svelte
index f40d6556e5..acb842f350 100644
--- a/packages/bbui/src/Form/Core/EnvDropdown.svelte
+++ b/packages/bbui/src/Form/Core/EnvDropdown.svelte
@@ -246,11 +246,6 @@
   .spectrum-Popover.spectrum-Popover--bottom.spectrum-Picker-popover.is-open {
     width: 100%;
   }
-
-  .no-variables-height {
-    height: 100px;
-  }
-
   .no-variables-text {
     padding: var(--spacing-m);
     color: var(--spectrum-global-color-gray-600);
diff --git a/packages/builder/src/components/portal/environment/CreateEditVariableModal.svelte b/packages/builder/src/components/portal/environment/CreateEditVariableModal.svelte
index c76cb7d468..602a054eaf 100644
--- a/packages/builder/src/components/portal/environment/CreateEditVariableModal.svelte
+++ b/packages/builder/src/components/portal/environment/CreateEditVariableModal.svelte
@@ -22,6 +22,8 @@
   let developmentValue
   let useProductionValue = true
 
+  const HasSpacesRegex = /[\\"\s]/
+
   const deleteVariable = async name => {
     try {
       await environment.deleteVariable(name)
@@ -47,10 +49,16 @@
 </script>
 
 <ModalContent
+  disabled={HasSpacesRegex.test(name)}
   onConfirm={() => saveVariable()}
   title={!row ? "Add new environment variable" : "Edit environment variable"}
 >
-  <Input disabled={row} label="Name" bind:value={name} />
+  <Input
+    disabled={row}
+    label="Name"
+    bind:value={name}
+    error={HasSpacesRegex.test(name) && "Must not include spaces"}
+  />
   <div>
     <Heading size="XS">Production</Heading>
     <Input
diff --git a/packages/builder/src/components/start/ExportAppModal.svelte b/packages/builder/src/components/start/ExportAppModal.svelte
index c523dbf87b..948416b192 100644
--- a/packages/builder/src/components/start/ExportAppModal.svelte
+++ b/packages/builder/src/components/start/ExportAppModal.svelte
@@ -1,6 +1,5 @@
 <script>
   import { ModalContent, Toggle, Body, InlineAlert } from "@budibase/bbui"
-  import { licensing } from "stores/portal"
 
   export let app
   export let published
@@ -17,11 +16,9 @@
 </script>
 
 <ModalContent {title} {confirmText} onConfirm={exportApp}>
-  {#if licensing.environmentVariablesEnabled}
-    <InlineAlert
-      header="Do not share your budibase application exports publicly as they may contain sensitive information such as database credentials or secret keys."
-    />
-  {/if}
+  <InlineAlert
+    header="Do not share your budibase application exports publicly as they may contain sensitive information such as database credentials or secret keys."
+  />
   <Body
     >Apps can be exported with or without data that is within internal tables -
     select this below.</Body
diff --git a/packages/builder/src/pages/builder/portal/apps/index.svelte b/packages/builder/src/pages/builder/portal/apps/index.svelte
index c91ba6c437..2b76528343 100644
--- a/packages/builder/src/pages/builder/portal/apps/index.svelte
+++ b/packages/builder/src/pages/builder/portal/apps/index.svelte
@@ -11,15 +11,17 @@
     Body,
     Icon,
     Search,
+    InlineAlert,
   } from "@budibase/bbui"
   import Spinner from "components/common/Spinner.svelte"
   import CreateAppModal from "components/start/CreateAppModal.svelte"
   import AppLimitModal from "components/portal/licensing/AppLimitModal.svelte"
+  import ConfirmDialog from "components/common/ConfirmDialog.svelte"
 
   import { store, automationStore } from "builderStore"
   import { API } from "api"
   import { onMount } from "svelte"
-  import { apps, auth, admin, licensing } from "stores/portal"
+  import { apps, auth, admin, licensing, environment } from "stores/portal"
   import { goto } from "@roxi/routify"
   import AppRow from "components/start/AppRow.svelte"
   import { AppStatus } from "constants"
@@ -35,6 +37,7 @@
   let creatingFromTemplate = false
   let automationErrors
   let accessFilterList = null
+  let confirmDownloadDialog
 
   $: welcomeHeader = `Welcome ${$auth?.user?.firstName || "back"}`
   $: enrichedApps = enrichApps($apps, $auth.user, sortBy)
@@ -193,6 +196,7 @@
 
   onMount(async () => {
     try {
+      await environment.loadVariables()
       // If the portal is loaded from an external URL with a template param
       const initInfo = await auth.getInitInfo()
       if (initInfo?.init_template) {
@@ -275,7 +279,8 @@
                   <Icon
                     name="Download"
                     hoverable
-                    on:click={initiateAppsExport}
+                    tooltip="test"
+                    on:click={confirmDownloadDialog.show}
                   />
                 {/if}
                 <Select
@@ -323,6 +328,18 @@
 
 <AppLimitModal bind:this={appLimitModal} />
 
+<ConfirmDialog
+  bind:this={confirmDownloadDialog}
+  okText="Continue"
+  onOk={initiateAppsExport}
+  warning={false}
+  title="Download all apps"
+>
+  <InlineAlert
+    header="Do not share your budibase application exports publicly as they may contain sensitive information such as database credentials or secret keys."
+  />
+</ConfirmDialog>
+
 <style>
   .title {
     display: flex;

From af335b434958b42b3a6aaa151a8297738a8db215 Mon Sep 17 00:00:00 2001
From: Peter Clement <peter@budibase.com>
Date: Wed, 1 Feb 2023 14:55:39 +0000
Subject: [PATCH 3/3] remove uneeded tooltip

---
 packages/builder/src/pages/builder/portal/apps/index.svelte | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/builder/src/pages/builder/portal/apps/index.svelte b/packages/builder/src/pages/builder/portal/apps/index.svelte
index 2b76528343..4ddff12644 100644
--- a/packages/builder/src/pages/builder/portal/apps/index.svelte
+++ b/packages/builder/src/pages/builder/portal/apps/index.svelte
@@ -279,7 +279,6 @@
                   <Icon
                     name="Download"
                     hoverable
-                    tooltip="test"
                     on:click={confirmDownloadDialog.show}
                   />
                 {/if}