From e0071cabfd0dec950acb78ea7896ffa48e7582c6 Mon Sep 17 00:00:00 2001
From: Martin McKeaveney <martin@shogunsystems.co.uk>
Date: Wed, 25 Nov 2020 15:03:19 +0000
Subject: [PATCH] extract constant

---
 .../server/src/api/controllers/application.js | 33 ++---------------
 packages/server/src/constants/index.js        | 35 +++++++++++++++++++
 2 files changed, 37 insertions(+), 31 deletions(-)

diff --git a/packages/server/src/api/controllers/application.js b/packages/server/src/api/controllers/application.js
index 47af422f57..2cbb84d240 100644
--- a/packages/server/src/api/controllers/application.js
+++ b/packages/server/src/api/controllers/application.js
@@ -26,6 +26,7 @@ const {
 const { MAIN, UNAUTHENTICATED, PageTypes } = require("../../constants/pages")
 const { HOME_SCREEN } = require("../../constants/screens")
 const { cloneDeep } = require("lodash/fp")
+const { USERS_TABLE_SCHEMA } = require("../../constants")
 
 const APP_PREFIX = DocumentTypes.APP + SEPARATOR
 
@@ -69,37 +70,7 @@ async function createInstance(template) {
     }
   } else {
     // create the users table
-    await db.put({
-      _id: "ta_users",
-      type: "table",
-      views: {},
-      name: "Users",
-      schema: {
-        username: {
-          type: "string",
-          constraints: {
-            type: "string",
-            length: {
-              maximum: "",
-            },
-            presence: true,
-          },
-          fieldName: "username",
-          name: "username",
-        },
-        accessLevelId: {
-          fieldName: "accessLevelId",
-          name: "accessLevelId",
-          type: "options",
-          constraints: {
-            type: "string",
-            presence: false,
-            inclusion: Object.values(BUILTIN_LEVEL_IDS),
-          },
-        },
-      },
-      primaryDisplay: "username",
-    })
+    await db.put(USERS_TABLE_SCHEMA)
   }
 
   return { _id: appId }
diff --git a/packages/server/src/constants/index.js b/packages/server/src/constants/index.js
index cae1cde3e8..24fe45eb6b 100644
--- a/packages/server/src/constants/index.js
+++ b/packages/server/src/constants/index.js
@@ -1,7 +1,42 @@
+const { BUILTIN_LEVEL_IDS } = require("../utilities/security/accessLevels")
+
 const AuthTypes = {
   APP: "app",
   BUILDER: "builder",
   EXTERNAL: "external",
 }
 
+const USERS_TABLE_SCHEMA = {
+  _id: "ta_users",
+  type: "table",
+  views: {},
+  name: "Users",
+  schema: {
+    username: {
+      type: "string",
+      constraints: {
+        type: "string",
+        length: {
+          maximum: "",
+        },
+        presence: true,
+      },
+      fieldName: "username",
+      name: "username",
+    },
+    accessLevelId: {
+      fieldName: "accessLevelId",
+      name: "accessLevelId",
+      type: "options",
+      constraints: {
+        type: "string",
+        presence: false,
+        inclusion: Object.keys(BUILTIN_LEVEL_IDS),
+      },
+    },
+  },
+  primaryDisplay: "username",
+}
+
 exports.AuthTypes = AuthTypes
+exports.USERS_TABLE_SCHEMA = USERS_TABLE_SCHEMA