Fixes based on test failures.

packages/server/src/api/controllers/application.ts

@@ -466,8 +466,9 @@ async function destroyApp(ctx: BBContext) {
 
   if (isUnpublish) {
     appId = dbCore.getProdAppID(appId)
+    const devAppId = dbCore.getDevAppID(appId)
     // sync before removing the published app
-    await sdk.applications.syncApp(appId)
+    await sdk.applications.syncApp(devAppId)
   }
 
   const db = isUnpublish ? context.getProdAppDB() : context.getAppDB()

packages/server/src/api/routes/tests/application.spec.js

@@ -17,7 +17,6 @@ const {
   checkBuilderEndpoint,
 } = require("./utilities/TestFunctions")
 const setup = require("./utilities")
-const { basicScreen, basicLayout } = setup.structures
 const { AppStatus } = require("../../../db/utils")
 const { events } = require("@budibase/backend-core")
 

packages/server/src/sdk/app/applications/sync.ts

@@ -10,7 +10,7 @@ export async function syncApp(appId: string) {
     }
   }
 
-  if (!dbCore.isDevAppID(appId)) {
+  if (dbCore.isProdAppID(appId)) {
     throw new Error("This action cannot be performed for production apps")
   }