CodeMirror/budibase
1
0
Fork 0
mirror of synced 2024-10-02 10:08:09 +13:00
Code Issues Projects Releases Wiki Activity

canDelete methods for index and record

Browse source
This commit is contained in:
Michael Shanks 2020-03-25 11:11:28 +00:00
parent f44deca6af
commit c5ec3cfb13
2 changed files with 30 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/core/src/templateApi/canDeleteRecord.js
View file

@ -20,8 +20,7 @@ export const canDeleteRecord = recordNode => {
])
const belongsToAncestor = i =>
ancestors.includes(i.parent())
ancestors.includes(i.parent())
const errorsForNode = node => {
const errorsThisNode = $(flatHierarchy, [
@ -40,5 +39,7 @@ export const canDeleteRecord = recordNode => {
return errorsThisNode
}
return errorsForNode(recordNode)
const errors = errorsForNode(recordNode)
return { errors, canDelete: errors.length === 0 }
}

29
packages/core/test/templateApi.canDelete.spec.js
View file

@ -2,6 +2,7 @@ import {
setupApphierarchy,
basicAppHierarchyCreator_WithFields,
stubEventHandler,
basicAppHierarchyCreator_WithFields_AndIndexes,
} from "./specHelpers"
import { canDeleteIndex } from "../src/templateApi/canDeleteIndex"
import { canDeleteRecord } from "../src/templateApi/canDeleteRecord"
@ -49,15 +50,37 @@ describe("canDeleteIndex", () => {
describe("canDeleteRecord", () => {
it("should return no errors when deletion is valid", () => {
it("should return no errors when deletion is valid", async () => {
const { appHierarchy } = await setupApphierarchy(
basicAppHierarchyCreator_WithFields
)
appHierarchy.root.
const result = canDeleteIndex(appHierarchy.customerRecord)
appHierarchy.root.indexes = appHierarchy.root.indexes.filter(i => !i.allowedRecordNodeIds.includes(appHierarchy.customerRecord.nodeId))
const result = canDeleteRecord(appHierarchy.customerRecord)
expect(result.canDelete).toBe(true)
expect(result.errors).toEqual([])
})
it("should return errors when record is referenced by hierarchal index", async () => {
const { appHierarchy } = await setupApphierarchy(
basicAppHierarchyCreator_WithFields
)
const result = canDeleteRecord(appHierarchy.customerRecord)
expect(result.canDelete).toBe(false)
expect(result.errors.some(e => e.includes("customer_index"))).toBe(true)
})
it("should return errors when record has a child which cannot be deleted", async () => {
const { appHierarchy } = await setupApphierarchy(
basicAppHierarchyCreator_WithFields_AndIndexes
)
const result = canDeleteRecord(appHierarchy.customerRecord)
expect(result.canDelete).toBe(false)
expect(result.errors.some(e => e.includes("Outstanding Invoices"))).toBe(true)
})
})