From c32163a9be9dae2b2f050dae88cccf8a3e479446 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Thu, 21 Mar 2024 18:26:35 +0000 Subject: [PATCH 1/9] Initial fix for defaulting parameters, switch to null rather than strings, this is important for prepared statements/SQL queries. --- .../server/src/api/controllers/query/index.ts | 55 +++++++++++-------- packages/server/src/threads/definitions.ts | 13 ++--- packages/types/src/documents/app/query.ts | 2 + 3 files changed, 40 insertions(+), 30 deletions(-) diff --git a/packages/server/src/api/controllers/query/index.ts b/packages/server/src/api/controllers/query/index.ts index 0dba20dacd..b05b4b1222 100644 --- a/packages/server/src/api/controllers/query/index.ts +++ b/packages/server/src/api/controllers/query/index.ts @@ -6,7 +6,7 @@ import { invalidateDynamicVariables } from "../../../threads/utils" import env from "../../../environment" import { events, context, utils, constants } from "@budibase/backend-core" import sdk from "../../../sdk" -import { QueryEvent } from "../../../threads/definitions" +import { QueryEvent, QueryEventParameters } from "../../../threads/definitions" import { ConfigType, Query, @@ -18,7 +18,6 @@ import { FieldType, ExecuteQueryRequest, ExecuteQueryResponse, - QueryParameter, PreviewQueryRequest, PreviewQueryResponse, } from "@budibase/types" @@ -29,7 +28,7 @@ const Runner = new Thread(ThreadType.QUERY, { timeoutMs: env.QUERY_THREAD_TIMEOUT, }) -function validateQueryInputs(parameters: Record) { +function validateQueryInputs(parameters: QueryEventParameters) { for (let entry of Object.entries(parameters)) { const [key, value] = entry if (typeof value !== "string") { @@ -100,8 +99,10 @@ export async function save(ctx: UserCtx) { const datasource = await sdk.datasources.get(query.datasourceId) let eventFn - if (!query._id) { + if (!query._id && !query._rev) { query._id = generateQueryID(query.datasourceId) + // flag to state whether the default bindings are empty strings (old behaviour) or null + query.nullDefaultSupport = true eventFn = () => events.query.created(datasource, query) } else { eventFn = () => events.query.updated(datasource, query) @@ -135,16 +136,22 @@ function getAuthConfig(ctx: UserCtx) { } function enrichParameters( - queryParameters: QueryParameter[], - requestParameters: Record = {} -): Record { + query: Query, + requestParameters: QueryEventParameters = {} +): QueryEventParameters { + const paramNotSet = (val: unknown) => val === "" || val == undefined // first check parameters are all valid validateQueryInputs(requestParameters) // make sure parameters are fully enriched with defaults - for (let parameter of queryParameters) { - if (!requestParameters[parameter.name]) { - requestParameters[parameter.name] = parameter.default + for (let parameter of query.parameters) { + let value: string | null = requestParameters[parameter.name] + if (!value) { + value = parameter.default } + if (query.nullDefaultSupport && paramNotSet(value)) { + value = null + } + requestParameters[parameter.name] = value } return requestParameters } @@ -157,10 +164,15 @@ export async function preview( ) // preview may not have a queryId as it hasn't been saved, but if it does // this stops dynamic variables from calling the same query - const { fields, parameters, queryVerb, transformer, queryId, schema } = - ctx.request.body + const queryId = ctx.request.body.queryId + // the body contains the makings of a query, which has not been saved yet + const query: Query = ctx.request.body + // hasn't been saved, new query + if (!queryId && !query._id) { + query.nullDefaultSupport = true + } - let existingSchema = schema + let existingSchema = query.schema if (queryId && !existingSchema) { try { const db = context.getAppDB() @@ -268,13 +280,13 @@ export async function preview( try { const inputs: QueryEvent = { appId: ctx.appId, - datasource, - queryVerb, - fields, - parameters: enrichParameters(parameters), - transformer, + queryVerb: query.queryVerb, + fields: query.fields, + parameters: enrichParameters(query), + transformer: query.transformer, + schema: query.schema, queryId, - schema, + datasource, // have to pass down to the thread runner - can't put into context now environmentVariables: envVars, ctx: { @@ -336,10 +348,7 @@ async function execute( queryVerb: query.queryVerb, fields: query.fields, pagination: ctx.request.body.pagination, - parameters: enrichParameters( - query.parameters, - ctx.request.body.parameters - ), + parameters: enrichParameters(query, ctx.request.body.parameters), transformer: query.transformer, queryId: ctx.params.queryId, // have to pass down to the thread runner - can't put into context now diff --git a/packages/server/src/threads/definitions.ts b/packages/server/src/threads/definitions.ts index 14b97c57b1..85e546280d 100644 --- a/packages/server/src/threads/definitions.ts +++ b/packages/server/src/threads/definitions.ts @@ -1,21 +1,20 @@ -import { Datasource, QuerySchema, Row } from "@budibase/types" +import { Datasource, Row, Query } from "@budibase/types" export type WorkerCallback = (error: any, response?: any) => void -export interface QueryEvent { +export interface QueryEvent + extends Omit { appId?: string datasource: Datasource - queryVerb: string - fields: { [key: string]: any } - parameters: { [key: string]: unknown } pagination?: any - transformer: any queryId?: string environmentVariables?: Record + parameters: QueryEventParameters ctx?: any - schema?: Record } +export type QueryEventParameters = Record + export interface QueryResponse { rows: Row[] keys: string[] diff --git a/packages/types/src/documents/app/query.ts b/packages/types/src/documents/app/query.ts index 535c5dab3b..baba4def95 100644 --- a/packages/types/src/documents/app/query.ts +++ b/packages/types/src/documents/app/query.ts @@ -15,6 +15,8 @@ export interface Query extends Document { schema: Record readable: boolean queryVerb: string + // flag to state whether the default bindings are empty strings (old behaviour) or null + nullDefaultSupport?: boolean } export interface QueryPreview extends Omit { From f4f7ac42ec164af87044e745229c79134a5c4f6a Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Fri, 22 Mar 2024 11:40:44 +0000 Subject: [PATCH 2/9] Adding test cases for interpolation of SQL, confirming that the context correctly gets cleaned up before passing into bindings. --- .../server/src/api/controllers/query/index.ts | 8 ++ .../routes/tests/queries/generic-sql.spec.ts | 85 +++++++++++++++++-- .../api/routes/tests/queries/mongodb.spec.ts | 2 +- .../server/src/integrations/queries/sql.ts | 15 +++- .../server/src/sdk/app/queries/queries.ts | 18 +++- .../server/src/tests/utilities/api/query.ts | 2 +- packages/server/src/threads/query.ts | 29 +++++-- 7 files changed, 137 insertions(+), 22 deletions(-) diff --git a/packages/server/src/api/controllers/query/index.ts b/packages/server/src/api/controllers/query/index.ts index b05b4b1222..03fcdb714a 100644 --- a/packages/server/src/api/controllers/query/index.ts +++ b/packages/server/src/api/controllers/query/index.ts @@ -105,6 +105,12 @@ export async function save(ctx: UserCtx) { query.nullDefaultSupport = true eventFn = () => events.query.created(datasource, query) } else { + // check if flag has previously been set, don't let it change + // allow it to be explicitly set to false via API incase this is ever needed + const existingQuery = await db.get(query._id) + if (existingQuery.nullDefaultSupport && query.nullDefaultSupport == null) { + query.nullDefaultSupport = true + } eventFn = () => events.query.updated(datasource, query) } const response = await db.put(query) @@ -285,6 +291,7 @@ export async function preview( parameters: enrichParameters(query), transformer: query.transformer, schema: query.schema, + nullDefaultSupport: query.nullDefaultSupport, queryId, datasource, // have to pass down to the thread runner - can't put into context now @@ -353,6 +360,7 @@ async function execute( queryId: ctx.params.queryId, // have to pass down to the thread runner - can't put into context now environmentVariables: envVars, + nullDefaultSupport: query.nullDefaultSupport, ctx: { user: ctx.user, auth: { ...authConfigCtx }, diff --git a/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts b/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts index 1fc0ecb382..ac90efa71c 100644 --- a/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts +++ b/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts @@ -12,31 +12,51 @@ const createTableSQL: Record = { CREATE TABLE test_table ( id serial PRIMARY KEY, name VARCHAR ( 50 ) NOT NULL, - birthday TIMESTAMP + birthday TIMESTAMP, + number INT );`, [SourceName.MYSQL]: ` CREATE TABLE test_table ( id INT AUTO_INCREMENT PRIMARY KEY, name VARCHAR(50) NOT NULL, - birthday TIMESTAMP + birthday TIMESTAMP, + number INT );`, [SourceName.SQL_SERVER]: ` CREATE TABLE test_table ( id INT IDENTITY(1,1) PRIMARY KEY, name NVARCHAR(50) NOT NULL, - birthday DATETIME + birthday DATETIME, + number INT );`, } const insertSQL = `INSERT INTO test_table (name) VALUES ('one'), ('two'), ('three'), ('four'), ('five')` const dropTableSQL = `DROP TABLE test_table;` +const POSTGRES_SPECIFICS = { + nullError: 'invalid input syntax for type integer: ""', +} + +const MYSQL_SPECIFICS = { + nullError: "Incorrect integer value: '' for column 'number' at row 1", +} + +const MSSQL_SPECIFICS = { + nullError: "Cannot convert undefined or null to object", +} + +const MARIADB_SPECIFICS = { + nullError: + "Incorrect integer value: '' for column `mysql`.`test_table`.`number` at row 1", +} + describe.each([ - ["postgres", databaseTestProviders.postgres], - ["mysql", databaseTestProviders.mysql], - ["mssql", databaseTestProviders.mssql], - ["mariadb", databaseTestProviders.mariadb], -])("queries (%s)", (__, dsProvider) => { + ["postgres", databaseTestProviders.postgres, POSTGRES_SPECIFICS], + ["mysql", databaseTestProviders.mysql, MYSQL_SPECIFICS], + ["mssql", databaseTestProviders.mssql, MSSQL_SPECIFICS], + ["mariadb", databaseTestProviders.mariadb, MARIADB_SPECIFICS], +])("queries (%s)", (__, dsProvider, testSpecificInformation) => { const config = setup.getConfig() let datasource: Datasource @@ -51,7 +71,7 @@ describe.each([ transformer: "return data", readable: true, } - return await config.api.query.create({ ...defaultQuery, ...query }) + return await config.api.query.save({ ...defaultQuery, ...query }) } async function rawQuery(sql: string): Promise { @@ -398,4 +418,51 @@ describe.each([ expect(rows).toHaveLength(0) }) }) + + // this parameter really only impacts SQL queries + describe("confirm nullDefaultSupport", () => { + const queryParams = { + fields: { + sql: "INSERT INTO test_table (name, number) VALUES ({{ bindingName }}, {{ bindingNumber }})", + }, + parameters: [ + { + name: "bindingName", + default: "", + }, + { + name: "bindingNumber", + default: "", + }, + ], + queryVerb: "create", + } + + it("should error for old queries", async () => { + const query = await createQuery(queryParams) + await config.api.query.save({ ...query, nullDefaultSupport: false }) + let error: string | undefined + try { + await config.api.query.execute(query._id!, { + parameters: { + bindingName: "testing", + }, + }) + } catch (err: any) { + error = err.message + } + expect(error).toBeDefined() + expect(error).toContain(testSpecificInformation.nullError) + }) + + it("should not error for new queries", async () => { + const query = await createQuery(queryParams) + const results = await config.api.query.execute(query._id!, { + parameters: { + bindingName: "testing", + }, + }) + expect(results).toEqual({ data: [{ created: true }] }) + }) + }) }) diff --git a/packages/server/src/api/routes/tests/queries/mongodb.spec.ts b/packages/server/src/api/routes/tests/queries/mongodb.spec.ts index b61f905bef..3280c37e78 100644 --- a/packages/server/src/api/routes/tests/queries/mongodb.spec.ts +++ b/packages/server/src/api/routes/tests/queries/mongodb.spec.ts @@ -33,7 +33,7 @@ describe("/queries", () => { ) { combinedQuery.fields.extra.collection = collection } - return await config.api.query.create(combinedQuery) + return await config.api.query.save(combinedQuery) } async function withClient( diff --git a/packages/server/src/integrations/queries/sql.ts b/packages/server/src/integrations/queries/sql.ts index 6d42117d7d..fd1363c39a 100644 --- a/packages/server/src/integrations/queries/sql.ts +++ b/packages/server/src/integrations/queries/sql.ts @@ -1,13 +1,15 @@ import { findHBSBlocks } from "@budibase/string-templates" import { DatasourcePlus } from "@budibase/types" import sdk from "../../sdk" +import { enrichArrayContext } from "../../sdk/app/queries/queries" const CONST_CHAR_REGEX = new RegExp("'[^']*'", "g") export async function interpolateSQL( - fields: { [key: string]: any }, + fields: { sql: string; bindings: any[] }, parameters: { [key: string]: any }, - integration: DatasourcePlus + integration: DatasourcePlus, + opts: { nullDefaultSupport: boolean } ) { let sql = fields.sql if (!sql || typeof sql !== "string") { @@ -64,7 +66,14 @@ export async function interpolateSQL( } // replicate the knex structure fields.sql = sql - fields.bindings = await sdk.queries.enrichContext(variables, parameters) + fields.bindings = await sdk.queries.enrichArrayContext(variables, parameters) + if (opts.nullDefaultSupport) { + for (let index in fields.bindings) { + if (fields.bindings[index] === "") { + fields.bindings[index] = null + } + } + } // check for arrays in the data let updated: string[] = [] for (let i = 0; i < variables.length; i++) { diff --git a/packages/server/src/sdk/app/queries/queries.ts b/packages/server/src/sdk/app/queries/queries.ts index 3f967b7198..cf0ed4ec95 100644 --- a/packages/server/src/sdk/app/queries/queries.ts +++ b/packages/server/src/sdk/app/queries/queries.ts @@ -65,11 +65,27 @@ export async function fetch(opts: { enrich: boolean } = { enrich: true }) { return updateSchemas(queries) } +export async function enrichArrayContext( + fields: any[], + inputs = {} +): Promise { + const map: Record = {} + for (let [key, value] of Object.entries(fields)) { + map[key] = value + } + const output = await enrichContext(map, inputs) + const outputArray: any[] = [] + for (let [key, value] of Object.entries(output)) { + outputArray[parseInt(key)] = value + } + return outputArray +} + export async function enrichContext( fields: Record, inputs = {} ): Promise> { - const enrichedQuery: Record = Array.isArray(fields) ? [] : {} + const enrichedQuery: Record = {} if (!fields || !inputs) { return enrichedQuery } diff --git a/packages/server/src/tests/utilities/api/query.ts b/packages/server/src/tests/utilities/api/query.ts index 32866314ff..0dad6d2ad9 100644 --- a/packages/server/src/tests/utilities/api/query.ts +++ b/packages/server/src/tests/utilities/api/query.ts @@ -8,7 +8,7 @@ import { import { TestAPI } from "./base" export class QueryAPI extends TestAPI { - create = async (body: Query): Promise => { + save = async (body: Query): Promise => { return await this._post(`/api/queries`, { body }) } diff --git a/packages/server/src/threads/query.ts b/packages/server/src/threads/query.ts index 9f5e02bf69..dbac76c09a 100644 --- a/packages/server/src/threads/query.ts +++ b/packages/server/src/threads/query.ts @@ -26,10 +26,11 @@ class QueryRunner { fields: any parameters: any pagination: any - transformer: string + transformer: string | null cachedVariables: any[] ctx: any queryResponse: any + nullDefaultSupport: boolean noRecursiveQuery: boolean hasRerun: boolean hasRefreshedOAuth: boolean @@ -45,6 +46,7 @@ class QueryRunner { this.transformer = input.transformer this.queryId = input.queryId! this.schema = input.schema + this.nullDefaultSupport = !!input.nullDefaultSupport this.noRecursiveQuery = flags.noRecursiveQuery this.cachedVariables = [] // Additional context items for enrichment @@ -59,7 +61,14 @@ class QueryRunner { } async execute(): Promise { - let { datasource, fields, queryVerb, transformer, schema } = this + let { + datasource, + fields, + queryVerb, + transformer, + schema, + nullDefaultSupport, + } = this let datasourceClone = cloneDeep(datasource) let fieldsClone = cloneDeep(fields) @@ -103,7 +112,9 @@ class QueryRunner { let query // handle SQL injections by interpolating the variables if (isSQL(datasourceClone)) { - query = await interpolateSQL(fieldsClone, enrichedContext, integration) + query = await interpolateSQL(fieldsClone, enrichedContext, integration, { + nullDefaultSupport, + }) } else { query = await sdk.queries.enrichContext(fieldsClone, enrichedContext) } @@ -137,7 +148,9 @@ class QueryRunner { data: rows, params: enrichedParameters, } - rows = vm.withContext(ctx, () => vm.execute(transformer)) + if (transformer != null) { + rows = vm.withContext(ctx, () => vm.execute(transformer!)) + } } // if the request fails we retry once, invalidating the cached value @@ -191,13 +204,15 @@ class QueryRunner { }) return new QueryRunner( { - datasource, + schema: query.schema, queryVerb: query.queryVerb, fields: query.fields, - parameters, transformer: query.transformer, - queryId, + nullDefaultSupport: query.nullDefaultSupport, ctx: this.ctx, + parameters, + datasource, + queryId, }, { noRecursiveQuery: true } ).execute() From 3f225c94e745d60669bd22a5c31209d23a3af2fc Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Fri, 22 Mar 2024 11:50:07 +0000 Subject: [PATCH 3/9] Linting. --- packages/server/src/integrations/queries/sql.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/server/src/integrations/queries/sql.ts b/packages/server/src/integrations/queries/sql.ts index fd1363c39a..f6b0d68e7f 100644 --- a/packages/server/src/integrations/queries/sql.ts +++ b/packages/server/src/integrations/queries/sql.ts @@ -1,7 +1,6 @@ import { findHBSBlocks } from "@budibase/string-templates" import { DatasourcePlus } from "@budibase/types" import sdk from "../../sdk" -import { enrichArrayContext } from "../../sdk/app/queries/queries" const CONST_CHAR_REGEX = new RegExp("'[^']*'", "g") From 5b1db961291efe91eb233fae2fbe2a434ca8ee86 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Fri, 22 Mar 2024 12:05:55 +0000 Subject: [PATCH 4/9] Fixing typing issue. --- packages/server/src/threads/query.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/server/src/threads/query.ts b/packages/server/src/threads/query.ts index dbac76c09a..97e7a05cf7 100644 --- a/packages/server/src/threads/query.ts +++ b/packages/server/src/threads/query.ts @@ -109,7 +109,7 @@ class QueryRunner { ) } - let query + let query: Record // handle SQL injections by interpolating the variables if (isSQL(datasourceClone)) { query = await interpolateSQL(fieldsClone, enrichedContext, integration, { From 2464020a225e70d8d64e4bd99f613f33162422f2 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Fri, 22 Mar 2024 12:36:00 +0000 Subject: [PATCH 5/9] Test fixes after running in CI. --- .../routes/tests/queries/generic-sql.spec.ts | 23 +++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts b/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts index ac90efa71c..97e513af01 100644 --- a/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts +++ b/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts @@ -43,7 +43,8 @@ const MYSQL_SPECIFICS = { } const MSSQL_SPECIFICS = { - nullError: "Cannot convert undefined or null to object", + // MS-SQL doesn't throw an error here, it casts empty string to nothing + nullError: undefined, } const MARIADB_SPECIFICS = { @@ -241,26 +242,31 @@ describe.each([ id: 1, name: "one", birthday: null, + number: null, }, { id: 2, name: "two", birthday: null, + number: null, }, { id: 3, name: "three", birthday: null, + number: null, }, { id: 4, name: "four", birthday: null, + number: null, }, { id: 5, name: "five", birthday: null, + number: null, }, ]) }) @@ -283,6 +289,7 @@ describe.each([ id: 2, name: "one", birthday: null, + number: null, }, ]) }) @@ -311,6 +318,7 @@ describe.each([ id: 1, name: "one", birthday: null, + number: null, }, ]) }) @@ -349,7 +357,9 @@ describe.each([ ]) const rows = await rawQuery("SELECT * FROM test_table WHERE id = 1") - expect(rows).toEqual([{ id: 1, name: "foo", birthday: null }]) + expect(rows).toEqual([ + { id: 1, name: "foo", birthday: null, number: null }, + ]) }) it("should be able to execute an update that updates no rows", async () => { @@ -451,8 +461,13 @@ describe.each([ } catch (err: any) { error = err.message } - expect(error).toBeDefined() - expect(error).toContain(testSpecificInformation.nullError) + const testExpectation = testSpecificInformation.nullError + if (testExpectation) { + expect(error).toBeDefined() + expect(error).toContain(testExpectation) + } else { + expect(error).toBeUndefined() + } }) it("should not error for new queries", async () => { From 185e9c3425fe758a0d815a87b58adc2e1e22fd71 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Fri, 22 Mar 2024 13:01:51 +0000 Subject: [PATCH 6/9] Fixing test case. --- .../server/src/api/routes/tests/environmentVariables.spec.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/server/src/api/routes/tests/environmentVariables.spec.ts b/packages/server/src/api/routes/tests/environmentVariables.spec.ts index 9104dedf4f..beb6012c9c 100644 --- a/packages/server/src/api/routes/tests/environmentVariables.spec.ts +++ b/packages/server/src/api/routes/tests/environmentVariables.spec.ts @@ -143,7 +143,10 @@ describe("/api/env/variables", () => { delete response.body.datasource.config expect(events.query.previewed).toHaveBeenCalledWith( response.body.datasource, - queryPreview + { + ...queryPreview, + nullDefaultSupport: true, + } ) expect(pg.Client).toHaveBeenCalledWith({ password: "test", ssl: undefined }) }) From defb925d16d1e182fba48e618ce170d7230ae8e0 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Fri, 22 Mar 2024 13:38:52 +0000 Subject: [PATCH 7/9] Query seq fix. --- .../src/api/routes/tests/queries/query.seq.spec.ts | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/server/src/api/routes/tests/queries/query.seq.spec.ts b/packages/server/src/api/routes/tests/queries/query.seq.spec.ts index 10b90eafb1..4c25a762b8 100644 --- a/packages/server/src/api/routes/tests/queries/query.seq.spec.ts +++ b/packages/server/src/api/routes/tests/queries/query.seq.spec.ts @@ -78,6 +78,7 @@ describe("/queries", () => { _rev: res.body._rev, _id: res.body._id, ...query, + nullDefaultSupport: true, createdAt: new Date().toISOString(), updatedAt: new Date().toISOString(), }) @@ -103,6 +104,7 @@ describe("/queries", () => { _rev: res.body._rev, _id: res.body._id, ...query, + nullDefaultSupport: true, createdAt: new Date().toISOString(), updatedAt: new Date().toISOString(), }) @@ -130,6 +132,7 @@ describe("/queries", () => { _id: query._id, createdAt: new Date().toISOString(), ...basicQuery(datasource._id), + nullDefaultSupport: true, updatedAt: new Date().toISOString(), readable: true, }, @@ -245,10 +248,10 @@ describe("/queries", () => { expect(responseBody.rows.length).toEqual(1) expect(events.query.previewed).toHaveBeenCalledTimes(1) delete datasource.config - expect(events.query.previewed).toHaveBeenCalledWith( - datasource, - queryPreview - ) + expect(events.query.previewed).toHaveBeenCalledWith(datasource, { + ...queryPreview, + nullDefaultSupport: true, + }) }) it("should apply authorization to endpoint", async () => { From cc8a0274a4e1801f008e740f694cf3c96e1e8888 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Fri, 22 Mar 2024 15:26:02 +0000 Subject: [PATCH 8/9] Updating based on PR comments. --- .../server/src/api/controllers/query/index.ts | 8 ++-- .../routes/tests/queries/generic-sql.spec.ts | 37 +++++-------------- .../server/src/sdk/app/queries/queries.ts | 4 +- 3 files changed, 14 insertions(+), 35 deletions(-) diff --git a/packages/server/src/api/controllers/query/index.ts b/packages/server/src/api/controllers/query/index.ts index 03fcdb714a..055f3bd888 100644 --- a/packages/server/src/api/controllers/query/index.ts +++ b/packages/server/src/api/controllers/query/index.ts @@ -149,11 +149,9 @@ function enrichParameters( // first check parameters are all valid validateQueryInputs(requestParameters) // make sure parameters are fully enriched with defaults - for (let parameter of query.parameters) { - let value: string | null = requestParameters[parameter.name] - if (!value) { - value = parameter.default - } + for (const parameter of query.parameters) { + let value: string | null = + requestParameters[parameter.name] || parameter.default if (query.nullDefaultSupport && paramNotSet(value)) { value = null } diff --git a/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts b/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts index 97e513af01..f9a3ac6e03 100644 --- a/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts +++ b/packages/server/src/api/routes/tests/queries/generic-sql.spec.ts @@ -34,30 +34,12 @@ const createTableSQL: Record = { const insertSQL = `INSERT INTO test_table (name) VALUES ('one'), ('two'), ('three'), ('four'), ('five')` const dropTableSQL = `DROP TABLE test_table;` -const POSTGRES_SPECIFICS = { - nullError: 'invalid input syntax for type integer: ""', -} - -const MYSQL_SPECIFICS = { - nullError: "Incorrect integer value: '' for column 'number' at row 1", -} - -const MSSQL_SPECIFICS = { - // MS-SQL doesn't throw an error here, it casts empty string to nothing - nullError: undefined, -} - -const MARIADB_SPECIFICS = { - nullError: - "Incorrect integer value: '' for column `mysql`.`test_table`.`number` at row 1", -} - describe.each([ - ["postgres", databaseTestProviders.postgres, POSTGRES_SPECIFICS], - ["mysql", databaseTestProviders.mysql, MYSQL_SPECIFICS], - ["mssql", databaseTestProviders.mssql, MSSQL_SPECIFICS], - ["mariadb", databaseTestProviders.mariadb, MARIADB_SPECIFICS], -])("queries (%s)", (__, dsProvider, testSpecificInformation) => { + ["postgres", databaseTestProviders.postgres], + ["mysql", databaseTestProviders.mysql], + ["mssql", databaseTestProviders.mssql], + ["mariadb", databaseTestProviders.mariadb], +])("queries (%s)", (dbName, dsProvider) => { const config = setup.getConfig() let datasource: Datasource @@ -461,12 +443,11 @@ describe.each([ } catch (err: any) { error = err.message } - const testExpectation = testSpecificInformation.nullError - if (testExpectation) { - expect(error).toBeDefined() - expect(error).toContain(testExpectation) - } else { + if (dbName === "mssql") { expect(error).toBeUndefined() + } else { + expect(error).toBeDefined() + expect(error).toContain("integer") } }) diff --git a/packages/server/src/sdk/app/queries/queries.ts b/packages/server/src/sdk/app/queries/queries.ts index cf0ed4ec95..511d2233c2 100644 --- a/packages/server/src/sdk/app/queries/queries.ts +++ b/packages/server/src/sdk/app/queries/queries.ts @@ -70,8 +70,8 @@ export async function enrichArrayContext( inputs = {} ): Promise { const map: Record = {} - for (let [key, value] of Object.entries(fields)) { - map[key] = value + for (let index in fields) { + map[index] = fields[index] } const output = await enrichContext(map, inputs) const outputArray: any[] = [] From 6824d8626af2619af6737a83cc2df2046238056b Mon Sep 17 00:00:00 2001 From: Michael Drury Date: Mon, 25 Mar 2024 11:19:31 +0000 Subject: [PATCH 9/9] Fixing failing test. --- packages/server/src/api/routes/tests/queries/mongodb.spec.ts | 2 +- packages/server/src/sdk/app/queries/queries.ts | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/server/src/api/routes/tests/queries/mongodb.spec.ts b/packages/server/src/api/routes/tests/queries/mongodb.spec.ts index bbbb9362fd..492f24abf9 100644 --- a/packages/server/src/api/routes/tests/queries/mongodb.spec.ts +++ b/packages/server/src/api/routes/tests/queries/mongodb.spec.ts @@ -464,7 +464,7 @@ describe("/queries", () => { }) }) - it("should ignore be able to save deeply nested data", async () => { + it("should be able to save deeply nested data", async () => { const data = { foo: "bar", data: [ diff --git a/packages/server/src/sdk/app/queries/queries.ts b/packages/server/src/sdk/app/queries/queries.ts index 511d2233c2..d37e53bec1 100644 --- a/packages/server/src/sdk/app/queries/queries.ts +++ b/packages/server/src/sdk/app/queries/queries.ts @@ -89,6 +89,9 @@ export async function enrichContext( if (!fields || !inputs) { return enrichedQuery } + if (Array.isArray(fields)) { + return enrichArrayContext(fields, inputs) + } const env = await getEnvironmentVariables() const parameters = { ...inputs, env } // enrich the fields with dynamic parameters