From db7f267887eefb8c490be9cfae78289396a57159 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Wed, 8 Mar 2023 19:22:19 +0000 Subject: [PATCH 1/4] Update component settings to be left aligned and update long component settings labels to be shorter --- packages/bbui/src/Drawer/Drawer.svelte | 2 +- .../src/components/design/Panel.svelte | 14 +-- .../settings/controls/PropertyControl.svelte | 31 +++--- .../settings/ComponentSettingsPanel.svelte | 2 +- .../new/_components/NewComponentPanel.svelte | 104 ++++++------------ packages/client/manifest.json | 38 +++---- 6 files changed, 71 insertions(+), 120 deletions(-) diff --git a/packages/bbui/src/Drawer/Drawer.svelte b/packages/bbui/src/Drawer/Drawer.svelte index 43729cd794..932236bc0c 100644 --- a/packages/bbui/src/Drawer/Drawer.svelte +++ b/packages/bbui/src/Drawer/Drawer.svelte @@ -7,7 +7,7 @@ export let title export let fillWidth export let left = "314px" - export let width = "calc(100% - 576px)" + export let width = "calc(100% - 626px)" let visible = false diff --git a/packages/builder/src/components/design/Panel.svelte b/packages/builder/src/components/design/Panel.svelte index 6c8753a99e..dbf42c51a5 100644 --- a/packages/builder/src/components/design/Panel.svelte +++ b/packages/builder/src/components/design/Panel.svelte @@ -3,7 +3,6 @@ export let title export let icon - export let expandable = false export let showAddButton = false export let showBackButton = false export let showCloseButton = false @@ -12,8 +11,8 @@ export let onClickCloseButton export let borderLeft = false export let borderRight = false + export let wide = false - let wide = false $: customHeaderContent = $$slots["panel-header-content"] @@ -28,13 +27,6 @@
{title || ""}
- {#if expandable} - (wide = !wide)} - /> - {/if} {#if showAddButton}
@@ -74,8 +66,8 @@ border-right: var(--border-light); } .panel.wide { - width: 420px; - flex: 0 0 420px; + width: 310px; + flex: 0 0 310px; } .header { flex: 0 0 48px; diff --git a/packages/builder/src/components/design/settings/controls/PropertyControl.svelte b/packages/builder/src/components/design/settings/controls/PropertyControl.svelte index ab448b850c..e021cc4288 100644 --- a/packages/builder/src/components/design/settings/controls/PropertyControl.svelte +++ b/packages/builder/src/components/design/settings/controls/PropertyControl.svelte @@ -75,12 +75,10 @@
- {#if type !== "boolean" && label} -
- -
+ {#if label} + {/if} -
+
.property-control { position: relative; - display: flex; - flex-direction: column; - justify-content: flex-start; - align-items: stretch; + display: grid; + grid-template-columns: 90px 1fr; + align-items: center; transition: background 130ms ease-out, border-color 130ms ease-out; border-left: 4px solid transparent; margin: -6px calc(-1 * var(--spacing-xl)); - padding: 6px var(--spacing-xl) 6px calc(var(--spacing-xl) - 4px); + padding: 2px var(--spacing-xl) 6px calc(var(--spacing-xl) - 4px); + gap: 8px; + } + .property-control :global(.spectrum-FieldLabel) { + white-space: normal; } .property-control.highlighted { background: var(--spectrum-global-color-gray-300); border-color: var(--spectrum-global-color-blue-400); } - .label { - padding-bottom: var(--spectrum-global-dimension-size-65); - } .control { position: relative; } + .control.wide { + grid-column: 1 / -1; + } .text { - margin-top: var(--spectrum-global-dimension-size-65); + margin-top: 4px; font-size: var(--spectrum-global-dimension-font-size-75); color: var(--grey-6); + grid-column: 1 / -1; } diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/ComponentSettingsPanel.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/ComponentSettingsPanel.svelte index 1e889ffe93..2ff605cc77 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/ComponentSettingsPanel.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/ComponentSettingsPanel.svelte @@ -37,7 +37,7 @@ {#if $selectedComponent} {#key $selectedComponent._id} - +
{#each tabs as tab} diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/new/_components/NewComponentPanel.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/new/_components/NewComponentPanel.svelte index 033881c0ac..5246b26bc7 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/new/_components/NewComponentPanel.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/new/_components/NewComponentPanel.svelte @@ -1,22 +1,13 @@ -
+
{#if label} {/if} -
+
diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/ComponentSettingsSection.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/ComponentSettingsSection.svelte index 21bed847f5..c21094c7f2 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/ComponentSettingsSection.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/ComponentSettingsSection.svelte @@ -117,49 +117,51 @@ {#each sections as section, idx (section.name)} {#if section.visible} - {#if idx === 0 && !componentInstance._component.endsWith("/layout") && !isScreen} - updateSetting({ key: "_instanceName" }, val)} - /> - {/if} - {#each section.settings as setting (setting.key)} - {#if setting.visible} +
+ {#if idx === 0 && !componentInstance._component.endsWith("/layout") && !isScreen} updateSetting(setting, val)} - highlighted={$store.highlightedSettingKey === setting.key} - info={setting.info} - props={{ - // Generic settings - placeholder: setting.placeholder || null, - - // Select settings - options: setting.options || [], - - // Number fields - min: setting.min ?? null, - max: setting.max ?? null, - }} - {bindings} - {componentBindings} - {componentInstance} - {componentDefinition} + control={Input} + label="Name" + key="_instanceName" + value={componentInstance._instanceName} + onChange={val => updateSetting({ key: "_instanceName" }, val)} /> {/if} - {/each} - {#if idx === 0 && componentDefinition?.component?.endsWith("/fieldgroup")} - - {/if} + {#each section.settings as setting (setting.key)} + {#if setting.visible} + updateSetting(setting, val)} + highlighted={$store.highlightedSettingKey === setting.key} + info={setting.info} + props={{ + // Generic settings + placeholder: setting.placeholder || null, + + // Select settings + options: setting.options || [], + + // Number fields + min: setting.min ?? null, + max: setting.max ?? null, + }} + {bindings} + {componentBindings} + {componentInstance} + {componentDefinition} + /> + {/if} + {/each} + {#if idx === 0 && componentDefinition?.component?.endsWith("/fieldgroup")} + + {/if} +
{/if} {/each} @@ -168,3 +170,13 @@ {/if} + + diff --git a/packages/client/manifest.json b/packages/client/manifest.json index 6bd03f702f..e37135dbf9 100644 --- a/packages/client/manifest.json +++ b/packages/client/manifest.json @@ -121,7 +121,7 @@ }, { "type": "select", - "label": "Horiz. Align", + "label": "Horiz. align", "key": "hAlign", "showInBar": true, "barStyle": "buttons", @@ -155,7 +155,7 @@ }, { "type": "select", - "label": "Vert. Align", + "label": "Vert. align", "key": "vAlign", "showInBar": true, "barStyle": "buttons", @@ -245,7 +245,7 @@ }, { "type": "event", - "label": "On Click", + "label": "On click", "key": "onClick" } ] @@ -317,7 +317,7 @@ "value": "warning" }, { - "label": "Over Background", + "label": "Over background", "value": "overBackground" } ], @@ -367,7 +367,7 @@ }, { "type": "event", - "label": "On Click", + "label": "On click", "key": "onClick" } ] @@ -432,7 +432,7 @@ }, { "type": "text", - "label": "Empty Text", + "label": "Empty text", "key": "noRowsMessage", "defaultValue": "No rows found" }, @@ -460,7 +460,7 @@ }, { "type": "select", - "label": "Horiz. Align", + "label": "Horiz. align", "key": "hAlign", "showInBar": true, "barStyle": "buttons", @@ -494,7 +494,7 @@ }, { "type": "select", - "label": "Vert. Align", + "label": "Vert. align", "key": "vAlign", "showInBar": true, "barStyle": "buttons", @@ -561,7 +561,7 @@ "type": "static", "values": [ { - "label": "Row Index", + "label": "Row index", "key": "index", "type": "number" } @@ -627,7 +627,7 @@ }, { "type": "text", - "label": "Link Text", + "label": "Link text", "key": "linkText" }, { @@ -638,19 +638,19 @@ }, { "type": "color", - "label": "Link Color", + "label": "Link color", "key": "linkColor", "defaultValue": "#000" }, { "type": "color", - "label": "Hover Color", + "label": "Hover color", "key": "linkHoverColor", "defaultValue": "#222" }, { "type": "select", - "label": "Image Height", + "label": "Image height", "key": "imageHeight", "options": [ "auto", @@ -663,7 +663,7 @@ }, { "type": "select", - "label": "Card Width", + "label": "Card width", "key": "cardWidth", "options": [ "16rem", @@ -701,7 +701,7 @@ "barStyle": "picker", "options": [ { - "label": "Extra Small", + "label": "Extra small", "value": "XS" }, { @@ -717,7 +717,7 @@ "value": "L" }, { - "label": "Extra Large", + "label": "Extra large", "value": "XL" }, { @@ -826,7 +826,7 @@ "barStyle": "picker", "options": [ { - "label": "Extra Small", + "label": "Extra amall", "value": "XS" }, { @@ -842,7 +842,7 @@ "value": "L" }, { - "label": "Extra Large", + "label": "Extra large", "value": "XL" }, { @@ -1023,7 +1023,7 @@ "defaultValue": "center center", "options": [ { - "label": "Center Top", + "label": "Center top", "value": "center top" }, { @@ -1031,31 +1031,31 @@ "value": "center center" }, { - "label": "Center Bottom", + "label": "Center bottom", "value": "center bottom" }, { - "label": "Left Top", + "label": "Left top", "value": "left top" }, { - "label": "Left Center", + "label": "Left center", "value": "left center" }, { - "label": "Left Bottom", + "label": "Left bottom", "value": "left bottom" }, { - "label": "Right Top", + "label": "Right top", "value": "right top" }, { - "label": "Right Center", + "label": "Right center", "value": "right center" }, { - "label": "Right Bottom", + "label": "Right bottom", "value": "right bottom" } ] @@ -1152,7 +1152,7 @@ }, { "type": "event", - "label": "On Click", + "label": "On click", "key": "onClick" } ] @@ -1203,7 +1203,7 @@ }, { "type": "boolean", - "label": "New Tab", + "label": "New tab", "key": "openInNewTab" }, { @@ -1325,7 +1325,7 @@ }, { "type": "text", - "label": "Link Text", + "label": "Link text", "key": "linkText" }, { @@ -1336,19 +1336,19 @@ }, { "type": "color", - "label": "Link Color", + "label": "Link color", "key": "linkColor", "defaultValue": "#000" }, { "type": "color", - "label": "Hover Color", + "label": "Hover color", "key": "linkHoverColor", "defaultValue": "#222" }, { "type": "select", - "label": "Card Width", + "label": "Card width", "key": "cardWidth", "options": [ "24rem", @@ -1363,7 +1363,7 @@ }, { "type": "select", - "label": "Image Width", + "label": "Image width", "key": "imageWidth", "options": [ "auto", @@ -1375,7 +1375,7 @@ }, { "type": "select", - "label": "Image Height", + "label": "Image height", "key": "imageHeight", "options": [ "auto", @@ -1462,14 +1462,14 @@ }, { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataProvider", "required": true }, { "type": "multifield", - "label": "Data Cols.", + "label": "Data columns", "key": "valueColumns", "dependsOn": "dataProvider", "required": true @@ -1487,12 +1487,12 @@ }, { "type": "text", - "label": "Y Axis Label", + "label": "Y axis label", "key": "yAxisLabel" }, { "type": "text", - "label": "X Axis Label", + "label": "X axis label", "key": "xAxisLabel" }, { @@ -1584,7 +1584,7 @@ }, { "type": "boolean", - "label": "Data Labels", + "label": "Data labels", "key": "dataLabels", "defaultValue": false }, @@ -1624,14 +1624,14 @@ }, { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataProvider", "required": true }, { "type": "multifield", - "label": "Data Cols.", + "label": "Data columns", "key": "valueColumns", "dependsOn": "dataProvider", "required": true @@ -1649,12 +1649,12 @@ }, { "type": "text", - "label": "Y Axis Label", + "label": "Y axis label", "key": "yAxisLabel" }, { "type": "text", - "label": "X Axis Label", + "label": "X axis label", "key": "xAxisLabel" }, { @@ -1745,7 +1745,7 @@ }, { "type": "boolean", - "label": "Data Labels", + "label": "Data labels", "key": "dataLabels", "defaultValue": false }, @@ -1785,14 +1785,14 @@ }, { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataProvider", "required": true }, { "type": "multifield", - "label": "Data Cols.", + "label": "Data columns", "key": "valueColumns", "dependsOn": "dataProvider", "required": true @@ -1810,12 +1810,12 @@ }, { "type": "text", - "label": "Y Axis Label", + "label": "Y axis label", "key": "yAxisLabel" }, { "type": "text", - "label": "X Axis Label", + "label": "X axis label", "key": "xAxisLabel" }, { @@ -1906,7 +1906,7 @@ }, { "type": "boolean", - "label": "Data Labels", + "label": "Data labels", "key": "dataLabels", "defaultValue": false }, @@ -1958,14 +1958,14 @@ }, { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataProvider", "required": true }, { "type": "field", - "label": "Data Col.", + "label": "Data columns", "key": "valueColumn", "dependsOn": "dataProvider", "required": true @@ -2047,7 +2047,7 @@ }, { "type": "boolean", - "label": "Data Labels", + "label": "Data labels", "key": "dataLabels", "defaultValue": false }, @@ -2087,14 +2087,14 @@ }, { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataProvider", "required": true }, { "type": "field", - "label": "Data Col.", + "label": "Data columns", "key": "valueColumn", "dependsOn": "dataProvider", "required": true @@ -2176,7 +2176,7 @@ }, { "type": "boolean", - "label": "Data Labels", + "label": "Data labels", "key": "dataLabels", "defaultValue": false }, @@ -2216,35 +2216,35 @@ }, { "type": "field", - "label": "Date Col.", + "label": "Date column", "key": "dateColumn", "dependsOn": "dataProvider", "required": true }, { "type": "field", - "label": "Open Col.", + "label": "Open column", "key": "openColumn", "dependsOn": "dataProvider", "required": true }, { "type": "field", - "label": "Close Col.", + "label": "Close column", "key": "closeColumn", "dependsOn": "dataProvider", "required": true }, { "type": "field", - "label": "High Col.", + "label": "High column", "key": "highColumn", "dependsOn": "dataProvider", "required": true }, { "type": "field", - "label": "Low Col.", + "label": "Low column", "key": "lowColumn", "dependsOn": "dataProvider", "required": true @@ -2262,12 +2262,12 @@ }, { "type": "text", - "label": "Y Axis Label", + "label": "Y axis label", "key": "yAxisLabel" }, { "type": "text", - "label": "X Axis Label", + "label": "X axis label", "key": "xAxisLabel" }, { @@ -2483,7 +2483,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -2575,7 +2575,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -2633,7 +2633,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -2687,7 +2687,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -2750,7 +2750,7 @@ }, { "type": "boolean", - "label": "Sort in alphabetical order", + "label": "Alphabetical", "key": "sort", "defaultValue": true }, @@ -2783,7 +2783,7 @@ }, { "type": "dataProvider", - "label": "Options Provider", + "label": "Options provider", "key": "dataProvider", "required": true, "dependsOn": { @@ -2793,7 +2793,7 @@ }, { "type": "field", - "label": "Label Column", + "label": "Label column", "key": "labelColumn", "dependsOn": { "setting": "optionsSource", @@ -2802,7 +2802,7 @@ }, { "type": "field", - "label": "Value Column", + "label": "Value column", "key": "valueColumn", "dependsOn": { "setting": "optionsSource", @@ -2861,7 +2861,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -2946,7 +2946,7 @@ }, { "type": "dataProvider", - "label": "Options Provider", + "label": "Options provider", "key": "dataProvider", "required": true, "dependsOn": { @@ -2956,7 +2956,7 @@ }, { "type": "field", - "label": "Label Column", + "label": "Label column", "key": "labelColumn", "dependsOn": { "setting": "optionsSource", @@ -2965,7 +2965,7 @@ }, { "type": "field", - "label": "Value Column", + "label": "Value column", "key": "valueColumn", "dependsOn": { "setting": "optionsSource", @@ -3044,7 +3044,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -3103,7 +3103,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -3189,7 +3189,7 @@ }, { "type": "boolean", - "label": "24-Hour time", + "label": "24-hour time", "key": "time24hr", "defaultValue": false }, @@ -3206,7 +3206,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -3299,25 +3299,25 @@ }, { "type": "field", - "label": "Latitude Key", + "label": "Latitude key", "key": "latitudeKey", "dependsOn": "dataProvider" }, { "type": "field", - "label": "Longitude Key", + "label": "Longitude key", "key": "longitudeKey", "dependsOn": "dataProvider" }, { "type": "field", - "label": "Title Key", + "label": "Title key", "key": "titleKey", "dependsOn": "dataProvider" }, { "type": "event", - "label": "On Click Marker", + "label": "On click marker", "key": "onClickMarker", "context": [ { @@ -3334,7 +3334,7 @@ }, { "type": "event", - "label": "On Create Marker", + "label": "On create marker", "key": "onCreateMarker", "dependsOn": "creationEnabled", "context": [ @@ -3374,13 +3374,13 @@ }, { "type": "text", - "label": "Default Location", + "label": "Default location", "key": "defaultLocation", "placeholder": "51.5072,-0.1276" }, { "type": "number", - "label": "Default Zoom (0-100)", + "label": "Default zoom (0-100)", "key": "zoomLevel", "placeholder": 50, "max": 100, @@ -3388,7 +3388,7 @@ }, { "type": "text", - "label": "Map Attribution", + "label": "Map attribution", "key": "mapAttribution", "defaultValue": "OpenStreetMap contributors" } @@ -3425,13 +3425,13 @@ }, { "type": "number", - "label": "No. of attachment", + "label": "Max attachments", "key": "maximum", "min": 1 }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -3495,7 +3495,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -3559,7 +3559,7 @@ }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -3601,7 +3601,7 @@ }, { "type": "dataSource/s3", - "label": "S3 Datasource", + "label": "S3 datasource", "key": "datasourceId", "info": "This component can't be used with S3 datasources that use custom endpoints" }, @@ -3612,12 +3612,12 @@ }, { "type": "text", - "label": "File Name", + "label": "File name", "key": "key" }, { "type": "event", - "label": "On Change", + "label": "On change", "key": "onChange", "context": [ { @@ -3667,12 +3667,12 @@ }, { "type": "field/sortable", - "label": "Sort Column", + "label": "Sort column", "key": "sortColumn" }, { "type": "select", - "label": "Sort Order", + "label": "Sort order", "key": "sortOrder", "options": [ "Ascending", @@ -3975,7 +3975,7 @@ "settings": [ { "type": "select", - "label": "Chart Type", + "label": "Chart type", "key": "chartType", "required": true, "options": [ @@ -4024,12 +4024,12 @@ }, { "type": "field", - "label": "Sort Column", + "label": "Sort column", "key": "sortColumn" }, { "type": "select", - "label": "Sort Order", + "label": "Sort order", "key": "sortOrder", "options": [ "Ascending", @@ -4120,7 +4120,7 @@ }, { "type": "boolean", - "label": "Data Labels", + "label": "Data labels", "key": "dataLabels", "defaultValue": false }, @@ -4147,14 +4147,14 @@ "settings": [ { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataSource", "required": true }, { "type": "field", - "label": "Data Col.", + "label": "Data column", "key": "valueColumn", "dependsOn": "dataSource", "required": true @@ -4172,14 +4172,14 @@ "settings": [ { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataSource", "required": true }, { "type": "field", - "label": "Data Col.", + "label": "Data column", "key": "valueColumn", "dependsOn": "dataSource", "required": true @@ -4197,14 +4197,14 @@ "settings": [ { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataSource", "required": true }, { "type": "multifield", - "label": "Data Cols.", + "label": "Data columns", "key": "valueColumns", "dependsOn": "dataSource", "required": true @@ -4222,12 +4222,12 @@ }, { "type": "text", - "label": "Y Axis Label", + "label": "Y axis label", "key": "yAxisLabel" }, { "type": "text", - "label": "X Axis Label", + "label": "X axis label", "key": "xAxisLabel" }, { @@ -4255,14 +4255,14 @@ "settings": [ { "type": "field", - "label": "Label Col.", + "label": "Label column", "key": "labelColumn", "dependsOn": "dataSource", "required": true }, { "type": "multifield", - "label": "Data Cols.", + "label": "Data columns", "key": "valueColumns", "dependsOn": "dataSource", "required": true @@ -4280,12 +4280,12 @@ }, { "type": "text", - "label": "Y Axis Label", + "label": "Y axis label", "key": "yAxisLabel" }, { "type": "text", - "label": "X Axis Label", + "label": "X axis label", "key": "xAxisLabel" }, { @@ -4312,14 +4312,14 @@ "settings": [ { "type": "field", - "label": "Label Col.", + "label": "Label columns", "key": "labelColumn", "dependsOn": "dataSource", "required": true }, { "type": "multifield", - "label": "Data Cols.", + "label": "Data columns", "key": "valueColumns", "dependsOn": "dataSource", "required": true @@ -4337,12 +4337,12 @@ }, { "type": "text", - "label": "Y Axis Label", + "label": "Y axis label", "key": "yAxisLabel" }, { "type": "text", - "label": "X Axis Label", + "label": "X axis label", "key": "xAxisLabel" }, { @@ -4381,35 +4381,35 @@ "settings": [ { "type": "field", - "label": "Date Col.", + "label": "Date column", "key": "dateColumn", "dependsOn": "dataSource", "required": true }, { "type": "field", - "label": "Open Col.", + "label": "Open column", "key": "openColumn", "dependsOn": "dataSource", "required": true }, { "type": "field", - "label": "Close Col.", + "label": "Close column", "key": "closeColumn", "dependsOn": "dataSource", "required": true }, { "type": "field", - "label": "High Col.", + "label": "High column", "key": "highColumn", "dependsOn": "dataSource", "required": true }, { "type": "field", - "label": "Low Col.", + "label": "Low column", "key": "lowColumn", "dependsOn": "dataSource", "required": true @@ -4427,12 +4427,12 @@ }, { "type": "text", - "label": "Y Axis Label", + "label": "Y axis label", "key": "yAxisLabel" }, { "type": "text", - "label": "X Axis Label", + "label": "X axis label", "key": "xAxisLabel" } ] @@ -4476,12 +4476,12 @@ }, { "type": "field/sortable", - "label": "Sort By", + "label": "Sort by", "key": "sortColumn" }, { "type": "select", - "label": "Sort Order", + "label": "Sort order", "key": "sortOrder", "options": [ "Ascending", @@ -4507,7 +4507,7 @@ }, { "type": "number", - "label": "Scroll Limit", + "label": "Scroll limit", "key": "rowCount", "defaultValue": 8 }, @@ -4541,10 +4541,10 @@ }, { "type": "searchfield", - "label": "Search Fields", + "label": "Search fields", "key": "searchColumns", "placeholder": "Choose search fields", - "info": "Only the first 5 search fields will be used" + "info": "Only the first 5 fields will be used" } ] }, @@ -4606,7 +4606,7 @@ { "type": "radio", "key": "titleButtonClickBehaviour", - "label": "On Click", + "label": "Click behaviour", "dependsOn": "showTitleButton", "defaultValue": "actions", "info": "New row side panel is only compatible with internal or SQL tables", @@ -4622,6 +4622,7 @@ ] }, { + "label": "On click", "type": "event", "key": "onClickTitleButton", "nested": true, @@ -4659,10 +4660,10 @@ }, { "type": "searchfield", - "label": "Search Cols.", + "label": "Search columns", "key": "searchColumns", "placeholder": "Choose search columns", - "info": "Only the first 5 search columns will be used" + "info": "Max 5 columns will be used" }, { "type": "filter", @@ -4672,12 +4673,12 @@ }, { "type": "field/sortable", - "label": "Sort Column", + "label": "Sort column", "key": "sortColumn" }, { "type": "select", - "label": "Sort Order", + "label": "Sort order", "key": "sortOrder", "options": [ "Ascending", @@ -4839,12 +4840,12 @@ }, { "type": "field/sortable", - "label": "Sort Column", + "label": "Sort column", "key": "sortColumn" }, { "type": "select", - "label": "Sort Order", + "label": "Sort order", "key": "sortOrder", "options": [ "Ascending", @@ -4869,7 +4870,7 @@ "settings": [ { "type": "text", - "label": "Empty Text", + "label": "Empty text", "key": "noRowsMessage", "defaultValue": "No rows found" }, @@ -4897,7 +4898,7 @@ }, { "type": "select", - "label": "Horiz. Align", + "label": "Horiz. align", "key": "hAlign", "showInBar": true, "barStyle": "buttons", @@ -4931,7 +4932,7 @@ }, { "type": "select", - "label": "Vert. Align", + "label": "Vert. align", "key": "vAlign", "showInBar": true, "barStyle": "buttons", @@ -5250,7 +5251,7 @@ "settings": [ { "type": "field", - "label": "Search Field", + "label": "Search field", "key": "cardSearchField", "nested": true }, From f790c58d97b1fb2c03970718142403a793e81d59 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Thu, 9 Mar 2023 08:51:43 +0000 Subject: [PATCH 3/4] Update style section to render properly in new layout --- .../_components/settings/DesignSection.svelte | 1 - .../_components/settings/StyleSection.svelte | 31 +++++++++---------- .../_components/settings/componentStyles.js | 5 --- 3 files changed, 15 insertions(+), 22 deletions(-) diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/DesignSection.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/DesignSection.svelte index fa1a357f38..444ded7e1f 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/DesignSection.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/DesignSection.svelte @@ -27,7 +27,6 @@ -
+
{#each properties as prop (`${componentInstance._id}-${prop.key}-${prop.label}`)} -
- updateStyle(prop.key, val)} - props={getControlProps(prop)} - {bindings} - /> -
+ updateStyle(prop.key, val)} + props={getControlProps(prop)} + {bindings} + /> {/each}
diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/componentStyles.js b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/componentStyles.js index d4912241b3..7c65b6e6ec 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/componentStyles.js +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/components/[componentId]/_components/settings/componentStyles.js @@ -3,7 +3,6 @@ import ColorPicker from "components/design/settings/controls/ColorPicker.svelte" export const margin = { label: "Margin", - columns: "1fr 1fr", settings: [ { label: "Top", @@ -90,7 +89,6 @@ export const margin = { export const padding = { label: "Padding", - columns: "1fr 1fr", settings: [ { label: "Top", @@ -177,7 +175,6 @@ export const padding = { export const size = { label: "Size", - columns: "1fr 1fr", settings: [ { label: "Width", @@ -196,7 +193,6 @@ export const size = { export const background = { label: "Background", - columns: "auto 1fr", settings: [ { label: "Color", @@ -285,7 +281,6 @@ export const background = { export const border = { label: "Border", - columns: "1fr 1fr", settings: [ { label: "Color", From 56477ab569909eb6365a72e79d05f786a49452fa Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Thu, 9 Mar 2023 09:11:18 +0000 Subject: [PATCH 4/4] Update client lib mobile breakpoint --- .../client/src/components/context/DeviceBindingsProvider.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/client/src/components/context/DeviceBindingsProvider.svelte b/packages/client/src/components/context/DeviceBindingsProvider.svelte index ba2d9c2dc9..bc0e2db093 100644 --- a/packages/client/src/components/context/DeviceBindingsProvider.svelte +++ b/packages/client/src/components/context/DeviceBindingsProvider.svelte @@ -4,7 +4,7 @@ let width = window.innerWidth let height = window.innerHeight - const tabletBreakpoint = 768 + const tabletBreakpoint = 720 const desktopBreakpoint = 1280 const resizeObserver = new ResizeObserver(entries => { if (entries?.[0]) {