diff --git a/packages/builder/cypress/support/commands.js b/packages/builder/cypress/support/commands.js index 2a5a7eb130..1b1cc0c2b0 100644 --- a/packages/builder/cypress/support/commands.js +++ b/packages/builder/cypress/support/commands.js @@ -195,10 +195,7 @@ Cypress.Commands.add("createScreen", (screenName, route) => { cy.get("input").first().clear().type(screenName) cy.get("input").eq(1).clear().type(route) cy.get(".spectrum-Button--cta").click() - }) - cy.get(".spectrum-Modal").within(() => { - cy.get(`[data-cy="left-nav"]`).click() - cy.get(".spectrum-Button--cta").click() + cy.wait(2000) }) }) diff --git a/packages/builder/src/components/design/NavigationPanel/NavigationSelectionModal.svelte b/packages/builder/src/components/design/NavigationPanel/NavigationSelectionModal.svelte index 8035281193..52a8e91451 100644 --- a/packages/builder/src/components/design/NavigationPanel/NavigationSelectionModal.svelte +++ b/packages/builder/src/components/design/NavigationPanel/NavigationSelectionModal.svelte @@ -1,98 +1,12 @@ 0 && !blankSelected - - $: templates = getTemplates($store, $tables.list) + let templates = getTemplates($store, $tables.list) const toggleScreenSelection = table => { if (selectedScreens.find(s => s.name.includes(table.name))) { selectedScreens = selectedScreens.filter( screen => !screen.name.includes(table.name) ) } else { - templates = templates.filter(template => - template.name.includes(table.name) + let partialTemplates = getTemplates($store, $tables.list).filter( + template => template.name.includes(table.name) ) - selectedScreens = [...templates, ...selectedScreens] + selectedScreens = [...partialTemplates, ...selectedScreens] } } @@ -31,7 +31,7 @@ title="Add screens" confirmText="Add Screens" cancelText="Cancel" - onConfirm={() => (autoSelected ? chooseModal(2) : chooseModal(1))} + onConfirm={() => (autoSelected ? save() : chooseModal(1))} disabled={!selectedScreens.length} size="L" > @@ -60,7 +60,7 @@ Autogenerated Screens - {#each $tables.list.filter(table => table.type !== "external") as table} + {#each $tables.list.filter(table => table.type !== "external" && table._id !== "ta_users") as table}
x.name.includes(table.name))} diff --git a/packages/builder/src/components/design/NavigationPanel/ScreenDetailsModal.svelte b/packages/builder/src/components/design/NavigationPanel/ScreenDetailsModal.svelte index f353da1a4b..f67f363ce8 100644 --- a/packages/builder/src/components/design/NavigationPanel/ScreenDetailsModal.svelte +++ b/packages/builder/src/components/design/NavigationPanel/ScreenDetailsModal.svelte @@ -6,7 +6,7 @@ export let screenName export let url export let chooseModal - + export let save let routeError let roleId = $selectedAccessRole || "BASIC" @@ -37,7 +37,7 @@ title={"Enter details"} confirmText={"Continue"} onCancel={() => chooseModal(0)} - onConfirm={() => chooseModal(2)} + onConfirm={() => save()} cancelText={"Back"} disabled={!screenName || !url || routeError} > diff --git a/packages/builder/src/components/design/NavigationPanel/ScreenWizard.svelte b/packages/builder/src/components/design/NavigationPanel/ScreenWizard.svelte index 33d3cbb4aa..7018bc2ed4 100644 --- a/packages/builder/src/components/design/NavigationPanel/ScreenWizard.svelte +++ b/packages/builder/src/components/design/NavigationPanel/ScreenWizard.svelte @@ -1,8 +1,10 @@ - + - - - - +