From a8f873fff398bc68e4b03a731cf35eda907e15a4 Mon Sep 17 00:00:00 2001
From: melohagan <101575380+melohagan@users.noreply.github.com>
Date: Wed, 8 Mar 2023 13:39:18 +0000
Subject: [PATCH] Try/catch automation Create Row relationship (#9924)

* Try/catch

* Increase height of automation test output

* Unit tests

* lint
---
 .../AutomationBuilder/TestDisplay.svelte      |  7 +-
 .../server/src/automations/automationUtils.ts |  8 ++-
 .../unitTests/automationUtils.spec.ts         | 68 +++++++++++++++++++
 3 files changed, 78 insertions(+), 5 deletions(-)

diff --git a/packages/builder/src/components/automation/AutomationBuilder/TestDisplay.svelte b/packages/builder/src/components/automation/AutomationBuilder/TestDisplay.svelte
index d74eab3622..043844b6d2 100644
--- a/packages/builder/src/components/automation/AutomationBuilder/TestDisplay.svelte
+++ b/packages/builder/src/components/automation/AutomationBuilder/TestDisplay.svelte
@@ -73,14 +73,14 @@
             <Tabs noHorizPadding selected="Input">
               <Tab title="Input">
                 <TextArea
-                  minHeight="80px"
+                  minHeight="160px"
                   disabled
                   value={textArea(filteredResults?.[idx]?.inputs, "No input")}
                 />
               </Tab>
               <Tab title="Output">
                 <TextArea
-                  minHeight="100px"
+                  minHeight="160px"
                   disabled
                   value={textArea(filteredResults?.[idx]?.outputs, "No output")}
                 />
@@ -98,8 +98,9 @@
 
 <style>
   .container {
-    padding: 0 30px 0 30px;
+    padding: 0 30px 30px 30px;
     height: 100%;
+    overflow: auto;
   }
 
   .tabs {
diff --git a/packages/server/src/automations/automationUtils.ts b/packages/server/src/automations/automationUtils.ts
index 7691bf7a6f..254d9c624b 100644
--- a/packages/server/src/automations/automationUtils.ts
+++ b/packages/server/src/automations/automationUtils.ts
@@ -52,14 +52,18 @@ export function cleanInputValues(inputs: Record<string, any>, schema: any) {
       }
     }
   }
-  //Check if input field should be a relationship and cast to array
+  //Check if input field for Update Row should be a relationship and cast to array
   for (let key in inputs.row) {
     if (
       inputs.schema?.[key]?.type === "link" &&
       inputs.row[key] &&
       typeof inputs.row[key] === "string"
     ) {
-      inputs.row[key] = JSON.parse(inputs.row[key])
+      try {
+        inputs.row[key] = JSON.parse(inputs.row[key])
+      } catch (e) {
+        //Link is not an array or object, so continue
+      }
     }
   }
   return inputs
diff --git a/packages/server/src/automations/unitTests/automationUtils.spec.ts b/packages/server/src/automations/unitTests/automationUtils.spec.ts
index b80b2d60be..2291df9bc2 100644
--- a/packages/server/src/automations/unitTests/automationUtils.spec.ts
+++ b/packages/server/src/automations/unitTests/automationUtils.spec.ts
@@ -62,4 +62,72 @@ describe("automationUtils", () => {
       ).toThrow()
     })
   })
+
+  describe("cleanInputValues", () => {
+    it("should handle array relationship fields from read binding", () => {
+      const schema = {
+        relationship: {
+          type: "link",
+          constraints: {
+            type: "array",
+            presence: false,
+          },
+          fieldName: "Users",
+          name: "relationship",
+          relationshipType: "many-to-many",
+          tableId: "ta_users",
+          sortable: false,
+        },
+      }
+      expect(
+        automationUtils.cleanInputValues(
+          {
+            row: {
+              relationship: `[{"_id": "ro_ta_users_us_3"}]`,
+            },
+            schema,
+          },
+          schema
+        )
+      ).toEqual({
+        row: {
+          relationship: [{ _id: "ro_ta_users_us_3" }],
+        },
+        schema,
+      })
+    })
+
+    it("should handle single string relationship field", () => {
+      const schema = {
+        relationship: {
+          type: "link",
+          constraints: {
+            type: "array",
+            presence: false,
+          },
+          fieldName: "Users",
+          name: "relationship",
+          relationshipType: "many-to-many",
+          tableId: "ta_users",
+          sortable: false,
+        },
+      }
+      expect(
+        automationUtils.cleanInputValues(
+          {
+            row: {
+              relationship: `ro_ta_users_us_3`,
+            },
+            schema,
+          },
+          schema
+        )
+      ).toEqual({
+        row: {
+          relationship: "ro_ta_users_us_3",
+        },
+        schema,
+      })
+    })
+  })
 })