From a87b158d41068189c1f7ced2859d2ed3575629da Mon Sep 17 00:00:00 2001 From: Dean Date: Fri, 23 Feb 2024 11:04:19 +0000 Subject: [PATCH] Feedback --- .../portal/onboarding/TourWrap.svelte | 19 +++--- .../NewScreen/FormTypeModal.svelte | 61 ++++++++++++++++--- 2 files changed, 63 insertions(+), 17 deletions(-) diff --git a/packages/builder/src/components/portal/onboarding/TourWrap.svelte b/packages/builder/src/components/portal/onboarding/TourWrap.svelte index 779a84f463..05b3935f23 100644 --- a/packages/builder/src/components/portal/onboarding/TourWrap.svelte +++ b/packages/builder/src/components/portal/onboarding/TourWrap.svelte @@ -17,15 +17,7 @@ } } - $: tourKeyWatch = $builderStore.tourKey - $: tourStepKeyWatch = $builderStore.tourStepKey - $: if (tourKeyWatch || stepKeys || ready) { - stepKeys.forEach(tourStepKey => { - registerTourNode(tourKeyWatch, tourStepKey) - }) - } - - $: if (tourKeyWatch || tourStepKeyWatch) { + const scrollToStep = () => { let tourStepIdx = getCurrentStepIdx( TOURS[tourKeyWatch]?.steps, tourStepKeyWatch @@ -39,6 +31,15 @@ } } + $: tourKeyWatch = $builderStore.tourKey + $: tourStepKeyWatch = $builderStore.tourStepKey + $: if (tourKeyWatch || stepKeys || ready) { + stepKeys.forEach(tourStepKey => { + registerTourNode(tourKeyWatch, tourStepKey) + }) + } + $: scrollToStep(tourKeyWatch, tourStepKeyWatch) + onMount(() => { ready = true }) diff --git a/packages/builder/src/pages/builder/app/[application]/design/_components/NewScreen/FormTypeModal.svelte b/packages/builder/src/pages/builder/app/[application]/design/_components/NewScreen/FormTypeModal.svelte index 856552dec2..05656160c1 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/_components/NewScreen/FormTypeModal.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/_components/NewScreen/FormTypeModal.svelte @@ -1,5 +1,5 @@