CodeMirror/budibase
1
0
Fork 0
mirror of synced 2024-09-24 13:21:53 +12:00
Code Issues Projects Releases Wiki Activity

Merge pull request #14601 from Budibase/fix-row-delete-trigger

Browse source 
Add table ID to row deletion requests that only contain string IDs
This commit is contained in:
Andrew Kingston 2024-09-19 13:01:01 +01:00 committed by GitHub
commit 96f92b07f4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/server/src/api/controllers/row/index.ts
View file

@ -138,7 +138,7 @@ async function processDeleteRowsRequest(ctx: UserCtx<DeleteRowRequest>) {
const { tableId } = utils.getSourceId(ctx) const { tableId } = utils.getSourceId(ctx)
const processedRows = request.rows.map(row => { const processedRows = request.rows.map(row => {
let processedRow: Row = typeof row == "string" ? { _id: row } : row let processedRow: Row = typeof row == "string" ? { _id: row, tableId } : row
return !processedRow._rev return !processedRow._rev
? addRev(fixRow(processedRow, ctx.params), tableId) ? addRev(fixRow(processedRow, ctx.params), tableId)
: fixRow(processedRow, ctx.params) : fixRow(processedRow, ctx.params)

12
packages/server/src/api/routes/tests/row.spec.ts
View file

@ -1138,6 +1138,18 @@ describe.each([
await assertRowUsage(isInternal ? rowUsage - 1 : rowUsage) await assertRowUsage(isInternal ? rowUsage - 1 : rowUsage)
}) })
it("should be able to delete a row with ID only", async () => {
const createdRow = await config.api.row.save(table._id!, {})
const rowUsage = await getRowUsage()
const res = await config.api.row.bulkDelete(table._id!, {
rows: [createdRow._id!],
})
expect(res[0]._id).toEqual(createdRow._id)
expect(res[0].tableId).toEqual(table._id!)
await assertRowUsage(isInternal ? rowUsage - 1 : rowUsage)
})
it("should be able to bulk delete rows, including a row that doesn't exist", async () => { it("should be able to bulk delete rows, including a row that doesn't exist", async () => {
const createdRow = await config.api.row.save(table._id!, {}) const createdRow = await config.api.row.save(table._id!, {})
const createdRow2 = await config.api.row.save(table._id!, {}) const createdRow2 = await config.api.row.save(table._id!, {})