From 8fd2cce093b121286ee3afdbde7dd701e31154a5 Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Wed, 3 Jul 2024 15:52:48 +0200
Subject: [PATCH] Remove platform user on remove

---
 packages/backend-core/src/users/db.ts         | 18 +++++---
 .../backend-core/src/users/test/db.spec.ts    | 43 +++++++++++++++++--
 2 files changed, 50 insertions(+), 11 deletions(-)

diff --git a/packages/backend-core/src/users/db.ts b/packages/backend-core/src/users/db.ts
index b1c7a25c8f..4865ebb5bc 100644
--- a/packages/backend-core/src/users/db.ts
+++ b/packages/backend-core/src/users/db.ts
@@ -221,7 +221,7 @@ export class UserDB {
     const tenantId = getTenantId()
     const db = getGlobalDB()
 
-    let { email, _id, userGroups = [], roles } = user
+    const { email, _id, userGroups = [], roles } = user
 
     if (!email && !_id) {
       throw new Error("_id or email is required")
@@ -231,11 +231,10 @@ export class UserDB {
     if (_id) {
       // try to get existing user from db
       try {
-        dbUser = (await db.get(_id)) as User
+        dbUser = await usersCore.getById(_id)
         if (email && dbUser.email !== email && !opts.allowChangingEmail) {
           throw new Error("Email address cannot be changed")
         }
-        email = dbUser.email
       } catch (e: any) {
         if (e.status === 404) {
           // do nothing, save this new user with the id specified - required for SSO auth
@@ -271,13 +270,13 @@ export class UserDB {
 
       // make sure we set the _id field for a new user
       // Also if this is a new user, associate groups with them
-      let groupPromises = []
+      const groupPromises = []
       if (!_id) {
-        _id = builtUser._id!
-
         if (userGroups.length > 0) {
           for (let groupId of userGroups) {
-            groupPromises.push(UserDB.groups.addUsers(groupId, [_id!]))
+            groupPromises.push(
+              UserDB.groups.addUsers(groupId, [builtUser._id!])
+            )
           }
         }
       }
@@ -288,6 +287,11 @@ export class UserDB {
         builtUser._rev = response.rev
 
         await eventHelpers.handleSaveEvents(builtUser, dbUser)
+        if (dbUser && builtUser.email !== dbUser.email) {
+          // Remove the plaform email reference if the email changed
+          await platform.users.removeUser({ email: dbUser.email } as User)
+        }
+
         await platform.users.addUser(
           tenantId,
           builtUser._id!,
diff --git a/packages/backend-core/src/users/test/db.spec.ts b/packages/backend-core/src/users/test/db.spec.ts
index 0a103e1064..3e29d6673c 100644
--- a/packages/backend-core/src/users/test/db.spec.ts
+++ b/packages/backend-core/src/users/test/db.spec.ts
@@ -1,6 +1,7 @@
 import { User, UserStatus } from "@budibase/types"
 import { DBTestConfiguration, generator, structures } from "../../../tests"
 import { UserDB } from "../db"
+import { searchExistingEmails } from "../lookup"
 
 const db = UserDB
 
@@ -134,20 +135,54 @@ describe("UserDB", () => {
 
       it("email can be updated if specified", async () => {
         await config.doInTenant(async () => {
-          user.email = generator.email({})
+          const newEmail = generator.email({})
 
-          await db.save(user, { allowChangingEmail: true })
+          await db.save(
+            { ...user, email: newEmail },
+            { allowChangingEmail: true }
+          )
 
-          const persistedUser = await db.getUserByEmail(user.email)
+          const persistedUser = await db.getUserByEmail(newEmail)
           expect(persistedUser).toEqual(
             expect.objectContaining({
               _id: user._id,
-              email: user.email,
+              email: newEmail,
               lastName: user.lastName,
+              _rev: expect.stringMatching(/^2-\w+/),
             })
           )
         })
       })
+
+      it("updating emails frees previous emails", async () => {
+        await config.doInTenant(async () => {
+          const previousEmail = user.email
+          const newEmail = generator.email({})
+          expect(await searchExistingEmails([previousEmail, newEmail])).toEqual(
+            [previousEmail]
+          )
+
+          await db.save(
+            { ...user, email: newEmail },
+            { allowChangingEmail: true }
+          )
+
+          expect(await searchExistingEmails([previousEmail, newEmail])).toEqual(
+            [newEmail]
+          )
+
+          await db.save(
+            structures.users.user({
+              email: previousEmail,
+              tenantId: config.getTenantId(),
+            })
+          )
+
+          expect(await searchExistingEmails([previousEmail, newEmail])).toEqual(
+            [previousEmail, newEmail]
+          )
+        })
+      })
     })
   })
 })