From 8f058756c319ca73513c32aa979331c21e42eb9d Mon Sep 17 00:00:00 2001
From: Andrew Kingston <andrew@kingston.dev>
Date: Thu, 25 Apr 2024 16:43:51 +0100
Subject: [PATCH] Rename date picker flag to be more meaningful and ensure
 action menus never shrink

---
 packages/bbui/src/ActionMenu/ActionMenu.svelte         | 10 +++++++++-
 packages/bbui/src/Actions/position_dropdown.js         |  4 ++--
 .../bbui/src/Form/Core/DatePicker/DatePicker.svelte    |  2 +-
 packages/bbui/src/Popover/Popover.svelte               |  4 ++--
 .../src/components/grid/cells/HeaderCell.svelte        |  2 +-
 .../src/components/grid/layout/NewColumnButton.svelte  |  2 +-
 .../src/components/grid/overlays/GridPopover.svelte    |  4 ++--
 7 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/packages/bbui/src/ActionMenu/ActionMenu.svelte b/packages/bbui/src/ActionMenu/ActionMenu.svelte
index c55d1cb43d..75ddd679da 100644
--- a/packages/bbui/src/ActionMenu/ActionMenu.svelte
+++ b/packages/bbui/src/ActionMenu/ActionMenu.svelte
@@ -38,7 +38,15 @@
 <div use:getAnchor on:click={openMenu}>
   <slot name="control" />
 </div>
-<Popover bind:this={dropdown} {anchor} {align} {portalTarget} on:open on:close>
+<Popover
+  bind:this={dropdown}
+  {anchor}
+  {align}
+  {portalTarget}
+  resizable={false}
+  on:open
+  on:close
+>
   <Menu>
     <slot />
   </Menu>
diff --git a/packages/bbui/src/Actions/position_dropdown.js b/packages/bbui/src/Actions/position_dropdown.js
index ef82387a23..6c4fcab757 100644
--- a/packages/bbui/src/Actions/position_dropdown.js
+++ b/packages/bbui/src/Actions/position_dropdown.js
@@ -38,7 +38,7 @@ export default function positionDropdown(element, opts) {
       useAnchorWidth,
       offset = 5,
       customUpdate,
-      fitToScreen,
+      resizable,
       wrap,
     } = opts
     if (!anchor) {
@@ -82,7 +82,7 @@ export default function positionDropdown(element, opts) {
 
       // Applies a dynamic max height constraint if appropriate
       const applyMaxHeight = height => {
-        if (!styles.maxHeight && fitToScreen) {
+        if (!styles.maxHeight && resizable) {
           styles.maxHeight = height
         }
       }
diff --git a/packages/bbui/src/Form/Core/DatePicker/DatePicker.svelte b/packages/bbui/src/Form/Core/DatePicker/DatePicker.svelte
index 28f1b1c9e0..f5189c9edd 100644
--- a/packages/bbui/src/Form/Core/DatePicker/DatePicker.svelte
+++ b/packages/bbui/src/Form/Core/DatePicker/DatePicker.svelte
@@ -68,7 +68,7 @@
   portalTarget={appendTo}
   {anchor}
   {align}
-  fitToScreen={false}
+  resizable={false}
 >
   {#if isOpen}
     <DatePickerPopoverContents
diff --git a/packages/bbui/src/Popover/Popover.svelte b/packages/bbui/src/Popover/Popover.svelte
index 8f9629e668..aa811afe1e 100644
--- a/packages/bbui/src/Popover/Popover.svelte
+++ b/packages/bbui/src/Popover/Popover.svelte
@@ -25,7 +25,7 @@
   export let handlePostionUpdate
   export let showPopover = true
   export let clickOutsideOverride = false
-  export let fitToScreen = true
+  export let resizable = true
   export let wrap = false
 
   $: target = portalTarget || getContext(Context.PopoverRoot) || ".spectrum"
@@ -93,7 +93,7 @@
         useAnchorWidth,
         offset,
         customUpdate: handlePostionUpdate,
-        fitToScreen,
+        resizable,
         wrap,
       }}
       use:clickOutside={{
diff --git a/packages/frontend-core/src/components/grid/cells/HeaderCell.svelte b/packages/frontend-core/src/components/grid/cells/HeaderCell.svelte
index 51b520a4ea..af1f1b6b78 100644
--- a/packages/frontend-core/src/components/grid/cells/HeaderCell.svelte
+++ b/packages/frontend-core/src/components/grid/cells/HeaderCell.svelte
@@ -313,7 +313,7 @@
     align="right"
     on:close={close}
     maxHeight={null}
-    fitToScreen
+    resizable
   >
     {#if editIsOpen}
       <div class="content">
diff --git a/packages/frontend-core/src/components/grid/layout/NewColumnButton.svelte b/packages/frontend-core/src/components/grid/layout/NewColumnButton.svelte
index 84d45dc3ed..de68dea644 100644
--- a/packages/frontend-core/src/components/grid/layout/NewColumnButton.svelte
+++ b/packages/frontend-core/src/components/grid/layout/NewColumnButton.svelte
@@ -44,7 +44,7 @@
     align={$visibleColumns.length ? "right" : "left"}
     on:close={close}
     maxHeight={null}
-    fitToScreen
+    resizable
   >
     <div class="content">
       <slot />
diff --git a/packages/frontend-core/src/components/grid/overlays/GridPopover.svelte b/packages/frontend-core/src/components/grid/overlays/GridPopover.svelte
index 06fb4f04a5..ac2a998428 100644
--- a/packages/frontend-core/src/components/grid/overlays/GridPopover.svelte
+++ b/packages/frontend-core/src/components/grid/overlays/GridPopover.svelte
@@ -13,7 +13,7 @@
   export let maxHeight = PopoverMaxHeight
   export let align = "left"
   export let open = true
-  export let fitToScreen = false
+  export let resizable = false
   export let wrap = true
 
   const { gridID } = getContext("grid")
@@ -40,7 +40,7 @@
   {open}
   {anchor}
   {align}
-  {fitToScreen}
+  {resizable}
   {wrap}
   portalTarget="#{gridID} .grid-popover-container"
   offset={0}