From 8c890af814626b835182046cbdd6755056df1f98 Mon Sep 17 00:00:00 2001 From: Sam Rose Date: Tue, 27 Aug 2024 15:29:37 +0100 Subject: [PATCH] Fix view tests. --- packages/server/src/api/controllers/row/views.ts | 2 +- .../server/src/api/routes/tests/viewV2.spec.ts | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/server/src/api/controllers/row/views.ts b/packages/server/src/api/controllers/row/views.ts index 1afe56a322..d2541dfa25 100644 --- a/packages/server/src/api/controllers/row/views.ts +++ b/packages/server/src/api/controllers/row/views.ts @@ -42,7 +42,7 @@ export async function searchView( if ( !isExternalTableID(view.tableId) && - (await features.flags.isEnabled("SQS")) + !(await features.flags.isEnabled("SQS")) ) { // Extract existing fields const existingFields = diff --git a/packages/server/src/api/routes/tests/viewV2.spec.ts b/packages/server/src/api/routes/tests/viewV2.spec.ts index c7b224770d..079d85c684 100644 --- a/packages/server/src/api/routes/tests/viewV2.spec.ts +++ b/packages/server/src/api/routes/tests/viewV2.spec.ts @@ -34,12 +34,12 @@ import sdk from "../../../sdk" describe.each([ ["lucene", undefined], - // ["sqs", undefined], - // [DatabaseName.POSTGRES, getDatasource(DatabaseName.POSTGRES)], - // [DatabaseName.MYSQL, getDatasource(DatabaseName.MYSQL)], - // [DatabaseName.SQL_SERVER, getDatasource(DatabaseName.SQL_SERVER)], - // [DatabaseName.MARIADB, getDatasource(DatabaseName.MARIADB)], - // [DatabaseName.ORACLE, getDatasource(DatabaseName.ORACLE)], + ["sqs", undefined], + [DatabaseName.POSTGRES, getDatasource(DatabaseName.POSTGRES)], + [DatabaseName.MYSQL, getDatasource(DatabaseName.MYSQL)], + [DatabaseName.SQL_SERVER, getDatasource(DatabaseName.SQL_SERVER)], + [DatabaseName.MARIADB, getDatasource(DatabaseName.MARIADB)], + [DatabaseName.ORACLE, getDatasource(DatabaseName.ORACLE)], ])("/v2/views (%s)", (name, dsProvider) => { const config = setup.getConfig() const isSqs = name === "sqs" @@ -1491,7 +1491,7 @@ describe.each([ ) }) - it.only("can query on top of the view filters", async () => { + it("can query on top of the view filters", async () => { await config.api.row.save(table._id!, { one: "foo", two: "bar",