From 221d03c15343ed122f4fd3b6d8017f145e275b87 Mon Sep 17 00:00:00 2001
From: Peter Clement <peter@budibase.com>
Date: Fri, 26 May 2023 13:18:08 +0100
Subject: [PATCH 1/2] fix reactivity bug with synchronous param

---
 .../actions/TriggerAutomation.svelte          | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/TriggerAutomation.svelte b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/TriggerAutomation.svelte
index 4a70dd2fd4..4c54761650 100644
--- a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/TriggerAutomation.svelte
+++ b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/actions/TriggerAutomation.svelte
@@ -7,8 +7,6 @@
   export let parameters = {}
   export let bindings = []
 
-  let synchronous = parameters.synchronous
-
   const AUTOMATION_STATUS = {
     NEW: "new",
     EXISTING: "existing",
@@ -20,14 +18,11 @@
 
   $: {
     if (automationStatus === AUTOMATION_STATUS.NEW) {
-      synchronous = false
-    }
-
-    if (automationStatus === AUTOMATION_STATUS.EXISTING) {
-      synchronous = automations.find(
-        automation => automation._id === parameters.automationId
-      ).synchronous
+      parameters.synchronous = false
     }
+    parameters.synchronous = automations.find(
+      automation => automation._id === parameters.automationId
+    )?.synchronous
   }
   $: automations = $automationStore.automations
     .filter(a => a.definition.trigger?.stepId === TriggerStepID.APP)
@@ -80,11 +75,10 @@
 
   const onChange = value => {
     let automationId = value.detail
-    synchronous = automations.find(
+    parameters.synchronous = automations.find(
       automation => automation._id === automationId
-    ).synchronous
+    )?.synchronous
     parameters.automationId = automationId
-    parameters.synchronous = synchronous
   }
 </script>
 
@@ -128,7 +122,7 @@
       />
     {/if}
 
-    {#if synchronous}
+    {#if parameters.synchronous}
       <Label small />
 
       <div class="synchronous-info">

From 66e1f57a3d6452a52d93a0abe86b9b9d85fc92ac Mon Sep 17 00:00:00 2001
From: Peter Clement <peter@budibase.com>
Date: Fri, 26 May 2023 16:06:16 +0100
Subject: [PATCH 2/2] one more feature check for safety on the trigger

---
 packages/server/src/api/controllers/automation.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/server/src/api/controllers/automation.ts b/packages/server/src/api/controllers/automation.ts
index 79f93c3efa..be7af7b075 100644
--- a/packages/server/src/api/controllers/automation.ts
+++ b/packages/server/src/api/controllers/automation.ts
@@ -14,7 +14,7 @@ import { deleteEntityMetadata } from "../../utilities"
 import { MetadataTypes } from "../../constants"
 import { setTestFlag, clearTestFlag } from "../../utilities/redis"
 import { context, cache, events } from "@budibase/backend-core"
-import { automations } from "@budibase/pro"
+import { automations, features } from "@budibase/pro"
 import {
   Automation,
   AutomationActionStepId,
@@ -266,7 +266,7 @@ export async function trigger(ctx: BBContext) {
   let automation = await db.get(ctx.params.id)
 
   let hasCollectStep = sdk.automations.utils.checkForCollectStep(automation)
-  if (hasCollectStep) {
+  if (hasCollectStep && (await features.isSyncAutomationsEnabled())) {
     const response: AutomationResults = await triggers.externalTrigger(
       automation,
       {