From 2dadf1d429e250a03176c7cbf09c8ce4ef5f6abc Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Tue, 11 Jul 2023 20:05:10 +0200 Subject: [PATCH 1/4] Fix conflicting mssql configuration --- .../src/integrations/microsoftSqlServer.ts | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/server/src/integrations/microsoftSqlServer.ts b/packages/server/src/integrations/microsoftSqlServer.ts index c9e3b82a9f..1804c3d19e 100644 --- a/packages/server/src/integrations/microsoftSqlServer.ts +++ b/packages/server/src/integrations/microsoftSqlServer.ts @@ -233,8 +233,11 @@ class SqlServerIntegration extends Sql implements DatasourcePlus { try { // if encrypt is undefined, then default is to encrypt const encrypt = this.config.encrypt === undefined || this.config.encrypt - const clientCfg: MSSQLConfig & sqlServer.config = { - ...this.config, + const clientCfg: sqlServer.config = { + user: this.config.user, + password: this.config.password, + server: this.config.server, + database: this.config.database, port: +this.config.port, options: { encrypt, @@ -244,11 +247,11 @@ class SqlServerIntegration extends Sql implements DatasourcePlus { if (encrypt) { clientCfg.options!.trustServerCertificate = true } - delete clientCfg.encrypt switch (this.config.authType) { case MSSQLConfigAuthType.AZURE_ACTIVE_DIRECTORY: - const { clientId, tenantId, clientSecret } = this.config.adConfig + const { clientId, tenantId, clientSecret } = + this.config.adConfig || {} const clientApp = new ConfidentialClientApplication({ auth: { clientId, @@ -269,7 +272,8 @@ class SqlServerIntegration extends Sql implements DatasourcePlus { } break case MSSQLConfigAuthType.NTLM: - const { domain, trustServerCertificate } = this.config.ntlmConfig + const { domain, trustServerCertificate } = + this.config.ntlmConfig || {} clientCfg.authentication = { type: "ntlm", options: { @@ -277,8 +281,9 @@ class SqlServerIntegration extends Sql implements DatasourcePlus { }, } clientCfg.options ??= {} - clientCfg.options.trustServerCertificate = trustServerCertificate + clientCfg.options.trustServerCertificate = !!trustServerCertificate break + case null: case undefined: break default: From c9f6c057c6856466c2ed120feae1569e99a3f02f Mon Sep 17 00:00:00 2001 From: Budibase Staging Release Bot <> Date: Tue, 11 Jul 2023 18:34:10 +0000 Subject: [PATCH 2/4] Bump version to 2.8.10 --- lerna.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lerna.json b/lerna.json index 7870ebe15a..8cf6469277 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "2.8.9", + "version": "2.8.10", "npmClient": "yarn", "packages": [ "packages/*" From 731482c359c0c5cce4848bf4299161d17bc85cde Mon Sep 17 00:00:00 2001 From: melohagan <101575380+melohagan@users.noreply.github.com> Date: Mon, 17 Jul 2023 16:40:07 +0100 Subject: [PATCH 3/4] Localize animation (#11240) --- packages/bbui/src/Form/Core/Combobox.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/bbui/src/Form/Core/Combobox.svelte b/packages/bbui/src/Form/Core/Combobox.svelte index 2835b3cd40..b68a24d8db 100644 --- a/packages/bbui/src/Form/Core/Combobox.svelte +++ b/packages/bbui/src/Form/Core/Combobox.svelte @@ -82,7 +82,7 @@ {#if open}
(open = false)} />
    From 730e0b567ceabaffe974200b322094e77cbcf330 Mon Sep 17 00:00:00 2001 From: Budibase Staging Release Bot <> Date: Mon, 17 Jul 2023 15:40:26 +0000 Subject: [PATCH 4/4] Bump version to 2.8.11 --- lerna.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lerna.json b/lerna.json index 8cf6469277..4fa6ce58d8 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "2.8.10", + "version": "2.8.11", "npmClient": "yarn", "packages": [ "packages/*"