diff --git a/packages/builder/src/components/common/bindings/DrawerBindableCombobox.svelte b/packages/builder/src/components/common/bindings/DrawerBindableCombobox.svelte index c929f1039e..9a05b90567 100644 --- a/packages/builder/src/components/common/bindings/DrawerBindableCombobox.svelte +++ b/packages/builder/src/components/common/bindings/DrawerBindableCombobox.svelte @@ -22,6 +22,7 @@ const dispatch = createEventDispatcher() let bindingDrawer + let valid = true $: readableValue = runtimeToReadableBinding(bindings, value) $: tempValue = readableValue @@ -76,12 +77,15 @@ Add the objects on the left to enrich your text. - + (tempValue = event.detail)} {bindings} {allowJS} diff --git a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/ButtonActionDrawer.svelte b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/ButtonActionDrawer.svelte index 43e3b0ed99..958a6d233d 100644 --- a/packages/builder/src/components/design/settings/controls/ButtonActionEditor/ButtonActionDrawer.svelte +++ b/packages/builder/src/components/design/settings/controls/ButtonActionEditor/ButtonActionDrawer.svelte @@ -118,6 +118,10 @@ const getAllBindings = (bindings, eventContextBindings, actions) => { let allBindings = eventContextBindings.concat(bindings) + if (!actions) { + return [] + } + // Ensure bindings are generated for all "update state" action keys actions .filter(action => { diff --git a/packages/worker/src/api/controllers/global/configs.ts b/packages/worker/src/api/controllers/global/configs.ts index 89c67180bc..855d766a87 100644 --- a/packages/worker/src/api/controllers/global/configs.ts +++ b/packages/worker/src/api/controllers/global/configs.ts @@ -267,7 +267,7 @@ export async function publicSettings(ctx: Ctx) { // enrich the logo url // empty url means deleted - if (config.config.logoUrl !== "") { + if (config.config.logoUrl && config.config.logoUrl !== "") { config.config.logoUrl = objectStore.getGlobalFileUrl( "settings", "logoUrl",