From 64951d6f29c39d054197133e82b251c4735d8e8c Mon Sep 17 00:00:00 2001 From: Dean Date: Mon, 22 Jan 2024 09:44:57 +0000 Subject: [PATCH] PR feedback --- packages/client/src/components/app/Repeater.svelte | 10 ++++------ .../components/app/blocks/form/FormBlockWrapper.svelte | 3 ++- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/packages/client/src/components/app/Repeater.svelte b/packages/client/src/components/app/Repeater.svelte index 95f53a6d01..8796078311 100644 --- a/packages/client/src/components/app/Repeater.svelte +++ b/packages/client/src/components/app/Repeater.svelte @@ -2,6 +2,7 @@ import { getContext } from "svelte" import Placeholder from "./Placeholder.svelte" import Container from "./Container.svelte" + import { ContextScopes } from "constants" export let dataProvider export let noRowsMessage @@ -9,9 +10,9 @@ export let hAlign export let vAlign export let gap - export let nested = false + export let scope = ContextScopes.Local - const { Provider, ContextScopes } = getContext("sdk") + const { Provider } = getContext("sdk") const component = getContext("component") $: rows = dataProvider?.rows ?? [] @@ -23,10 +24,7 @@ {:else if rows.length > 0} {#each rows as row, index} - + {/each} diff --git a/packages/client/src/components/app/blocks/form/FormBlockWrapper.svelte b/packages/client/src/components/app/blocks/form/FormBlockWrapper.svelte index 666c8dbd73..5b89018fdf 100644 --- a/packages/client/src/components/app/blocks/form/FormBlockWrapper.svelte +++ b/packages/client/src/components/app/blocks/form/FormBlockWrapper.svelte @@ -10,6 +10,7 @@ export let noRowsMessage const component = getContext("component") + const { ContextScopes } = getContext("sdk") $: providerId = `${$component.id}-provider` $: dataProvider = `{{ literal ${safe(providerId)} }}` @@ -55,7 +56,7 @@ noRowsMessage: noRowsMessage || "We couldn't find a row to display", direction: "column", hAlign: "center", - nested: true, + scope: ContextScopes.Global, }} >