Merge pull request #4817 from Budibase/fix/s3-upload

Fix S3 upload component

packages/client/src/components/app/forms/S3Upload.svelte

@@ -81,7 +81,10 @@
       loading = false
       return res
     } catch (error) {
-      notificationStore.actions.error(`Error uploading file: ${error}`)
+      notificationStore.actions.error(
+        `Error uploading file: ${error?.message || error}`
+      )
+      loading = false
     }
   }
 

packages/frontend-core/src/api/attachments.js

@@ -1,4 +1,20 @@
-export const buildAttachmentEndpoints = API => ({
+export const buildAttachmentEndpoints = API => {
+  /**
+   * Generates a signed URL to upload a file to an external datasource.
+   * @param datasourceId the ID of the datasource to upload to
+   * @param bucket the name of the bucket to upload to
+   * @param key the name of the file to upload to
+   */
+  const getSignedDatasourceURL = async ({ datasourceId, bucket, key }) => {
+    return await API.post({
+      url: `/api/attachments/${datasourceId}/url`,
+      body: { bucket, key },
+    })
+  }
+
+  return {
+    getSignedDatasourceURL,
+
     /**
      * Uploads an attachment to the server.
      * @param data the attachment to upload
@@ -24,19 +40,6 @@ export const buildAttachmentEndpoints = API => ({
       })
     },
 
-  /**
-   * Generates a signed URL to upload a file to an external datasource.
-   * @param datasourceId the ID of the datasource to upload to
-   * @param bucket the name of the bucket to upload to
-   * @param key the name of the file to upload to
-   */
-  getSignedDatasourceURL: async ({ datasourceId, bucket, key }) => {
-    return await API.post({
-      url: `/api/attachments/${datasourceId}/url`,
-      body: { bucket, key },
-    })
-  },
-
     /**
      * Uploads a file to an external datasource.
      * @param datasourceId the ID of the datasource to upload to
@@ -45,7 +48,8 @@ export const buildAttachmentEndpoints = API => ({
      * @param data the file to upload
      */
     externalUpload: async ({ datasourceId, bucket, key, data }) => {
-    const { signedUrl, publicUrl } = await API.getSignedDatasourceURL({
+      console.log(API)
+      const { signedUrl, publicUrl } = await getSignedDatasourceURL({
         datasourceId,
         bucket,
         key,
@@ -58,4 +62,5 @@ export const buildAttachmentEndpoints = API => ({
       })
       return { publicUrl }
     },
-})
+  }
+}