CodeMirror/budibase
1
0
Fork 0
mirror of synced 2024-07-03 13:30:46 +12:00
Code Issues Projects Releases Wiki Activity

Improve grid handling of API errors which don't have the normal JSON validation error shape

Browse source
This commit is contained in:
Andrew Kingston 2024-04-26 13:19:11 +01:00
parent 9a03729e49
commit 5716b232eb
1 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
packages/frontend-core/src/components/grid/stores/rows.js
View file

@ -196,6 +196,20 @@ export const createActions = context => {
// Handles validation errors from the rows API and updates local validation
// state, storing error messages against relevant cells
const handleValidationError = (rowId, error) => {
// If the server doesn't reply with a valid error, assume that the source
// of the error is the focused cell's column
if (!error?.json?.validationErrors && error?.message) {
const focusedColumn = get(focusedCellId)?.split("-")[1]
if (focusedColumn) {
error = {
json: {
validationErrors: {
[focusedColumn]: error.message,
},
},
}
}
}
if (error?.json?.validationErrors) {
// Normal validation errors
const keys = Object.keys(error.json.validationErrors)
@ -214,11 +228,19 @@ export const createActions = context => {
// Process errors for columns that we have
for (let column of erroredColumns) {
// Ensure we have a valid error to display
let err = error.json.validationErrors[column]
if (Array.isArray(err)) {
err = err[0]
}
if (typeof err !== "string" || !err.length) {
error = "Something went wrong"
}
// Set error against the cell
validation.actions.setError(
`${rowId}-${column}`,
`${column} ${error.json.validationErrors[column]}`
Helpers.capitalise(err)
)
// Ensure the column is visible
const index = $columns.findIndex(x => x.name === column)
if (index !== -1 && !$columns[index].visible) {