CodeMirror/budibase
1
0
Fork 0
mirror of synced 2024-09-10 22:46:09 +12:00
Code Issues Projects Releases Wiki Activity

Reduce state updates when selecting layouts

Browse source
This commit is contained in:
Andrew Kingston 2022-07-14 16:24:16 +01:00
parent 99c3323390
commit 56b255cfc9
2 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
packages/builder/src/builderStore/store/frontend.js
View file

@ -331,10 +331,23 @@ export const getFrontendStore = () => {
}, },
layouts: { layouts: {
select: layoutId => { select: layoutId => {
// Check this layout exists
const state = get(store)
const layout = store.actions.layouts.find(layoutId)
if (!layout) {
return
}
// Check layout isn't already selected
if (
state.selectedLayoutId === layout._id &&
state.selectedComponentId === layout.props?._id
) {
return
}
// Select new layout
store.update(state => { store.update(state => {
const layout =
store.actions.layouts.find(layoutId) || get(store).layouts[0]
if (!layout) return
state.selectedLayoutId = layout._id state.selectedLayoutId = layout._id
state.selectedComponentId = layout.props?._id state.selectedComponentId = layout.props?._id
return state return state

2
packages/builder/src/pages/builder/app/[application]/design/[screenId]/layouts/[layoutId]/_components/LayoutListPanel.svelte
View file

@ -13,7 +13,7 @@
indentLevel={0} indentLevel={0}
selected={$store.selectedLayoutId === layout._id} selected={$store.selectedLayoutId === layout._id}
text={layout.name} text={layout.name}
on:click={() => ($store.selectedLayoutId = layout._id)} on:click={() => store.actions.layouts.select(layout._id)}
> >
<LayoutDropdownMenu {layout} /> <LayoutDropdownMenu {layout} />
</NavItem> </NavItem>