CodeMirror/budibase
1
0
Fork 0
mirror of synced 2024-09-29 16:51:33 +13:00
Code Issues Projects Releases Wiki Activity

Fix for field modal infinite render loop once closed from click away (#42)

Browse source
This commit is contained in:
Conor_Mack 2019-12-04 22:13:06 +00:00 committed by Michael Shanks
parent 494d93b46b
commit 54ddb9415a
2 changed files with 42 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/builder/src/common/Modal.svelte
View file

@ -11,7 +11,7 @@ let listenerAdded = false;
$: { $: {
if(ukModal && !listenerAdded) { if(ukModal && !listenerAdded) {
listenerAdded = true; listenerAdded = true;
ukModal.addEventListener("hide", onClosed); ukModal.addEventListener("hidden", onClosed);
} }
if(ukModal) { if(ukModal) {

3
packages/builder/src/database/RecordView.svelte
View file

@ -39,6 +39,7 @@ store.subscribe($store => {
editingField = true; editingField = true;
} }
onFinishedFieldEdit = (field) => { onFinishedFieldEdit = (field) => {
if(field) { if(field) {
store.saveField(field); store.saveField(field);
@ -139,7 +140,7 @@ const nameChanged = ev => {
{/if} {/if}
{#if editingField} {#if editingField}
<Modal bind:isOpen={editingField}> <Modal bind:isOpen={editingField} onClosed={() => onFinishedFieldEdit(false) }>
<FieldView field={fieldToEdit} <FieldView field={fieldToEdit}
onFinished={onFinishedFieldEdit} onFinished={onFinishedFieldEdit}
allFields={record.fields} allFields={record.fields}