From 4ac9b657e506a494f9ce5ba401f95ca662387cb3 Mon Sep 17 00:00:00 2001
From: melohagan <101575380+melohagan@users.noreply.github.com>
Date: Tue, 25 Jun 2024 08:26:52 +0100
Subject: [PATCH] Remove deprecated properties (#13958)

* Remove deprecated properties

* Fix backend-core test

* Don't run account-portal tests

* Update account-portal ref

* Run account portal unit tests

* Revert "Run account portal unit tests"

This reverts commit b509bf31a493890c7fe7773d531660e5cb2482b3.

* Revert "Update account-portal ref"

This reverts commit 186391fbb6fa0b7d9ff1641b0187c565b4a1370a.
---
 .github/workflows/budibase_ci.yml                             | 4 ++--
 .../backend-core/tests/core/utilities/structures/accounts.ts  | 1 -
 packages/types/src/documents/account/account.ts               | 3 ---
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/budibase_ci.yml b/.github/workflows/budibase_ci.yml
index b7dbcae771..64eadef072 100644
--- a/.github/workflows/budibase_ci.yml
+++ b/.github/workflows/budibase_ci.yml
@@ -117,9 +117,9 @@ jobs:
       - name: Test
         run: |
           if ${{ env.USE_NX_AFFECTED }}; then
-            yarn test --ignore=@budibase/worker --ignore=@budibase/server --since=${{ env.NX_BASE_BRANCH }}
+            yarn test --ignore=@budibase/worker --ignore=@budibase/server --since=${{ env.NX_BASE_BRANCH }} --ignore=@budibase/account-portal-ui --ignore @budibase/account-portal-server
           else
-            yarn test --ignore=@budibase/worker --ignore=@budibase/server
+            yarn test --ignore=@budibase/worker --ignore=@budibase/server --ignore=@budibase/account-portal-ui --ignore @budibase/account-portal-server
           fi
 
   test-worker:
diff --git a/packages/backend-core/tests/core/utilities/structures/accounts.ts b/packages/backend-core/tests/core/utilities/structures/accounts.ts
index 7dcc2de116..29453ad60a 100644
--- a/packages/backend-core/tests/core/utilities/structures/accounts.ts
+++ b/packages/backend-core/tests/core/utilities/structures/accounts.ts
@@ -24,7 +24,6 @@ export const account = (partial: Partial<Account> = {}): Account => {
     createdAt: Date.now(),
     verified: true,
     verificationSent: true,
-    tier: "FREE", // DEPRECATED
     authType: AuthType.PASSWORD,
     name: generator.name(),
     size: "10+",
diff --git a/packages/types/src/documents/account/account.ts b/packages/types/src/documents/account/account.ts
index 239d845722..61792a7f47 100644
--- a/packages/types/src/documents/account/account.ts
+++ b/packages/types/src/documents/account/account.ts
@@ -42,10 +42,7 @@ export interface Account extends CreateAccount {
   verified: boolean
   verificationSent: boolean
   // licensing
-  tier: string // deprecated
   planType?: PlanType
-  /** @deprecated */
-  planTier?: number
   license?: License
   installId?: string
   installTenantId?: string