From 4a5d1b97c898d59c943bd6c477be807e0c5e5029 Mon Sep 17 00:00:00 2001
From: Peter Clement <peter@budibase.com>
Date: Mon, 5 Sep 2022 14:39:19 +0100
Subject: [PATCH] improve responsiveness of plugins ui

---
 .../plugins/_components/PluginRow.svelte      | 27 +++++++++++++------
 packages/server/src/api/controllers/plugin.ts |  2 +-
 2 files changed, 20 insertions(+), 9 deletions(-)
diff --git a/packages/builder/src/pages/builder/portal/manage/plugins/_components/PluginRow.svelte b/packages/builder/src/pages/builder/portal/manage/plugins/_components/PluginRow.svelte
index 30fddb2f76..848611c248 100644
--- a/packages/builder/src/pages/builder/portal/manage/plugins/_components/PluginRow.svelte
+++ b/packages/builder/src/pages/builder/portal/manage/plugins/_components/PluginRow.svelte
@@ -12,6 +12,11 @@
   export let plugin
   export let deletePlugin
 
+  let icon =
+    plugin.schema.type === "component"
+      ? plugin.schema.schema.icon || "Book"
+      : plugin.schema.schema.icon || "Beaker"
+
   let detailsModal
 </script>
 
@@ -19,7 +24,7 @@
   <div class="title">
     <div class="name">
       <div>
-        <Icon size="M" name={plugin.schema.schema.icon} />
+        <Icon size="M" name={icon} />
       </div>
       <div>
         <Body
@@ -44,11 +49,17 @@
 
 <Modal bind:this={detailsModal}>
   <ModalContent
+    size="M"
     title="Plugin details"
     showConfirmButton={false}
     showCancelButton={false}
   >
-    <div class="form-row">
+    <div class="details-row">
+      <Label size="M">Name</Label>
+      <Input disabled value={plugin.name} />
+    </div>
+
+    <div class="details-row">
       <Label size="M">Type</Label>
       <Input
         disabled
@@ -56,19 +67,19 @@
           plugin.schema.type.slice(1)}
       />
     </div>
-    <div class="form-row">
+    <div class="details-row">
       <Label size="M">Source</Label>
       <Input disabled value={plugin.source} />
     </div>
-    <div class="form-row">
+    <div class="details-row">
       <Label size="M">Version</Label>
       <Input disabled value={plugin.version} />
     </div>
-    <div class="form-row">
+    <div class="details-row">
       <Label size="M">License</Label>
       <Input disabled value={plugin.package.license} />
     </div>
-    <div class="form-row">
+    <div class="details-row">
       <Label size="M">Author</Label>
       <Input disabled value={plugin.package.author || "N/A"} />
     </div>
@@ -88,7 +99,7 @@
 <style>
   .row {
     display: grid;
-    grid-template-columns: 0.3fr auto auto auto;
+    grid-template-columns: 35% auto auto auto;
     align-items: center;
     background: var(--background);
     height: 50px;
@@ -104,7 +115,7 @@
     display: flex;
   }
 
-  .form-row {
+  .details-row {
     display: grid;
     grid-template-columns: 60px 1fr;
     grid-gap: var(--spacing-l) var(--spacing-l);
diff --git a/packages/server/src/api/controllers/plugin.ts b/packages/server/src/api/controllers/plugin.ts
index 254a008781..eeae71b6f9 100644
--- a/packages/server/src/api/controllers/plugin.ts
+++ b/packages/server/src/api/controllers/plugin.ts
@@ -148,7 +148,7 @@ export async function storePlugin(
     // TODO: this isn't safe - but we need full node environment
     // in future we should do this in a thread for safety
     try {
-      eval(js)
+      //eval(js)
     } catch (err: any) {
       const message = err?.message ? err.message : JSON.stringify(err)
       throw new Error(`JS invalid: ${message}`)
