diff --git a/packages/builder/src/components/design/settings/componentSettings.js b/packages/builder/src/components/design/settings/componentSettings.js index 441993fe1c..1d8df7a052 100644 --- a/packages/builder/src/components/design/settings/componentSettings.js +++ b/packages/builder/src/components/design/settings/componentSettings.js @@ -19,6 +19,7 @@ import FormFieldSelect from "./controls/FormFieldSelect.svelte" import ValidationEditor from "./controls/ValidationEditor/ValidationEditor.svelte" import DrawerBindableCombobox from "components/common/bindings/DrawerBindableCombobox.svelte" import ColumnEditor from "./controls/ColumnEditor/ColumnEditor.svelte" +import BasicColumnEditor from "./controls/ColumnEditor/BasicColumnEditor.svelte" import BarButtonList from "./controls/BarButtonList.svelte" const componentMap = { @@ -42,6 +43,7 @@ const componentMap = { filter: FilterEditor, url: URLSelect, columns: ColumnEditor, + "columns/basic": BasicColumnEditor, "field/sortable": SortableFieldSelect, "field/string": FormFieldSelect, "field/number": FormFieldSelect, diff --git a/packages/builder/src/components/design/settings/controls/ColumnEditor/BasicColumnEditor.svelte b/packages/builder/src/components/design/settings/controls/ColumnEditor/BasicColumnEditor.svelte new file mode 100644 index 0000000000..053735cc6d --- /dev/null +++ b/packages/builder/src/components/design/settings/controls/ColumnEditor/BasicColumnEditor.svelte @@ -0,0 +1,10 @@ + + + diff --git a/packages/builder/src/components/design/settings/controls/ColumnEditor/ColumnDrawer.svelte b/packages/builder/src/components/design/settings/controls/ColumnEditor/ColumnDrawer.svelte index cf85b2506b..87fbba3b52 100644 --- a/packages/builder/src/components/design/settings/controls/ColumnEditor/ColumnDrawer.svelte +++ b/packages/builder/src/components/design/settings/controls/ColumnEditor/ColumnDrawer.svelte @@ -17,6 +17,7 @@ export let columns = [] export let options = [] export let schema = {} + export let allowCellEditing = true const flipDurationMs = 150 let dragDisabled = true @@ -123,7 +124,9 @@ on:change={e => (column.displayName = e.detail)} /> - + {#if allowCellEditing} + + {/if} Configure columns - + - Configure the columns in your table. + Configure the columns in your {subject.toLowerCase()}. - + diff --git a/packages/client/manifest.json b/packages/client/manifest.json index 980bd4585e..8ded099d80 100644 --- a/packages/client/manifest.json +++ b/packages/client/manifest.json @@ -3932,10 +3932,10 @@ "required": true }, { - "type": "multifield", - "label": "Allowed filter fields", + "type": "columns/basic", + "label": "Allowed filter columns", "key": "allowedFields", - "placeholder": "All fields" + "dependsOn": "dataProvider" }, { "type": "select", diff --git a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte index 141ce2e955..df06979f48 100644 --- a/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte +++ b/packages/client/src/components/app/dynamic-filter/DynamicFilter.svelte @@ -61,7 +61,10 @@ clonedSchema = schema } else { allowedFields?.forEach(field => { - if (schema[field]) { + if (schema[field.name]) { + clonedSchema[field.name] = schema[field.name] + clonedSchema[field.name].displayName = field.displayName + } else if (schema[field]) { clonedSchema[field] = schema[field] } }) diff --git a/packages/client/src/components/app/dynamic-filter/FilterModal.svelte b/packages/client/src/components/app/dynamic-filter/FilterModal.svelte index b8815279dd..8d89d3a6ff 100644 --- a/packages/client/src/components/app/dynamic-filter/FilterModal.svelte +++ b/packages/client/src/components/app/dynamic-filter/FilterModal.svelte @@ -25,7 +25,10 @@ !BannedTypes.includes(field.type) || (field.type === "formula" && field.formulaType === "static") ) - .map(field => field.name) + .map(field => ({ + label: field.displayName || field.name, + value: field.name, + })) const addFilter = () => { filters = [