From 402426a5f3b06ceb7cc78948135fc0fc0767351d Mon Sep 17 00:00:00 2001
From: Adria Navarro <adria@budibase.com>
Date: Thu, 23 May 2024 13:07:45 +0200
Subject: [PATCH] Validate time only field constrains

---
 packages/server/src/sdk/app/rows/utils.ts | 60 +++++++++++++++++++++--
 1 file changed, 56 insertions(+), 4 deletions(-)

diff --git a/packages/server/src/sdk/app/rows/utils.ts b/packages/server/src/sdk/app/rows/utils.ts
index 5456b81858..78f499f895 100644
--- a/packages/server/src/sdk/app/rows/utils.ts
+++ b/packages/server/src/sdk/app/rows/utils.ts
@@ -1,8 +1,10 @@
-import cloneDeep from "lodash/cloneDeep"
 import validateJs from "validate.js"
+import dayjs from "dayjs"
+import cloneDeep from "lodash/fp/cloneDeep"
 import {
   Datasource,
   DatasourcePlusQueryResponse,
+  FieldConstraints,
   FieldType,
   QueryJson,
   Row,
@@ -206,9 +208,7 @@ export async function validate({
         errors[fieldName] = [`Contains invalid JSON`]
       }
     } else if (type === FieldType.DATETIME && column.timeOnly) {
-      if (row[fieldName] && !row[fieldName].match(/^(\d+)(:[0-5]\d){1,2}$/)) {
-        errors[fieldName] = [`${fieldName} is not a valid time`]
-      }
+      res = validateTimeOnlyField(fieldName, row[fieldName], constraints)
     } else {
       res = validateJs.single(row[fieldName], constraints)
     }
@@ -216,3 +216,55 @@ export async function validate({
   }
   return { valid: Object.keys(errors).length === 0, errors }
 }
+
+function validateTimeOnlyField(
+  fieldName: string,
+  value: any,
+  constraints: FieldConstraints | undefined
+) {
+  let res
+  if (value && !value.match(/^(\d+)(:[0-5]\d){1,2}$/)) {
+    res = [`${fieldName} is not a valid time`]
+  }
+  if (constraints) {
+    let castedValue = value
+    const stringTimeToDateISOString = (value: string) => {
+      const [hour, minute] = value.split(":").map((x: string) => +x)
+      return dayjs().hour(hour).minute(minute).toISOString()
+    }
+
+    if (castedValue) {
+      castedValue = stringTimeToDateISOString(castedValue)
+    }
+    let castedConstraints = cloneDeep(constraints)
+    if (castedConstraints.datetime?.earliest) {
+      castedConstraints.datetime.earliest = stringTimeToDateISOString(
+        castedConstraints.datetime?.earliest
+      )
+    }
+    if (castedConstraints.datetime?.latest) {
+      castedConstraints.datetime.latest = stringTimeToDateISOString(
+        castedConstraints.datetime?.latest
+      )
+    }
+
+    let jsValidation = validateJs.single(castedValue, castedConstraints)
+    jsValidation = jsValidation?.map((m: string) =>
+      m
+        ?.replace(
+          castedConstraints.datetime?.earliest || "",
+          constraints.datetime?.earliest || ""
+        )
+        .replace(
+          castedConstraints.datetime?.latest || "",
+          constraints.datetime?.latest || ""
+        )
+    )
+    if (jsValidation) {
+      res ??= []
+      res.push(...jsValidation)
+    }
+  }
+
+  return res
+}