From 387723f9cfcaa5a5f3303a13708acf5ccda49c43 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Mon, 20 May 2024 11:05:53 +0100 Subject: [PATCH] Update click_outside handler to use a click even rather than mouseup for its second event to allow overriding --- packages/bbui/src/Actions/click_outside.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/bbui/src/Actions/click_outside.js b/packages/bbui/src/Actions/click_outside.js index 124f43ff04..526659cb7a 100644 --- a/packages/bbui/src/Actions/click_outside.js +++ b/packages/bbui/src/Actions/click_outside.js @@ -71,8 +71,8 @@ const handleMouseDown = e => { // Clear any previous listeners in case of multiple down events, and register // a single mouse up listener - document.removeEventListener("mouseup", handleMouseUp) - document.addEventListener("mouseup", handleMouseUp, true) + document.removeEventListener("click", handleMouseUp) + document.addEventListener("click", handleMouseUp, true) } // Global singleton listeners for our events