From 37ca0ee1d84f50a981b96d3421b693af666110cf Mon Sep 17 00:00:00 2001
From: kevmodrome <kevin@kevmodro.me>
Date: Wed, 22 Apr 2020 08:25:59 +0200
Subject: [PATCH] makes the Component panel tabs more generic

---
 .../ComponentSelectionList.svelte             | 32 ++++++++++------
 .../{ComponentTab => ItemTab}/Item.svelte     | 28 +++++++-------
 .../{ComponentTab => ItemTab}/Tab.svelte      | 25 +++++-------
 .../userInterface/temporaryPanelStructure.js  | 38 +++++++++----------
 4 files changed, 62 insertions(+), 61 deletions(-)
 rename packages/builder/src/components/userInterface/{ComponentTab => ItemTab}/Item.svelte (64%)
 rename packages/builder/src/components/userInterface/{ComponentTab => ItemTab}/Tab.svelte (53%)

diff --git a/packages/builder/src/components/userInterface/ComponentSelectionList.svelte b/packages/builder/src/components/userInterface/ComponentSelectionList.svelte
index 12159f675c..d769321de1 100644
--- a/packages/builder/src/components/userInterface/ComponentSelectionList.svelte
+++ b/packages/builder/src/components/userInterface/ComponentSelectionList.svelte
@@ -20,7 +20,7 @@
     pipe,
   } from "components/common/core"
 
-  import Tab from "./ComponentTab/Tab.svelte"
+  import Tab from "./ItemTab/Tab.svelte"
   import { store } from "builderStore"
 
   export let toggleTab
@@ -51,6 +51,15 @@
     selectTemplateDialog.show()
   }
 
+  const onComponentChosen = component => {
+    if (component.template) {
+      onTemplateChosen(component.template)
+    } else {
+      store.addChildComponent(component._component)
+      toggleTab()
+    }
+  }
+
   const onTemplateInstanceChosen = () => {
     selectedComponent = null
     const instance = templateInstances.find(
@@ -63,16 +72,13 @@
   $: templatesByComponent = groupBy(t => t.component)($store.templates)
   $: hierarchy = $store.hierarchy
   $: libraryModules = $store.libraries
-  $: standaloneTemplates = pipe(
-    templatesByComponent,
-    [
-      values,
-      flatten,
-      filter(t => !$store.components.some(c => c.name === t.component)),
-      map(t => ({ name: splitName(t.component).componentName, template: t })),
-      uniqBy(t => t.name),
-    ]
-  )
+  $: standaloneTemplates = pipe(templatesByComponent, [
+    values,
+    flatten,
+    filter(t => !$store.components.some(c => c.name === t.component)),
+    map(t => ({ name: splitName(t.component).componentName, template: t })),
+    uniqBy(t => t.name),
+  ])
 </script>
 
 <div class="root">
@@ -86,7 +92,9 @@
     {/each}
   </ul>
   <div class="panel">
-    <Tab list={selectedCategory} {onTemplateChosen} />
+    <Tab
+      list={selectedCategory}
+      on:selectItem={e => onComponentChosen(e.detail)} />
   </div>
 </div>
 
diff --git a/packages/builder/src/components/userInterface/ComponentTab/Item.svelte b/packages/builder/src/components/userInterface/ItemTab/Item.svelte
similarity index 64%
rename from packages/builder/src/components/userInterface/ComponentTab/Item.svelte
rename to packages/builder/src/components/userInterface/ItemTab/Item.svelte
index 5730df484c..23d978813f 100644
--- a/packages/builder/src/components/userInterface/ComponentTab/Item.svelte
+++ b/packages/builder/src/components/userInterface/ItemTab/Item.svelte
@@ -1,21 +1,21 @@
 <script>
-  export let component
+  export let item
 </script>
 
-<div class="component-item" on:click>
-  <div class="component-icon">
-    <i class={component.icon} />
+<div class="item-item" on:click>
+  <div class="item-icon">
+    <i class={item.icon} />
   </div>
-  <div class="component-text">
-    <div class="component-name">{component.name}</div>
-    <div class="component-description">
-      <p>{component.description}</p>
+  <div class="item-text">
+    <div class="item-name">{item.name}</div>
+    <div class="item-description">
+      <p>{item.description}</p>
     </div>
   </div>
 </div>
 
 <style>
-  .component-item {
+  .item-item {
     display: flex;
     flex-direction: row;
     padding: 10px 0px 8px 10px;
@@ -23,13 +23,13 @@
     cursor: pointer;
   }
 
-  .component-item:hover {
+  .item-item:hover {
     /* background: #f5f5f5; */
     background: #fbfbfb;
     border-radius: 5px;
   }
 
-  .component-icon {
+  .item-icon {
     flex: 0 0 40px;
     /* background: #efe9e9; */
     background: #f1f4fc;
@@ -40,19 +40,19 @@
     align-items: center;
   }
 
-  .component-text {
+  .item-text {
     display: flex;
     padding-left: 16px;
     padding-top: 8px;
     flex-direction: column;
   }
 
-  .component-name {
+  .item-name {
     font-size: 14px;
     font-weight: 500;
   }
 
-  .component-description {
+  .item-description {
     font-size: 12px;
     color: #808192;
   }
diff --git a/packages/builder/src/components/userInterface/ComponentTab/Tab.svelte b/packages/builder/src/components/userInterface/ItemTab/Tab.svelte
similarity index 53%
rename from packages/builder/src/components/userInterface/ComponentTab/Tab.svelte
rename to packages/builder/src/components/userInterface/ItemTab/Tab.svelte
index 3c4c7b7242..ee92c084a5 100644
--- a/packages/builder/src/components/userInterface/ComponentTab/Tab.svelte
+++ b/packages/builder/src/components/userInterface/ItemTab/Tab.svelte
@@ -1,24 +1,17 @@
 <script>
+  import { createEventDispatcher } from "svelte"
+  const dispatch = createEventDispatcher()
+
   import Item from "./Item.svelte"
   import { store } from "builderStore"
   export let list
-  export let onTemplateChosen
   let category = list
 
-  const onComponentChosen = component => {
-    if (component.template) {
-      onTemplateChosen(component.template)
+  const handleClick = item => {
+    if (item.children && item.children.length > 0) {
+      list = item
     } else {
-      store.addChildComponent(component._component)
-      toggleTab()
-    }
-  }
-
-  const handleClick = component => {
-    if (component.type && component.type.length > 0) {
-      list = component
-    } else {
-      onComponentChosen(component)
+      dispatch("selectItem", item)
     }
   }
 
@@ -31,8 +24,8 @@
   <button class="back-button" on:click={() => (list = category)}>Back</button>
 {/if}
 
-{#each list.type as component}
-  <Item {component} on:click={() => handleClick(component)} />
+{#each list.children as item}
+  <Item {item} on:click={() => handleClick(item)} />
 {/each}
 
 <style>
diff --git a/packages/builder/src/components/userInterface/temporaryPanelStructure.js b/packages/builder/src/components/userInterface/temporaryPanelStructure.js
index 51e95049b5..99c37e5ffb 100644
--- a/packages/builder/src/components/userInterface/temporaryPanelStructure.js
+++ b/packages/builder/src/components/userInterface/temporaryPanelStructure.js
@@ -3,20 +3,20 @@ export default {
     {
       name: 'Basic',
       isCategory: true,
-      type: [
+      children: [
         {
           name: 'Container',
           description: 'This component contains things within itself',
           icon: 'ri-layout-row-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Text',
           description: 'This is a simple text component',
           icon: 'ri-t-box-fill',
           commonProps: {},
-          type: [
+          children: [
             {
               _component: '@budibase/standard-components/heading',
               name: 'Headline',
@@ -45,102 +45,102 @@ export default {
           description: 'A basic html button that is ready for styling',
           icon: 'ri-radio-button-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Icon',
           description: 'A basic component for displaying icons',
           icon: 'ri-sun-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Avatar',
           description: 'A basic component for rendering an avatar',
           icon: 'ri-user-smile-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Link',
           description: 'A basic link component for internal and external links',
           icon: 'ri-link',
           commonProps: {},
-          type: []
+          children: []
         }
       ]
     },
     {
       name: 'Form',
       isCategory: true,
-      type: [
+      children: [
         {
           name: 'Button',
           description: 'A basic html button that is ready for styling',
           icon: 'ri-radio-button-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Icon',
           description: 'A basic component for displaying icons',
           icon: 'ri-sun-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Avatar',
           description: 'A basic component for rendering an avatar',
           icon: 'ri-user-smile-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Link',
           description: 'A basic link component for internal and external links',
           icon: 'ri-link',
           commonProps: {},
-          type: []
+          children: []
         }
       ]
     },
     {
       name: 'Blocks',
       isCategory: true,
-      type: [
+      children: [
         {
           name: 'Card',
           description: 'A basic card component that can contain content and actions.',
           icon: 'ri-layout-bottom-line',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Login',
           description: 'A component that automatically generates a login screen for your app.',
           icon: 'ri-login-box-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Navbar',
           description: 'A component for handling the navigation within your app.',
           icon: 'ri-navigation-fill',
           commonProps: {},
-          type: []
+          children: []
         }
       ]
     },
     {
       name: 'Data',
       isCategory: true,
-      type: [
+      children: [
         {
           name: 'Table',
           description: 'A component that generates a table from your data.',
           icon: 'ri-archive-drawer-fill',
           commonProps: {},
-          type: []
+          children: []
         },
         {
           name: 'Form',
@@ -153,7 +153,7 @@ export default {
             description: "Form for saving a record",
             name: "@budibase/materialdesign-components/recordForm",
           },
-          type: []
+          children: []
         }
       ]
     },