CodeMirror/budibase
1
0
Fork 0
mirror of synced 2024-09-09 22:16:26 +12:00
Code Issues Projects Releases Wiki Activity

Test limits

Browse source
This commit is contained in:
adrinr 2023-03-16 13:44:03 +01:00
parent 9a2eaaad42
commit 348b06948b
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/backend-core/src/db/lucene.ts
View file

@ -495,13 +495,15 @@ export class QueryBuilder<T> {
this.excludeDocs() this.excludeDocs()
let skipRemaining = skip let skipRemaining = skip
let iterationFetched = 0
do { do {
const toSkip = Math.min(QueryBuilder.maxLimit, skipRemaining) const toSkip = Math.min(QueryBuilder.maxLimit, skipRemaining)
this.setLimit(toSkip) this.setLimit(toSkip)
const { bookmark, rows } = await this.#execute() const { bookmark, rows } = await this.#execute()
this.setBookmark(bookmark) this.setBookmark(bookmark)
iterationFetched = rows.length
skipRemaining -= rows.length skipRemaining -= rows.length
} while (skipRemaining > 0) } while (skipRemaining > 0 && iterationFetched > 0)
this.#includeDocs = prevIncludeDocs this.#includeDocs = prevIncludeDocs
this.#limit = prevLimit this.#limit = prevLimit

11
packages/backend-core/src/db/tests/lucene.spec.ts
View file

@ -210,6 +210,17 @@ describe("lucene", () => {
docs.slice(skip, skip + resp.rows.length).map(expect.objectContaining) docs.slice(skip, skip + resp.rows.length).map(expect.objectContaining)
) )
}) })
it("should not return results if skipping all docs", async () => {
const builder = new QueryBuilder(skipDbName, INDEX_NAME)
// Skipping 2 max limits plus a little bit more
const skip = docs.length + 1
builder.setSkip(skip)
const resp = await builder.run()
expect(resp.rows.length).toBe(0)
})
}) })
}) })