From 312e7664142f4a8457f74d891a7f0a0603b3fa6b Mon Sep 17 00:00:00 2001 From: Pedro Silva Date: Thu, 20 Oct 2022 15:31:10 +0100 Subject: [PATCH] Improvement from PR comments --- packages/types/src/documents/app/table.ts | 4 ---- .../config/internal-api/TestConfiguration/rows.ts | 12 ++++++------ 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/types/src/documents/app/table.ts b/packages/types/src/documents/app/table.ts index 8d5e956495..12135b60cf 100644 --- a/packages/types/src/documents/app/table.ts +++ b/packages/types/src/documents/app/table.ts @@ -49,10 +49,6 @@ export interface Table extends Document { sourceId?: string relatedFormula?: string[] constrained?: string[] - _id?: string - _rev?: string - createdAt?: string - updatedAt?: string indexes?: { [key: string]: any } dataImport?: { [key: string]: any } } diff --git a/qa-core/src/config/internal-api/TestConfiguration/rows.ts b/qa-core/src/config/internal-api/TestConfiguration/rows.ts index a995e40e75..010c8936c1 100644 --- a/qa-core/src/config/internal-api/TestConfiguration/rows.ts +++ b/qa-core/src/config/internal-api/TestConfiguration/rows.ts @@ -9,19 +9,19 @@ export default class RowsApi { this.api = apiClient } - async getAll(id: string): Promise<[Response, Row[]]> { - const response = await this.api.get(`/${id}/rows`) + async getAll(tableId: string): Promise<[Response, Row[]]> { + const response = await this.api.get(`/${tableId}/rows`) const json = await response.json() return [response, json] } - async add(id: string, body: any): Promise<[Response, Row]> { - const response = await this.api.post(`/${id}/rows`, { body }) + async add(tableId: string, body: any): Promise<[Response, Row]> { + const response = await this.api.post(`/${tableId}/rows`, { body }) const json = await response.json() return [response, json] } - async delete(id: string, body: any): Promise<[Response, Row[]]> { - const response = await this.api.del(`/${id}/rows/`, { body }) + async delete(tableId: string, body: any): Promise<[Response, Row[]]> { + const response = await this.api.del(`/${tableId}/rows/`, { body }) const json = await response.json() return [response, json] }