From 2fed177f3c6565b4917686a3827e4de404ff0336 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Wed, 4 Aug 2021 14:46:21 +0100 Subject: [PATCH] Fix for #2250, strings were being parsed for numbers which was causing the issue for strings starting with numbers, using the table schema to determine is parsing necessary. --- packages/server/src/api/controllers/row/ExternalRequest.ts | 4 ++++ packages/server/src/integrations/base/sql.ts | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/server/src/api/controllers/row/ExternalRequest.ts b/packages/server/src/api/controllers/row/ExternalRequest.ts index c5fad441bf..92a3838f51 100644 --- a/packages/server/src/api/controllers/row/ExternalRequest.ts +++ b/packages/server/src/api/controllers/row/ExternalRequest.ts @@ -165,6 +165,10 @@ module External { if (!row[key] || newRow[key] || field.autocolumn) { continue } + // parse floats/numbers + if (field.type === FieldTypes.NUMBER && !isNaN(parseFloat(row[key]))) { + newRow[key] = parseFloat(row[key]) + } // if its not a link then just copy it over if (field.type !== FieldTypes.LINK) { newRow[key] = row[key] diff --git a/packages/server/src/integrations/base/sql.ts b/packages/server/src/integrations/base/sql.ts index 66dd269412..ea48eab793 100644 --- a/packages/server/src/integrations/base/sql.ts +++ b/packages/server/src/integrations/base/sql.ts @@ -19,8 +19,6 @@ function parseBody(body: any) { } if (isIsoDateString(value)) { body[key] = new Date(value) - } else if (!isNaN(parseFloat(value))) { - body[key] = parseFloat(value) } } return body