Handling JSON types within relationships, they need to be parsed as well.

packages/server/src/api/controllers/row/utils/basic.ts

@@ -1,5 +1,5 @@
 // need to handle table name + field or just field, depending on if relationships used
-import { FieldSchema, FieldType, Row, Table } from "@budibase/types"
+import { FieldSchema, FieldType, Row, Table, JsonTypes } from "@budibase/types"
 import {
   helpers,
   PROTECTED_EXTERNAL_COLUMNS,
@@ -62,6 +62,22 @@ export function generateIdForRow(
   return generateRowIdField(idParts)
 }
 
+function fixJsonTypes(row: Row, table: Table) {
+  for (let [fieldName, schema] of Object.entries(table.schema)) {
+    if (JsonTypes.includes(schema.type) && typeof row[fieldName] === "string") {
+      try {
+        row[fieldName] = JSON.parse(row[fieldName])
+      } catch (err) {
+        if (!helpers.schema.isDeprecatedSingleUserColumn(schema)) {
+          // couldn't convert back to array, ignore
+          delete row[fieldName]
+        }
+      }
+    }
+  }
+  return row
+}
+
 export function basicProcessing({
   row,
   table,
@@ -136,12 +152,15 @@ export function basicProcessing({
         const sortField =
           relatedTable.primaryDisplay || relatedTable.primary![0]!
         thisRow[col] = (thisRow[col] as Row[])
-          .map(relatedRow => {
-            relatedRow._id = relatedRow._id
-              ? relatedRow._id
-              : generateIdForRow(relatedRow, relatedTable)
-            return relatedRow
-          })
+          .map(relatedRow =>
+            basicProcessing({
+              row: relatedRow,
+              table: relatedTable,
+              tables,
+              isLinked: false,
+              sqs,
+            })
+          )
           .sort((a, b) => {
             const aField = a?.[sortField],
               bField = b?.[sortField]
@@ -157,24 +176,5 @@ export function basicProcessing({
       }
     }
   }
-  return thisRow
-}
-
-export function fixArrayTypes(row: Row, table: Table) {
-  for (let [fieldName, schema] of Object.entries(table.schema)) {
-    if (
-      [FieldType.ARRAY, FieldType.BB_REFERENCE].includes(schema.type) &&
-      typeof row[fieldName] === "string"
-    ) {
-      try {
-        row[fieldName] = JSON.parse(row[fieldName])
-      } catch (err) {
-        if (!helpers.schema.isDeprecatedSingleUserColumn(schema)) {
-          // couldn't convert back to array, ignore
-          delete row[fieldName]
-        }
-      }
-    }
-  }
-  return row
+  return fixJsonTypes(thisRow, table)
 }

packages/server/src/api/controllers/row/utils/utils.ts

@@ -14,12 +14,7 @@ import {
   processFormulas,
 } from "../../../../utilities/rowProcessor"
 import { isKnexEmptyReadResponse } from "./sqlUtils"
-import {
-  basicProcessing,
-  generateIdForRow,
-  fixArrayTypes,
-  getInternalRowId,
-} from "./basic"
+import { basicProcessing, generateIdForRow, getInternalRowId } from "./basic"
 import sdk from "../../../../sdk"
 import { processStringSync } from "@budibase/string-templates"
 import validateJs from "validate.js"
@@ -149,16 +144,13 @@ export async function sqlOutputProcessing(
       rowId = generateIdForRow(row, table)
       row._id = rowId
     }
-    const thisRow = fixArrayTypes(
-      basicProcessing({
-        row,
-        table,
-        tables: Object.values(tables),
-        isLinked: false,
-        sqs: opts?.sqs,
-      }),
-      table
-    )
+    const thisRow = basicProcessing({
+      row,
+      table,
+      tables: Object.values(tables),
+      isLinked: false,
+      sqs: opts?.sqs,
+    })
     if (thisRow._id == null) {
       throw new Error("Unable to generate row ID for SQL rows")
     }

packages/server/src/sdk/app/rows/search/internal/sqs.ts

@@ -18,6 +18,7 @@ import {
 } from "@budibase/types"
 import {
   buildInternalRelationships,
+  fixJsonTypes,
   sqlOutputProcessing,
 } from "../../../../../api/controllers/row/utils"
 import sdk from "../../../../index"
@@ -182,11 +183,20 @@ function buildTableMap(tables: Table[]) {
   return tableMap
 }
 
-function reverseUserColumnMapping(rows: Row[]) {
+// table is only needed to handle relationships
+function reverseUserColumnMapping(rows: Row[], table?: Table) {
   const prefixLength = USER_COLUMN_PREFIX.length
   return rows.map(row => {
     const finalRow: Row = {}
     for (let key of Object.keys(row)) {
+      // handle relationships
+      if (
+        table?.schema[key]?.type === FieldType.LINK &&
+        typeof row[key] === "string"
+      ) {
+        // no table required, relationship rows don't contain relationships
+        row[key] = reverseUserColumnMapping(JSON.parse(row[key]))
+      }
       // it should be the first prefix
       const index = key.indexOf(USER_COLUMN_PREFIX)
       if (index !== -1) {
@@ -261,7 +271,7 @@ async function runSqlQuery(
   if (opts?.countTotalRows) {
     return processRowCountResponse(response)
   } else if (Array.isArray(response)) {
-    return reverseUserColumnMapping(response)
+    return reverseUserColumnMapping(response, json.meta.table)
   }
   return response
 }
@@ -368,17 +378,6 @@ export async function search(
       })
     )
 
-    // make sure relationships have columns reversed correctly
-    for (let columnName of Object.keys(table.schema)) {
-      if (table.schema[columnName].type !== FieldType.LINK) {
-        continue
-      }
-      // process the relationships (JSON generated by SQS)
-      for (let row of processed) {
-        row[columnName] = reverseUserColumnMapping(row[columnName])
-      }
-    }
-
     // check for pagination final row
     let nextRow: boolean = false
     if (paginate && params.limit && rows.length > params.limit) {