From 2a0cfc949d183ab2605a2238c046477eb9b14cd6 Mon Sep 17 00:00:00 2001
From: mike12345567 <me@michaeldrury.co.uk>
Date: Wed, 23 Jun 2021 20:11:05 +0100
Subject: [PATCH] Fixing issue with automation webhook URL being undefined.

---
 .../Shared/CreateWebhookModal.svelte          | 12 +++---
 .../automation/Shared/WebhookDisplay.svelte   |  3 ++
 .../server/src/api/controllers/automation.js  | 37 ++++++++++++-------
 3 files changed, 33 insertions(+), 19 deletions(-)

diff --git a/packages/builder/src/components/automation/Shared/CreateWebhookModal.svelte b/packages/builder/src/components/automation/Shared/CreateWebhookModal.svelte
index 44e91efd50..04656c1e2e 100644
--- a/packages/builder/src/components/automation/Shared/CreateWebhookModal.svelte
+++ b/packages/builder/src/components/automation/Shared/CreateWebhookModal.svelte
@@ -16,11 +16,13 @@
   $: automation = $automationStore.selectedAutomation?.automation
 
   onMount(async () => {
-    // save the automation initially
-    await automationStore.actions.save({
-      instanceId,
-      automation,
-    })
+    if (!automation?.definition?.trigger?.inputs.schemaUrl) {
+      // save the automation initially
+      await automationStore.actions.save({
+        instanceId,
+        automation,
+      })
+    }
     interval = setInterval(async () => {
       await automationStore.actions.fetch()
       const outputs = automation?.definition?.trigger.schema.outputs?.properties
diff --git a/packages/builder/src/components/automation/Shared/WebhookDisplay.svelte b/packages/builder/src/components/automation/Shared/WebhookDisplay.svelte
index e1f2fe78d8..fc5e20f241 100644
--- a/packages/builder/src/components/automation/Shared/WebhookDisplay.svelte
+++ b/packages/builder/src/components/automation/Shared/WebhookDisplay.svelte
@@ -9,6 +9,9 @@
   $: appUrl = $hostingStore.appUrl
 
   function fullWebhookURL(uri) {
+    if (!uri) {
+      return ""
+    }
     if (production) {
       return `${appUrl}/${uri}`
     } else {
diff --git a/packages/server/src/api/controllers/automation.js b/packages/server/src/api/controllers/automation.js
index e1e721b347..2d164b415d 100644
--- a/packages/server/src/api/controllers/automation.js
+++ b/packages/server/src/api/controllers/automation.js
@@ -88,6 +88,8 @@ async function checkForCronTriggers({ appId, oldAuto, newAuto }) {
 async function checkForWebhooks({ appId, oldAuto, newAuto }) {
   const oldTrigger = oldAuto ? oldAuto.definition.trigger : null
   const newTrigger = newAuto ? newAuto.definition.trigger : null
+  const triggerChanged =
+    oldTrigger && newTrigger && oldTrigger.id !== newTrigger.id
   function isWebhookTrigger(auto) {
     return (
       auto &&
@@ -98,25 +100,32 @@ async function checkForWebhooks({ appId, oldAuto, newAuto }) {
   // need to delete webhook
   if (
     isWebhookTrigger(oldAuto) &&
-    !isWebhookTrigger(newAuto) &&
+    (!isWebhookTrigger(newAuto) || triggerChanged) &&
     oldTrigger.webhookId
   ) {
-    let db = new CouchDB(appId)
-    // need to get the webhook to get the rev
-    const webhook = await db.get(oldTrigger.webhookId)
-    const ctx = {
-      appId,
-      params: { id: webhook._id, rev: webhook._rev },
+    try {
+      let db = new CouchDB(appId)
+      // need to get the webhook to get the rev
+      const webhook = await db.get(oldTrigger.webhookId)
+      const ctx = {
+        appId,
+        params: { id: webhook._id, rev: webhook._rev },
+      }
+      // might be updating - reset the inputs to remove the URLs
+      if (newTrigger) {
+        delete newTrigger.webhookId
+        newTrigger.inputs = {}
+      }
+      await webhooks.destroy(ctx)
+    } catch (err) {
+      // don't worry about not being able to delete, if it doesn't exist all good
     }
-    // might be updating - reset the inputs to remove the URLs
-    if (newTrigger) {
-      delete newTrigger.webhookId
-      newTrigger.inputs = {}
-    }
-    await webhooks.destroy(ctx)
   }
   // need to create webhook
-  else if (!isWebhookTrigger(oldAuto) && isWebhookTrigger(newAuto)) {
+  if (
+    (!isWebhookTrigger(oldAuto) || triggerChanged) &&
+    isWebhookTrigger(newAuto)
+  ) {
     const ctx = {
       appId,
       request: {