diff --git a/packages/builder/src/components/backend/DataTable/ExternalDataSourceTable.svelte b/packages/builder/src/components/backend/DataTable/ExternalDataSourceTable.svelte index e0f429cb3b..071f0fe393 100644 --- a/packages/builder/src/components/backend/DataTable/ExternalDataSourceTable.svelte +++ b/packages/builder/src/components/backend/DataTable/ExternalDataSourceTable.svelte @@ -11,22 +11,22 @@ let loading = false let error = false - async function fetchData() { - try { - loading = true - const response = await api.fetchDataForQuery( - $params.selectedDatasource, - query._id - ) - data = response.rows || [] - error = false - } catch (err) { - error = `${query}: Query error. (${err.message}). This could be a problem with your datasource configuration.` - notifier.danger(error) - } finally { - loading = false - } - } + // async function fetchData() { + // try { + // loading = true + // const response = await api.fetchDataForQuery( + // $params.selectedDatasource, + // query._id + // ) + // data = response.rows || [] + // error = false + // } catch (err) { + // error = `${query}: Query error. (${err.message}). This could be a problem with your datasource configuration.` + // notifier.danger(error) + // } finally { + // loading = false + // } + // } // Fetch rows for specified query // $: query && fetchData() diff --git a/packages/builder/src/components/backend/DataTable/api.js b/packages/builder/src/components/backend/DataTable/api.js index 024a15bcdc..91ebc19b26 100644 --- a/packages/builder/src/components/backend/DataTable/api.js +++ b/packages/builder/src/components/backend/DataTable/api.js @@ -30,15 +30,3 @@ export async function fetchDataForView(view) { } return json } - -export async function fetchDataForQuery(datasourceId, queryId) { - const FETCH_QUERY_URL = `/api/queries/${queryId}` - - const response = await api.get(FETCH_QUERY_URL) - const json = await response.json() - - if (response.status !== 200) { - throw new Error(json.message) - } - return json -} diff --git a/packages/builder/src/components/userInterface/EventsEditor/actions/ExecuteQuery.svelte b/packages/builder/src/components/userInterface/EventsEditor/actions/ExecuteQuery.svelte index 910fa1e593..8ffdc4ef14 100644 --- a/packages/builder/src/components/userInterface/EventsEditor/actions/ExecuteQuery.svelte +++ b/packages/builder/src/components/userInterface/EventsEditor/actions/ExecuteQuery.svelte @@ -9,8 +9,7 @@ $: datasource = $backendUiStore.datasources.find( ds => ds._id === parameters.datasourceId ) - // TODO: binding needs a significant refactor and needs to - // be centralised + // TODO: binding needs to be centralised $: bindableProperties = fetchBindableProperties({ componentInstanceId: $store.selectedComponentId, components: $store.components, @@ -51,7 +50,6 @@ - {#if query}