From 1f107041a108aeaf677da20659819bfe2d06ec03 Mon Sep 17 00:00:00 2001
From: Peter Clement <peter@budibase.com>
Date: Wed, 6 Mar 2024 11:57:45 +0000
Subject: [PATCH] use vitest each

---
 .../shared-core/src/tests/filters.test.ts     | 23 +++++++------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/packages/shared-core/src/tests/filters.test.ts b/packages/shared-core/src/tests/filters.test.ts
index 1f8f534f0d..de969562af 100644
--- a/packages/shared-core/src/tests/filters.test.ts
+++ b/packages/shared-core/src/tests/filters.test.ts
@@ -209,16 +209,19 @@ describe("runLuceneQuery", () => {
     }
   )
 
-  it("should return matching results if allOr is true and only one filter matches", () => {
+  test.each([
+    [false, []],
+    [true, [1, 2, 3]],
+  ])("should return %s  if allOr is %s ", (allOr, expectedResult) => {
     const query = buildQuery({
-      allOr: true,
+      allOr,
       oneOf: { staff_id: [10] },
       contains: { description: ["box"] },
     })
 
-    expect(runLuceneQuery(docs, query).map(row => row.order_id)).toEqual([
-      1, 2, 3,
-    ])
+    expect(runLuceneQuery(docs, query).map(row => row.order_id)).toEqual(
+      expectedResult
+    )
   })
 
   it("should return matching results if allOr is true and only one filter matches with different operands", () => {
@@ -231,16 +234,6 @@ describe("runLuceneQuery", () => {
     expect(runLuceneQuery(docs, query).map(row => row.order_id)).toEqual([1, 2])
   })
 
-  it("should return nothing if allOr is false and only one filter matches", () => {
-    const query = buildQuery({
-      allOr: false,
-      oneOf: { staff_id: [10] },
-      contains: { description: ["box"] },
-    })
-
-    expect(runLuceneQuery(docs, query).map(row => row.order_id)).toEqual([])
-  })
-
   it("should handle when a value is null or undefined", () => {
     const query = buildQuery({
       allOr: true,