From 10764053df9c31d326141ddbdbfa468afbdb1676 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Fri, 22 Sep 2023 09:28:37 +0100 Subject: [PATCH 1/4] Remove form field default value settings from being updated by conditional UI --- .../Component/ConditionalUIDrawer.svelte | 10 +++--- .../Component/ConditionalUISection.svelte | 12 +------ packages/client/manifest.json | 36 ++++++++++++------- 3 files changed, 31 insertions(+), 27 deletions(-) diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ConditionalUIDrawer.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ConditionalUIDrawer.svelte index db6e66b87b..d21b4799a1 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ConditionalUIDrawer.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ConditionalUIDrawer.svelte @@ -61,10 +61,12 @@ key: "_css", type: "text", }) - $: settingOptions = settings.map(setting => ({ - label: makeLabel(setting), - value: setting.key, - })) + $: settingOptions = settings + .filter(setting => setting.supportsConditions !== false) + .map(setting => ({ + label: makeLabel(setting), + value: setting.key, + })) $: conditions.forEach(link => { if (!link.id) { link.id = generate() diff --git a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ConditionalUISection.svelte b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ConditionalUISection.svelte index fca81f7652..c32116c8a0 100644 --- a/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ConditionalUISection.svelte +++ b/packages/builder/src/pages/builder/app/[application]/design/[screenId]/[componentId]/_components/Component/ConditionalUISection.svelte @@ -36,10 +36,7 @@ -
{conditionText}
-
- Configure conditions -
+ {conditionText}
@@ -48,10 +45,3 @@ - - diff --git a/packages/client/manifest.json b/packages/client/manifest.json index 75fe287b2a..6788925c31 100644 --- a/packages/client/manifest.json +++ b/packages/client/manifest.json @@ -2539,7 +2539,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -2629,7 +2630,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -2685,7 +2687,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -2736,7 +2739,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -2841,7 +2845,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "boolean", @@ -2960,7 +2965,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -3143,7 +3149,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -3200,7 +3207,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -3301,7 +3309,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -3355,7 +3364,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "boolean", @@ -3622,7 +3632,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", @@ -3689,7 +3700,8 @@ { "type": "text", "label": "Default value", - "key": "defaultValue" + "key": "defaultValue", + "supportsConditions": false }, { "type": "event", From 799f62d218cc00684ad2fdf2d11e0f76090560d0 Mon Sep 17 00:00:00 2001 From: Budibase Staging Release Bot <> Date: Fri, 22 Sep 2023 15:10:23 +0000 Subject: [PATCH 2/4] Bump version to 2.10.12-alpha.5 --- lerna.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lerna.json b/lerna.json index 2db56a535e..124446321f 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "2.10.12-alpha.4", + "version": "2.10.12-alpha.5", "npmClient": "yarn", "packages": [ "packages/*" From f3309a742cd35cc71befa13c0ef2c622275999f0 Mon Sep 17 00:00:00 2001 From: melohagan <101575380+melohagan@users.noreply.github.com> Date: Mon, 25 Sep 2023 11:50:01 +0100 Subject: [PATCH 3/4] Add onChange to linked rows, longform text area, and multi select arrays in automations (#11874) * Add onChange to LinkedRowSelector * Add onChange to Multiselect array * Add onChange to TextArea * lint --- .../automation/SetupPanel/RowSelector.svelte | 5 ++--- .../automation/SetupPanel/RowSelectorTypes.svelte | 13 +++++++++++-- .../src/components/common/LinkedRowSelector.svelte | 9 ++++++++- 3 files changed, 21 insertions(+), 6 deletions(-) diff --git a/packages/builder/src/components/automation/SetupPanel/RowSelector.svelte b/packages/builder/src/components/automation/SetupPanel/RowSelector.svelte index 1080fc7305..5039c37ece 100644 --- a/packages/builder/src/components/automation/SetupPanel/RowSelector.svelte +++ b/packages/builder/src/components/automation/SetupPanel/RowSelector.svelte @@ -83,8 +83,7 @@ if (Array.isArray(value)) { return value } - - return [value] + return value.split(",").map(x => x.trim()) } if (type === "json") { @@ -146,7 +145,7 @@ placeholder={placeholders[schema.type]} panel={AutomationBindingPanel} value={Array.isArray(value[field]) - ? value[field].join(" ") + ? value[field].join(",") : value[field]} on:change={e => onChange(e, field, schema.type)} label={field} diff --git a/packages/builder/src/components/automation/SetupPanel/RowSelectorTypes.svelte b/packages/builder/src/components/automation/SetupPanel/RowSelectorTypes.svelte index 0e5e13ce1e..8ac9226fa0 100644 --- a/packages/builder/src/components/automation/SetupPanel/RowSelectorTypes.svelte +++ b/packages/builder/src/components/automation/SetupPanel/RowSelectorTypes.svelte @@ -55,9 +55,14 @@ bind:value={value[field]} label={field} options={schema.constraints.inclusion} + on:change={e => onChange(e, field)} /> {:else if schema.type === "longform"} -