From 1e4799ce9c113fca07ea4e9f77f05c616cb39a68 Mon Sep 17 00:00:00 2001 From: mike12345567 Date: Mon, 11 Oct 2021 17:59:44 +0100 Subject: [PATCH] Fixing an issue with env variables becoming numbers if they started with one. --- packages/server/src/environment.js | 7 ++++--- packages/worker/src/environment.js | 8 ++++++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/packages/server/src/environment.js b/packages/server/src/environment.js index e7bc35b04b..4044bb3787 100644 --- a/packages/server/src/environment.js +++ b/packages/server/src/environment.js @@ -74,9 +74,10 @@ module.exports = { }, } -// convert any strings to numbers if required, like "0" would be true otherwise +// clean up any environment variable edge cases for (let [key, value] of Object.entries(module.exports)) { - if (typeof value === "string" && !isNaN(parseInt(value))) { - module.exports[key] = parseInt(value) + // handle the edge case of "0" to disable an environment variable + if (value === "0") { + module.exports[key] = 0 } } diff --git a/packages/worker/src/environment.js b/packages/worker/src/environment.js index 74bd40314c..a1fab84112 100644 --- a/packages/worker/src/environment.js +++ b/packages/worker/src/environment.js @@ -52,3 +52,11 @@ module.exports = { return !isDev() }, } + +// clean up any environment variable edge cases +for (let [key, value] of Object.entries(module.exports)) { + // handle the edge case of "0" to disable an environment variable + if (value === "0") { + module.exports[key] = 0 + } +}