From 46244b72ac30bb9b0918614c863b90a3fd3c3d5c Mon Sep 17 00:00:00 2001 From: Peter Clement Date: Mon, 3 Jul 2023 11:50:57 +0100 Subject: [PATCH 1/2] Handle errors in grid when no validation structure in response --- packages/frontend-core/src/components/grid/stores/rows.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/frontend-core/src/components/grid/stores/rows.js b/packages/frontend-core/src/components/grid/stores/rows.js index 736863378f..0971b4cc18 100644 --- a/packages/frontend-core/src/components/grid/stores/rows.js +++ b/packages/frontend-core/src/components/grid/stores/rows.js @@ -246,6 +246,14 @@ export const deriveStores = context => { } } else { // Some other error - just update the current cell + if (get(focusedCellId)) { + validation.actions.setError( + get(focusedCellId), + error?.message || "Error" + ) + } else { + get(notifications).error(error?.message || "An unknown error occurred") + } validation.actions.setError(get(focusedCellId), error?.message || "Error") } } From c504ceca9de00741bcb767a6caf9bc6a6838060b Mon Sep 17 00:00:00 2001 From: Peter Clement Date: Mon, 3 Jul 2023 13:29:28 +0100 Subject: [PATCH 2/2] solely use notifications store for error message without rowId --- .../frontend-core/src/components/grid/stores/rows.js | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/frontend-core/src/components/grid/stores/rows.js b/packages/frontend-core/src/components/grid/stores/rows.js index 0971b4cc18..59d7c633d6 100644 --- a/packages/frontend-core/src/components/grid/stores/rows.js +++ b/packages/frontend-core/src/components/grid/stores/rows.js @@ -245,16 +245,7 @@ export const deriveStores = context => { focusedCellId.set(`${rowId}-${erroredColumns[0]}`) } } else { - // Some other error - just update the current cell - if (get(focusedCellId)) { - validation.actions.setError( - get(focusedCellId), - error?.message || "Error" - ) - } else { - get(notifications).error(error?.message || "An unknown error occurred") - } - validation.actions.setError(get(focusedCellId), error?.message || "Error") + get(notifications).error(error?.message || "An unknown error occurred") } }