From 1185756622b1828c85457bbbfca30318998dcae5 Mon Sep 17 00:00:00 2001 From: Andrew Kingston Date: Thu, 4 Feb 2021 18:11:56 +0000 Subject: [PATCH] Fix forms not providing correct datasource object --- packages/builder/src/builderStore/dataBinding.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/builder/src/builderStore/dataBinding.js b/packages/builder/src/builderStore/dataBinding.js index 838bfc3fce..c57099fe1c 100644 --- a/packages/builder/src/builderStore/dataBinding.js +++ b/packages/builder/src/builderStore/dataBinding.js @@ -69,8 +69,9 @@ export const getDatasourceForProvider = component => { } // Extract datasource from component instance + const validSettingTypes = ["datasource", "table", "schema"] const datasourceSetting = def.settings.find(setting => { - return setting.type === "datasource" || setting.type === "table" + return validSettingTypes.includes(setting.type) }) if (!datasourceSetting) { return null @@ -80,15 +81,14 @@ export const getDatasourceForProvider = component => { // example an actual datasource object, or a table ID string. // Convert the datasource setting into a proper datasource object so that // we can use it properly - if (datasourceSetting.type === "datasource") { - return component[datasourceSetting?.key] - } else if (datasourceSetting.type === "table") { + if (datasourceSetting.type === "table") { return { tableId: component[datasourceSetting?.key], type: "table", } + } else { + return component[datasourceSetting?.key] } - return null } /**