1
0
Fork 0
mirror of synced 2024-08-31 09:41:13 +12:00

Merge pull request #8935 from Budibase/fix/update-table-data-on-row-import

Force a re-initialisation of table data and paging when importing rows
This commit is contained in:
Martin McKeaveney 2022-12-05 18:29:57 +00:00 committed by GitHub
commit 116a997992
3 changed files with 9 additions and 3 deletions

View file

@ -117,6 +117,12 @@
const onUpdateRows = () => { const onUpdateRows = () => {
fetch.refresh() fetch.refresh()
} }
// When importing new rows it is better to reinitialise request/paging data.
// Not doing so causes inconsistency in paging behaviour and content.
const onImportData = () => {
fetch.getInitialData()
}
</script> </script>
<div> <div>
@ -169,7 +175,7 @@
<ImportButton <ImportButton
disabled={$tables.selected?._id === "ta_users"} disabled={$tables.selected?._id === "ta_users"}
tableId={$tables.selected?._id} tableId={$tables.selected?._id}
on:updaterows={onUpdateRows} on:importrows={onImportData}
/> />
<ExportButton <ExportButton
disabled={!hasRows || !hasCols} disabled={!hasRows || !hasCols}

View file

@ -12,5 +12,5 @@
Import Import
</ActionButton> </ActionButton>
<Modal bind:this={modal}> <Modal bind:this={modal}>
<ImportModal {tableId} on:updaterows /> <ImportModal {tableId} on:importrows />
</Modal> </Modal>

View file

@ -29,7 +29,7 @@
} }
// Always refresh rows just to be sure // Always refresh rows just to be sure
dispatch("updaterows") dispatch("importrows")
} }
</script> </script>