From 0b1bfdee6bb6b084e27b23c08876933ea7d69046 Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Tue, 17 Oct 2023 11:11:08 +0200 Subject: [PATCH] Remove sentry from the backend --- packages/server/src/app.ts | 8 -------- .../src/db/linkedRows/LinkController.ts | 4 +--- packages/server/src/koa.ts | 16 ++------------- packages/worker/src/index.ts | 20 ++----------------- 4 files changed, 5 insertions(+), 43 deletions(-) diff --git a/packages/server/src/app.ts b/packages/server/src/app.ts index c95dc0dcd1..66172b7bd0 100644 --- a/packages/server/src/app.ts +++ b/packages/server/src/app.ts @@ -1,11 +1,7 @@ -import * as Sentry from "@sentry/node" - if (process.env.DD_APM_ENABLED) { require("./ddApm") } -// need to load environment first -import env from "./environment" import * as db from "./db" db.init() import { ServiceType } from "@budibase/types" @@ -28,10 +24,6 @@ async function start() { } // startup includes automation runner - if enabled await startup(app, server) - if (env.isProd()) { - env._set("NODE_ENV", "production") - Sentry.init() - } } start().catch(err => { diff --git a/packages/server/src/db/linkedRows/LinkController.ts b/packages/server/src/db/linkedRows/LinkController.ts index c9ad7bc71f..7cd96f1cdc 100644 --- a/packages/server/src/db/linkedRows/LinkController.ts +++ b/packages/server/src/db/linkedRows/LinkController.ts @@ -1,6 +1,5 @@ import { IncludeDocs, getLinkDocuments } from "./linkUtils" import { InternalTables, getUserMetadataParams } from "../utils" -import Sentry from "@sentry/node" import { FieldTypes } from "../../constants" import { context } from "@budibase/backend-core" import LinkDocument from "./LinkDocument" @@ -434,8 +433,7 @@ class LinkController { await this._db.put(linkedTable) } } catch (err) { - /* istanbul ignore next */ - Sentry.captureException(err) + // Ignored error } } // need to get the full link docs to delete them diff --git a/packages/server/src/koa.ts b/packages/server/src/koa.ts index de11bf973a..fa5cf1d051 100644 --- a/packages/server/src/koa.ts +++ b/packages/server/src/koa.ts @@ -8,9 +8,8 @@ import * as automations from "./automations" import { Thread } from "./threads" import * as redis from "./utilities/redis" import { events, logging, middleware, timers } from "@budibase/backend-core" -const Sentry = require("@sentry/node") -const destroyable = require("server-destroy") -const { userAgent } = require("koa-useragent") +import destroyable from "server-destroy" +import { userAgent } from "koa-useragent" export default function createKoaApp() { const app = new Koa() @@ -36,17 +35,6 @@ export default function createKoaApp() { app.use(middleware.pino) app.use(userAgent) - if (env.isProd()) { - app.on("error", (err: any, ctx: ExtendableContext) => { - Sentry.withScope(function (scope: any) { - scope.addEventProcessor(function (event: any) { - return Sentry.Handlers.parseRequest(event, ctx.request) - }) - Sentry.captureException(err) - }) - }) - } - const server = http.createServer(app.callback()) destroyable(server) diff --git a/packages/worker/src/index.ts b/packages/worker/src/index.ts index 30596d1d76..3905a21c73 100644 --- a/packages/worker/src/index.ts +++ b/packages/worker/src/index.ts @@ -4,8 +4,6 @@ if (process.env.DD_APM_ENABLED) { // need to load environment first import env from "./environment" -import { Scope } from "@sentry/node" -import { Event } from "@sentry/types/dist/event" import Application from "koa" import { bootstrap } from "global-agent" import * as db from "./db" @@ -25,9 +23,9 @@ import koaBody from "koa-body" import http from "http" import api from "./api" import * as redis from "./utilities/redis" -const Sentry = require("@sentry/node") + const koaSession = require("koa-session") -const { userAgent } = require("koa-useragent") +import { userAgent } from "koa-useragent" import destroyable from "server-destroy" import { initPro } from "./initPro" @@ -66,20 +64,6 @@ app.use(auth.passport.session()) // api routes app.use(api.routes()) -// sentry -if (env.isProd()) { - Sentry.init() - - app.on("error", (err, ctx) => { - Sentry.withScope(function (scope: Scope) { - scope.addEventProcessor(function (event: Event) { - return Sentry.Handlers.parseRequest(event, ctx.request) - }) - Sentry.captureException(err) - }) - }) -} - const server = http.createServer(app.callback()) destroyable(server)