From a4e97f768bf2d39560265255cca5d7cf548b5e3b Mon Sep 17 00:00:00 2001 From: Adria Navarro Date: Mon, 8 May 2023 13:26:26 +0200 Subject: [PATCH] Add group name limit --- packages/pro | 2 +- .../api/routes/global/tests/groups.spec.ts | 25 +++++++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/packages/pro b/packages/pro index 124280d24f..3a6dba1a72 160000 --- a/packages/pro +++ b/packages/pro @@ -1 +1 @@ -Subproject commit 124280d24ff60446c166a005e3cc09c986565bb3 +Subproject commit 3a6dba1a7292384553900a284fa63422ee070bfa diff --git a/packages/worker/src/api/routes/global/tests/groups.spec.ts b/packages/worker/src/api/routes/global/tests/groups.spec.ts index 2dbf6edf30..5b7fb9db9e 100644 --- a/packages/worker/src/api/routes/global/tests/groups.spec.ts +++ b/packages/worker/src/api/routes/global/tests/groups.spec.ts @@ -57,6 +57,31 @@ describe("/api/global/groups", () => { expect.objectContaining({ name: "group name" }) ) }) + + describe("name max length", () => { + const maxLength = 50 + + it(`should allow names shorter than ${maxLength} characters`, async () => { + const group = { + ...structures.groups.UserGroup(), + name: structures.generator.word({ length: maxLength }), + } + await config.api.groups.saveGroup(group, { expect: 200 }) + }) + + it(`should not allow names longer than ${maxLength} characters`, async () => { + const group = { + ...structures.groups.UserGroup(), + name: structures.generator.word({ length: maxLength + 1 }), + } + const response = await config.api.groups.saveGroup(group, { + expect: 400, + }) + expect(JSON.parse(response.text).message).toEqual( + 'Invalid body - "name" length must be less than or equal to 50 characters long' + ) + }) + }) }) describe("update", () => {