From 828da8b4d705e6afdb516ac363f5da075d05d108 Mon Sep 17 00:00:00 2001 From: Rory Powell Date: Wed, 29 Sep 2021 13:51:33 +0100 Subject: [PATCH] Honour cookie domain on empty values --- packages/auth/src/utils.js | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/packages/auth/src/utils.js b/packages/auth/src/utils.js index f03ae300f7..93b483c6be 100644 --- a/packages/auth/src/utils.js +++ b/packages/auth/src/utils.js @@ -67,24 +67,22 @@ exports.getCookie = (ctx, name) => { * @param {string|object} value The value of cookie which will be set. */ exports.setCookie = (ctx, value, name = "builder") => { - if (!value) { - ctx.cookies.set(name) - } else { + if (value) { value = jwt.sign(value, options.secretOrKey) - - const config = { - maxAge: Number.MAX_SAFE_INTEGER, - path: "/", - httpOnly: false, - overwrite: true, - } - - if (environment.COOKIE_DOMAIN) { - config.domain = environment.COOKIE_DOMAIN - } - - ctx.cookies.set(name, value, config) } + + const config = { + maxAge: Number.MAX_SAFE_INTEGER, + path: "/", + httpOnly: false, + overwrite: true, + } + + if (environment.COOKIE_DOMAIN) { + config.domain = environment.COOKIE_DOMAIN + } + + ctx.cookies.set(name, value, config) } /**