Jos Dehaes
dcbdb7360d
[macos] fix temp sensor on system with many cores
2023-08-23 15:46:47 +02:00
aristocratos
c8ec6bbb00
Fix freebsd nullptr changes and makefile for gcc12 and newer
2023-08-03 23:08:33 +02:00
Jakob P. Liljenberg
8a33aab588
Merge pull request #539 from nobounce/replace-NULL-nullptr
...
Modernize using nullptr.
2023-07-30 13:21:48 +02:00
aristocratos
94e5c02d11
Better text editing
2023-07-27 20:51:21 +02:00
nobounce
e4abcefbf9
Use nullptr instead of NULL.
...
See https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2431.pdf
TLDR: NULL is of type int and relies on proper implicit pointer
conversion which may lead to issues when using overloaded functions
It is also considered a 'best practise' for modern C++ and
conveys the programmers intention more precisly.
2023-07-26 16:19:17 +02:00
aristocratos
aca2e4be75
Fix whitespace indent -> tab indent
2023-07-26 14:38:48 +02:00
aristocratos
33faa01910
Revert fmt submodule to static fmt folder in include
2023-07-26 14:34:15 +02:00
Jakob P. Liljenberg
ac17f34580
Merge pull request #560 from rrveex/main
...
FreeBSD swap info
2023-07-16 16:42:16 +02:00
zackiloco
6eb37601d7
Retrieve load average from libc and use emplace_back where appropriate
...
Get the load average from libc and adjust the internal API. This has
less overhead than opening /proc/loadavg.
Favor emplace_back over push_back, in general it has the chance to not
create a temporary object.
2023-07-05 13:23:11 +02:00
rr
8466bf3a18
FreeBSD swap info
2023-06-21 21:12:36 +03:00
Jakob P. Liljenberg
7e50b03e39
Merge pull request #510 from nobounce/LLVM
...
Support compiling with LLVM
2023-06-15 17:45:05 +02:00
Mitchell Dorrell
3c6929b025
Fix integer overflows in btop_collect.cpp
...
Correct data types in calls to std::accumulate(). The "bandwidth" deques
have type "long long", so the initial value of the accumulator (0) must
also be "long long" (i.e., "0ll") to prevent integer overflows. Also,
since since the bandwidth deques are (signed) "long long", the avg_speed
should presumably be a signed "long long" instead of an unsigned
"uint64_t". The previous behavior was for large bandwidth values to
overflow the accumulator, resulting in a negative total, which then was
cast to be a huge "uint64_t" value. As a consequence, the network graph
autoscaling was broken for large bandwidths.
2023-05-26 01:26:21 -04:00
zackiloco
a5e4969d7e
Remove pthread_exit().
...
Returning from the thread this way prevents local variables to be
destructed correctly since pthread_exit is marked noreturn.
This fixes a segmentation fault with glibc and llvm-libunwind on exit.
2023-05-25 23:00:07 +02:00
zackiloco
a2fa9da073
Replace statvfs64
with statvfs
and define _FILE_OFFSET_BITS=64
.
...
On my musl system statvfs64 is not exposed by default. The musl FAQ
recommends against using type64_t types, see:
https://wiki.musl-libc.org/faq.html#Q:-Do-I-need-to-define-%3Ccode%3E_LARGEFILE64_SOURCE%3C/code%3E-to-get-64bit-%3Ccode%3Eoff_t%3C/code%3E ?.
Defining `_FILE_OFFSET_BITS=64` and using type_t lets type_t use the 64
bit interface, see:
https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html#index-_005fFILE_005fOFFSET_005fBITS .
2023-05-25 23:00:07 +02:00
zackiloco
7dac8505c4
Include <codecvt> required by Clang.
2023-05-25 23:00:07 +02:00
zackiloco
34ae6d96d5
Move #include
to top level and exclude Clang from compiler version
...
check.
Clang cannot handle <semaphore> being included in a namespace, which is
also unadvised see:
https://softwareengineering.stackexchange.com/a/335261 .
Using the fallback <semaphore.h> is only meant for GCC 10, but Clang
defines `__GNUC__ = 4` so exclude Clang.
2023-05-25 23:00:07 +02:00
zackiloco
922b6475ae
Insert std::
for warning unqualified call to std::move
.
2023-05-25 23:00:07 +02:00
cpalv
1039bd5b5d
amend! update cpu load average display
...
update cpu load average display
applied suggested changes
2023-05-24 19:51:43 -05:00
cpalv
5d2f7420c3
update cpu load average display
2023-05-23 19:06:50 -05:00
aristocratos
b0fc63537b
println -> fmt::println
2023-05-21 12:26:48 +02:00
aristocratos
fbc349da2a
Readd using namespace fmt
2023-05-21 12:11:29 +02:00
aristocratos
bd688e24bf
Add fmt prefix for fmtlib
2023-05-21 11:58:52 +02:00
Steven Xu
7ca1cc533a
fix: prefix with fmt::
to fix ambiguous call to format()
, that also refers to /usr/include/c++/13.1.1/format
2023-05-21 19:33:44 +10:00
aristocratos
09c075e06c
Debug times thousand separator
2023-05-21 01:11:35 +02:00
aristocratos
e11d64e8d7
Debug times box changes
2023-05-20 15:20:27 +02:00
aristocratos
21b85f8913
btop.cpp -> fmt
2023-05-20 14:52:50 +02:00
Steffen
053bacef1d
Silence "warning: unqualified call to 'std::move'" in clang.
2023-03-07 13:16:04 +01:00
Jakob P. Liljenberg
3200de584f
Merge pull request #502 from mattico/linux-zfs-arc
...
Linux: subtract ZFS ARC min size from available memory
2023-02-23 18:49:01 +01:00
Matt Ickstadt
345bf7c052
Linux: subtract ZFS ARC min size from available memory
2023-02-23 10:59:10 -06:00
simplepad
2b18c6952d
fix zfs on freebsd not reporting IO
2022-12-21 21:45:25 +03:00
aristocratos
e67a35df08
Removed unused statement...
2022-11-30 23:18:04 +01:00
aristocratos
9aaffd6b26
Fixed: Use MemFree for used mem calculation if MemAvailable is greater than MemTotal.
2022-11-30 22:41:08 +01:00
aristocratos
0f8498fa4e
v1.2.13 Bug fixes
2022-11-06 22:36:34 +01:00
Jakob P. Liljenberg
9dc57534b1
Merge pull request #464 from correabuscar/osx_replace__getnameinfo__with__inet_ntop
...
osx: replace getnameinfo with inet_ntop
2022-11-06 15:24:30 +01:00
correabuscar
f4eea3f3cf
osx: replace getnameinfo with inet_ntop
...
this is like PR #462 for FreeBSD,
and like PR #458 for Linux.
2022-11-06 14:56:54 +01:00
correabuscar
7ff3c7f7d0
a comment about AF_LINK being ignored on purpose
2022-11-06 13:49:44 +01:00
Jakob P. Liljenberg
20df83658a
Merge pull request #462 from correabuscar/freebsd_replace__getnameinfo__with__inet_ntop
...
FreeBSD: replace getnameinfo with inet_ntop
2022-11-06 12:43:57 +01:00
correabuscar
12def527cd
FreeBSD: replace getnameinfo with inet_ntop
...
also make IPv6 work.
2022-11-06 12:04:38 +01:00
aristocratos
5a53fb4a2c
Fixed: Process nice value underflowing, issue #461
2022-11-06 11:32:17 +01:00
Jakob P. Liljenberg
f7dbf50b75
Merge pull request #459 from correabuscar/fbsd_use_first_IP_of_interface_instead_of_last
...
FreeBSD: use the first IP of the interface
2022-11-06 10:51:28 +01:00
correabuscar
bd7018ed96
OSX: use the first IP of the interface
...
...instead of the last.
Side effect of this is that it also detects when the current IP gets
removed from the interface, instead of keep displaying the old IP.
This is PR #457 but for OSX, not Linux.
2022-11-06 10:34:30 +01:00
correabuscar
16ce8d21b1
FreeBSD: use the first IP of the interface
...
... instead of the last.
Side effect of this is that it also detects when the current IP
gets removed from the interface, instead of keep displaying the old IP.
This is PR #457 but for FreeBSD, not Linux.
2022-11-06 08:23:30 +01:00
Jakob P. Liljenberg
a2685962d9
Merge pull request #446 from daephx/fix-conf-typo [skip actions]
...
fix: spelling mistake in btop.conf
2022-11-06 04:20:54 +01:00
aristocratos
68f7d1f4bb
Fixed: Not picking up last username from /etc/passwd
2022-11-05 22:56:52 +01:00
correabuscar
bad9bbc160
make IPBUFFER_MAXSIZE an enum constant
...
... instead of a macro constant(which made the code less readable!)
Supposedly it also doesn't use run-time storage.
2022-11-04 23:23:27 +01:00
correabuscar
96a22b4078
use inet_ntop instead of getnameinfo
...
saves 979 bytes of reserved buffer because:
NI_MAXHOST is 1025 bytes
and
INET6_ADDRSTRLEN is 46
Depends on PR #457 being merged first.
2022-11-04 23:23:27 +01:00
correabuscar
eec1999a8f
Show the first IP of the interface in NET box
...
... instead of the last.
Also, indented the `for` statement with tabs rather than spaces.
Closes #456
2022-11-04 01:45:09 +01:00
Arjun P
c1675634ef
Address comment
2022-10-31 21:42:34 +00:00
Arjun P
bb40de64c9
Fix bug in proc_tree view when showing full cmd
2022-10-30 09:27:56 +00:00
Arjun P
4fbda9df29
proc tree: fix width threshold to match commit message and use and/or instead of &&, ||
2022-10-29 00:20:11 +01:00