From 3e6a888c19fd54097ddb223245bf501df3750ef0 Mon Sep 17 00:00:00 2001 From: toriacx <153746540+toriacx@users.noreply.github.com> Date: Thu, 14 Dec 2023 19:11:01 +0200 Subject: [PATCH 1/3] Grammar updates of CONTRIBUTING.md Fixed some grammatical errors... Not too much to explain --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 03b0a3e..40a8d03 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -8,9 +8,9 @@ * Split up multiple unrelated changes in multiple pull requests. -* If it's a fix for a unreported bug, make a bug report and link the pull request. +* If it's a fix for an unreported bug, make a bug report and link the pull request. -* Purely cosmetic changes won't be accepted without a very good explanation of its value. +* Pure cosmetic changes won't be accepted without an excellent explanation of its value. ## Formatting @@ -26,7 +26,7 @@ ## General guidelines -* Don't force a programming style. Use object oriented, functional, data oriented, etc., where it's suitable. +* Don't force a programming style. Use object-oriented, functional, data-oriented, etc., where it's suitable. * Use [RAII](https://en.cppreference.com/w/cpp/language/raii). @@ -38,7 +38,7 @@ * Use descriptive names for variables. -* Use comments if not very obvious what your code is doing. +* Use comments if it is not very obvious what your code is doing. * Add comments as labels for what's currently happening in bigger sections of code for better readability. From 2cf5ef15f41f5cd5a754cb98147ab0367850e395 Mon Sep 17 00:00:00 2001 From: toriacx <153746540+toriacx@users.noreply.github.com> Date: Thu, 14 Dec 2023 19:52:17 +0200 Subject: [PATCH 2/3] Remove incorrect grammar corrections and add another vocabulary change --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 40a8d03..8cd7bd8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,7 +10,7 @@ * If it's a fix for an unreported bug, make a bug report and link the pull request. -* Pure cosmetic changes won't be accepted without an excellent explanation of its value. +* Pure cosmetic changes won't be accepted without a very good explanation of its value. ## Formatting @@ -48,6 +48,6 @@ * Benchmark your code and look for alternatives if they cause a noticeable negative impact. -For questions open a new discussion thread or send a mail to jakob@qvantnet.com +For questions open a new discussion thread or send an email to jakob@qvantnet.com For proposing changes to this document create a [new issue](https://github.com/aristocratos/btop/issues/new/choose). From f2a1679f6dd2f8d8e30d50a779a27bbbb6635d6b Mon Sep 17 00:00:00 2001 From: toriacx <153746540+toriacx@users.noreply.github.com> Date: Thu, 14 Dec 2023 19:52:17 +0200 Subject: [PATCH 3/3] Replaced incorrect grammar corrections and changed another vocabulary change Replaced: an excellent (my own mistake) -> a very good (original) Changed (vocabulary): a mail -> an email --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 40a8d03..8cd7bd8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -10,7 +10,7 @@ * If it's a fix for an unreported bug, make a bug report and link the pull request. -* Pure cosmetic changes won't be accepted without an excellent explanation of its value. +* Pure cosmetic changes won't be accepted without a very good explanation of its value. ## Formatting @@ -48,6 +48,6 @@ * Benchmark your code and look for alternatives if they cause a noticeable negative impact. -For questions open a new discussion thread or send a mail to jakob@qvantnet.com +For questions open a new discussion thread or send an email to jakob@qvantnet.com For proposing changes to this document create a [new issue](https://github.com/aristocratos/btop/issues/new/choose).