From b904097c6a3b6ae0fd133f0d5053aae682df678e Mon Sep 17 00:00:00 2001 From: Nathan Crapo Date: Sat, 6 Jan 2024 21:04:39 -0700 Subject: [PATCH 1/2] Add unresolved externs for rpi 32 build --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3f8c546..db6eb22 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -120,7 +120,7 @@ target_include_directories(btop SYSTEM PRIVATE include) # Enable pthreads set(THREADS_PREFER_PTHREAD_FLAG ON) find_package(Threads REQUIRED) -target_link_libraries(btop Threads::Threads) +target_link_libraries(btop Threads::Threads dl) # Enable GPU support if(LINUX AND BTOP_GPU) From e5a9728e235bf171330e3e336c91a1844d8acfd8 Mon Sep 17 00:00:00 2001 From: Nathan Crapo Date: Sun, 7 Jan 2024 15:11:53 -0700 Subject: [PATCH 2/2] dl* only needed with BTOP_GPU on Linux Moving the dl library to a LINUX && BTOP_GPU section so -ldl doesn't get included for non-Linux or non-GPU builds --- CMakeLists.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index db6eb22..439ff4c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -120,11 +120,12 @@ target_include_directories(btop SYSTEM PRIVATE include) # Enable pthreads set(THREADS_PREFER_PTHREAD_FLAG ON) find_package(Threads REQUIRED) -target_link_libraries(btop Threads::Threads dl) +target_link_libraries(btop Threads::Threads) # Enable GPU support if(LINUX AND BTOP_GPU) target_compile_definitions(btop PRIVATE GPU_SUPPORT) + target_link_libraries(btop dl) if(BTOP_RSMI_STATIC) # ROCm doesn't properly add it's folders to the module path if `CMAKE_MODULE_PATH` is already