From f26f2d9e9ba9509be29889226f83cd933fa5c0d7 Mon Sep 17 00:00:00 2001
From: Christy Jacob <christyjacob4@gmail.com>
Date: Tue, 9 Aug 2022 11:43:34 +0530
Subject: [PATCH] feat: review comments

---
 app/controllers/general.php | 52 +++++++++++++++++++------------------
 1 file changed, 27 insertions(+), 25 deletions(-)

diff --git a/app/controllers/general.php b/app/controllers/general.php
index c0ab47040a..a8d7fa545a 100644
--- a/app/controllers/general.php
+++ b/app/controllers/general.php
@@ -304,34 +304,36 @@ App::init()
 
                 if (time() > $key->getAttribute('accessedAt', 0) + APP_KEY_ACCCESS) {
                     $key->setAttribute('accessedAt', time());
-                    $sdkValidator = new WhiteList([
-                        'nodejs',
-                        'deno',
-                        'php',
-                        'python',
-                        'ruby',
-                        'go',
-                        'java',
-                        'dotnet',
-                        'dart',
-                        'kotlin',
-                        'swift'
-                    ], true);
-    
-                    $sdk = $request->getHeader('x-sdk-version', 'UNKNOWN');
-                    $sdk = explode(':', $sdk)[1] ?? '';
-
-                    if ($sdkValidator->isValid($sdk)) {
-                        $sdks = $key->getAttribute('sdks', []);
-                        if (!in_array($sdk, $sdks)) {
-                            array_push($sdks, $sdk); 
-                        }
-                        $key->setAttribute('sdks', $sdks);
-                    }
-
                     $dbForConsole->updateDocument('keys', $key->getId(), $key);
                     $dbForConsole->deleteCachedDocument('projects', $project->getId());
                 }
+
+                $sdkValidator = new WhiteList([
+                    'nodejs',
+                    'deno',
+                    'php',
+                    'python',
+                    'ruby',
+                    'go',
+                    'java',
+                    'dotnet',
+                    'dart',
+                    'kotlin',
+                    'swift'
+                ], true);
+
+                $sdk = $request->getHeader('x-sdk-version', 'UNKNOWN');
+                $sdk = explode(':', $sdk)[1] ?? '';
+
+                if ($sdkValidator->isValid($sdk)) {
+                    $sdks = $key->getAttribute('sdks', []);
+                    if (!in_array($sdk, $sdks)) {
+                        array_push($sdks, $sdk); 
+                        $key->setAttribute('sdks', $sdks);
+                        $dbForConsole->updateDocument('keys', $key->getId(), $key);
+                        $dbForConsole->deleteCachedDocument('projects', $project->getId());
+                    }
+                }
             }
         }