From c7c95633048924295776b7747a456bf64a7f8746 Mon Sep 17 00:00:00 2001
From: Eldad Fux <eldad.fux@gmail.com>
Date: Thu, 9 Jul 2020 12:10:27 +0300
Subject: [PATCH] Security attribute is now boolean

---
 app/config/collections.php             | 4 ++--
 app/views/console/tasks/index.phtml    | 6 +++---
 app/views/console/webhooks/index.phtml | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/app/config/collections.php b/app/config/collections.php
index 60f359c48..30fec5b07 100644
--- a/app/config/collections.php
+++ b/app/config/collections.php
@@ -634,7 +634,7 @@ $collections = [
                 '$collection' => Database::SYSTEM_COLLECTION_RULES,
                 'label' => 'Security',
                 'key' => 'security',
-                'type' => 'numeric',
+                'type' => 'boolean',
                 'default' => '',
                 'required' => false,
                 'array' => false,
@@ -777,7 +777,7 @@ $collections = [
                 '$collection' => Database::SYSTEM_COLLECTION_RULES,
                 'label' => 'Security',
                 'key' => 'security',
-                'type' => 'numeric',
+                'type' => 'boolean',
                 'default' => '',
                 'required' => false,
                 'array' => false,
diff --git a/app/views/console/tasks/index.phtml b/app/views/console/tasks/index.phtml
index 5380dcde6..0652850cc 100644
--- a/app/views/console/tasks/index.phtml
+++ b/app/views/console/tasks/index.phtml
@@ -37,7 +37,7 @@
                         <div class="margin-bottom-tiny text-one-liner">
                             <span data-ls-attrs="title={{task.name}} ({{task.failures}} errors)" data-ls-bind="{{task.name}}"></span>
 
-                            <span data-ls-if="0 === {{task.security}}">
+                            <span data-ls-if="false === {{task.security}}" data-debug="1">
                                 &nbsp; <span class="text-danger">SSL/TLS Disabled</span>
                             </span>
                             <span data-ls-if="0 !== {{task.failures}}">
@@ -172,8 +172,8 @@
                                     <label data-ls-attrs="for=security-{{task.$id}}" class="margin-bottom">
                                         <div class="margin-bottom-small text-bold">SSL / TLS (Certificate verification)</div>
                                         
-                                        <input name="security" type="radio" required data-ls-bind="{{task.security}}" value="1" /> &nbsp; <span>Enabled</span>
-                                        <input name="security" type="radio" required data-ls-bind="{{task.security}}" value="0" /> &nbsp; <span>Disabled</span>
+                                        <input name="security" type="radio" required data-ls-bind="{{task.security}}" value="true" data-cast-to="boolean" /> &nbsp; <span>Enabled</span>
+                                        <input name="security" type="radio" required data-ls-bind="{{task.security}}" value="false" data-cast-to="boolean" /> &nbsp; <span>Disabled</span>
                                     </label>
 
                                     <p class="margin-bottom text-size-small text-fade"><span class="text-red">Warning</span>: Untrusted or self-signed certificates may not be secure.
diff --git a/app/views/console/webhooks/index.phtml b/app/views/console/webhooks/index.phtml
index 66fa80dfa..6cf62b50a 100644
--- a/app/views/console/webhooks/index.phtml
+++ b/app/views/console/webhooks/index.phtml
@@ -85,8 +85,8 @@ $events = array_keys($this->getParam('events', []));
                             <label data-ls-attrs="for=security-{{task.$id}}" class="margin-bottom-small">
                                 <div class="margin-bottom-small text-bold">SSL / TLS (Certificate verification)</div>
                                         
-                                <input name="security" type="radio" required data-ls-attrs="id=secure-yes-{{webhook.$id}}" data-ls-bind="{{webhook.security}}" value="1" /> &nbsp; <span>Enabled</span> &nbsp;
-                                <input name="security" type="radio" required data-ls-attrs="id=secure-no-{{webhook.$id}}" data-ls-bind="{{webhook.security}}" value="0" /> &nbsp; <span>Disabled</span> &nbsp;
+                                <input name="security" type="radio" required data-ls-attrs="id=secure-yes-{{webhook.$id}}" data-ls-bind="{{webhook.security}}" value="true" data-cast-to="boolean" /> &nbsp; <span>Enabled</span> &nbsp;
+                                <input name="security" type="radio" required data-ls-attrs="id=secure-no-{{webhook.$id}}" data-ls-bind="{{webhook.security}}" value="false" data-cast-to="boolean" /> &nbsp; <span>Disabled</span> &nbsp;
                             </label>
 
                             <p class="margin-bottom text-size-small text-fade"><span class="text-red">Warning</span>: Untrusted or self-signed certificates may not be secure.
@@ -135,7 +135,7 @@ $events = array_keys($this->getParam('events', []));
                 </form>
 
                 <span data-ls-bind="{{webhook.name}}"></span> &nbsp; (<span data-ls-bind="{{webhook.events.length}}"></span> events)
-                <span data-ls-if="0 == {{webhook.security}}">
+                <span data-ls-if="false === {{webhook.security}}" data-debug="1">
                     &nbsp; <small class="text-danger">(SSL/TLS Disabled)</small>
                 </span>
                 <div class="margin-top-tiny">