1
0
Fork 0
mirror of synced 2024-09-29 17:01:37 +13:00

Bugs fixed

- Updated qrcode to v4.2
- Removed baconqrcode from composer
- Removed comments
- Fixed some indents
- Fixed the QR endpoint
This commit is contained in:
Pedro Cisneros Santana 2020-10-26 14:23:58 +01:00
parent f91a641032
commit bff0e4db58
2 changed files with 40 additions and 60 deletions

View file

@ -11,15 +11,10 @@ use Utopia\Cache\Cache;
use Utopia\Cache\Adapter\Filesystem; use Utopia\Cache\Adapter\Filesystem;
use Appwrite\Resize\Resize; use Appwrite\Resize\Resize;
use Appwrite\URL\URL as URLParse; use Appwrite\URL\URL as URLParse;
/* use BaconQrCode\Renderer\ImageRenderer;
use BaconQrCode\Renderer\Image\ImagickImageBackEnd;
use BaconQrCode\Renderer\RendererStyle\RendererStyle;
use BaconQrCode\Writer; */
use Utopia\Config\Config; use Utopia\Config\Config;
use Utopia\Validator\HexColor; use Utopia\Validator\HexColor;
use chillerlan\QRCode\QRCode; use chillerlan\QRCode\QRCode;
use chillerlan\QRCode\QROptions; use chillerlan\QRCode\QROptions;
/* use SebastianBergmann\CodeCoverage\Report\Html\Renderer; */
$avatarCallback = function ($type, $code, $width, $height, $quality, $response) { $avatarCallback = function ($type, $code, $width, $height, $quality, $response) {
/** @var Utopia\Response $response */ /** @var Utopia\Response $response */
@ -60,8 +55,7 @@ $avatarCallback = function ($type, $code, $width, $height, $quality, $response)
->setContentType('image/png') ->setContentType('image/png')
->addHeader('Expires', $date) ->addHeader('Expires', $date)
->addHeader('X-Appwrite-Cache', 'hit') ->addHeader('X-Appwrite-Cache', 'hit')
->send($data) ->send($data);
;
} }
$resize = new Resize(\file_get_contents($path)); $resize = new Resize(\file_get_contents($path));
@ -78,8 +72,7 @@ $avatarCallback = function ($type, $code, $width, $height, $quality, $response)
->setContentType('image/png') ->setContentType('image/png')
->addHeader('Expires', $date) ->addHeader('Expires', $date)
->addHeader('X-Appwrite-Cache', 'miss') ->addHeader('X-Appwrite-Cache', 'miss')
->send($data, null); ->send($data, null);;
;
unset($resize); unset($resize);
}; };
@ -163,8 +156,7 @@ App::get('/v1/avatars/image')
->setContentType('image/png') ->setContentType('image/png')
->addHeader('Expires', $date) ->addHeader('Expires', $date)
->addHeader('X-Appwrite-Cache', 'hit') ->addHeader('X-Appwrite-Cache', 'hit')
->send($data) ->send($data);
;
} }
if (!\extension_loaded('imagick')) { if (!\extension_loaded('imagick')) {
@ -195,8 +187,7 @@ App::get('/v1/avatars/image')
->setContentType('image/png') ->setContentType('image/png')
->addHeader('Expires', $date) ->addHeader('Expires', $date)
->addHeader('X-Appwrite-Cache', 'miss') ->addHeader('X-Appwrite-Cache', 'miss')
->send($data); ->send($data);;
;
unset($resize); unset($resize);
}, ['response']); }, ['response']);
@ -229,8 +220,7 @@ App::get('/v1/avatars/favicon')
->setContentType('image/png') ->setContentType('image/png')
->addHeader('Expires', $date) ->addHeader('Expires', $date)
->addHeader('X-Appwrite-Cache', 'hit') ->addHeader('X-Appwrite-Cache', 'hit')
->send($data) ->send($data);
;
} }
if (!\extension_loaded('imagick')) { if (!\extension_loaded('imagick')) {
@ -244,7 +234,8 @@ App::get('/v1/avatars/favicon')
CURLOPT_FOLLOWLOCATION => true, CURLOPT_FOLLOWLOCATION => true,
CURLOPT_MAXREDIRS => 3, CURLOPT_MAXREDIRS => 3,
CURLOPT_URL => $url, CURLOPT_URL => $url,
CURLOPT_USERAGENT => \sprintf(APP_USERAGENT, CURLOPT_USERAGENT => \sprintf(
APP_USERAGENT,
App::getEnv('_APP_VERSION', 'UNKNOWN'), App::getEnv('_APP_VERSION', 'UNKNOWN'),
App::getEnv('_APP_SYSTEM_SECURITY_EMAIL_ADDRESS', APP_EMAIL_SECURITY) App::getEnv('_APP_SYSTEM_SECURITY_EMAIL_ADDRESS', APP_EMAIL_SECURITY)
), ),
@ -322,8 +313,7 @@ App::get('/v1/avatars/favicon')
->setContentType('image/x-icon') ->setContentType('image/x-icon')
->addHeader('Expires', $date) ->addHeader('Expires', $date)
->addHeader('X-Appwrite-Cache', 'miss') ->addHeader('X-Appwrite-Cache', 'miss')
->send($data) ->send($data);
;
} }
$fetch = @\file_get_contents($outputHref, false); $fetch = @\file_get_contents($outputHref, false);
@ -368,19 +358,12 @@ App::get('/v1/avatars/qr')
/** @var Utopia\Response $response */ /** @var Utopia\Response $response */
$download = ($download === '1' || $download === 'true' || $download === 1 || $download === true); $download = ($download === '1' || $download === 'true' || $download === 1 || $download === true);
/* $renderer = new ImageRenderer(
new RendererStyle($size, $margin),
new ImagickImageBackEnd('png', 100)
); */
$qropts = new QROptions([ $qropts = new QROptions([
'quietzone' => $size 'quietzone' => $size
]); ]);
$qrcode = new QRCode($qropts); $qrcode = new QRCode($qropts);
$qrcode->render($text); $qrcode->render($text);
/* $writer = new Writer($renderer); */
if ($download) { if ($download) {
$response->addHeader('Content-Disposition', 'attachment; filename="qr.png"'); $response->addHeader('Content-Disposition', 'attachment; filename="qr.png"');
} }
@ -388,8 +371,7 @@ App::get('/v1/avatars/qr')
$response $response
->addHeader('Expires', \date('D, d M Y H:i:s', \time() + (60 * 60 * 24 * 45)) . ' GMT') // 45 days cache ->addHeader('Expires', \date('D, d M Y H:i:s', \time() + (60 * 60 * 24 * 45)) . ' GMT') // 45 days cache
->setContentType('image/png') ->setContentType('image/png')
/* ->send($writer->writeString($text)) */ ->send($qrcode->render($text));
;
}, ['response']); }, ['response']);
App::get('/v1/avatars/initials') App::get('/v1/avatars/initials')
@ -466,6 +448,5 @@ App::get('/v1/avatars/initials')
$response $response
->addHeader('Expires', \date('D, d M Y H:i:s', \time() + (60 * 60 * 24 * 45)) . ' GMT') // 45 days cache ->addHeader('Expires', \date('D, d M Y H:i:s', \time() + (60 * 60 * 24 * 45)) . ' GMT') // 45 days cache
->setContentType('image/png') ->setContentType('image/png')
->send($image->getImageBlob()) ->send($image->getImageBlob());
;
}, ['response', 'user']); }, ['response', 'user']);

View file

@ -49,9 +49,8 @@
"dragonmantank/cron-expression": "3.0.1", "dragonmantank/cron-expression": "3.0.1",
"domnikl/statsd": "3.0.*", "domnikl/statsd": "3.0.*",
"influxdb/influxdb-php": "1.15.*", "influxdb/influxdb-php": "1.15.*",
"bacon/bacon-qr-code": "2.0.2",
"phpmailer/phpmailer": "6.1.7", "phpmailer/phpmailer": "6.1.7",
"chillerlan/php-qrcode": "^4.1" "chillerlan/php-qrcode": "^4.2"
}, },
"require-dev": { "require-dev": {
"swoole/ide-helper": "4.5.4", "swoole/ide-helper": "4.5.4",