From b0a6190394dc93e6d818cd3ab944d32e4d15f051 Mon Sep 17 00:00:00 2001 From: Jake Barnby Date: Wed, 12 Apr 2023 00:05:19 +1200 Subject: [PATCH] Only iterate attributes once --- src/Appwrite/Migration/Version/V18.php | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/Appwrite/Migration/Version/V18.php b/src/Appwrite/Migration/Version/V18.php index adc7c4eb1d..aa7ee165a8 100644 --- a/src/Appwrite/Migration/Version/V18.php +++ b/src/Appwrite/Migration/Version/V18.php @@ -54,12 +54,11 @@ class V18 extends Migration foreach ($this->documentsIterator($databaseTable) as $collection) { $collectionTable = "{$databaseTable}_collection_{$collection->getInternalId()}"; - $floats = \array_filter($collection['attributes'] ?? [], function ($attribute) { - return $attribute['type'] === Database::VAR_FLOAT; - }); - - foreach ($floats as $attribute) { - $this->changeAttributeInternalType($collectionTable, $attribute['key'], 'DOUBLE'); + foreach ($collection['attributes'] ?? [] as $attribute) { + if ($attribute['type'] !== Database::VAR_FLOAT) { + continue; + } + $this->changeAttributeInternalType($collectionTable, $attribute['$id'], 'DOUBLE'); } } } @@ -77,11 +76,10 @@ class V18 extends Migration Console::log("Migrating Collection \"{$id}\""); - $floats = \array_filter($collection['attributes'] ?? [], function ($attribute) { - return $attribute['type'] === Database::VAR_FLOAT; - }); - - foreach ($floats as $attribute) { + foreach ($collection['attributes'] ?? [] as $attribute) { + if ($attribute['type'] !== Database::VAR_FLOAT) { + continue; + } $this->changeAttributeInternalType($id, $attribute['$id'], 'DOUBLE'); }